From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41D89CD98F1 for ; Wed, 17 Jun 2026 12:02:43 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wZoy4-0003nM-FF; Wed, 17 Jun 2026 08:02:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <163wangjack@gmail.com>) id 1wZorT-0002Sl-4M for qemu-arm@nongnu.org; Wed, 17 Jun 2026 07:55:16 -0400 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <163wangjack@gmail.com>) id 1wZorR-0006HA-IL for qemu-arm@nongnu.org; Wed, 17 Jun 2026 07:55:14 -0400 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-2c6d31bfc8aso731565ad.2 for ; Wed, 17 Jun 2026 04:55:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781697312; x=1782302112; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=934hamAJ+JSUr2HsPwZHL2EyxcVP/T+xXV5QPm/j1Y4=; b=bPwd/Jpm3tjFB+CmltKeI8d0kQ20twbWDHNKgCwUKnbNv9p/Abs2fipWtfSofUVBt2 Gmvt4vEFm+PtJqlNsJjaVoPIfdITXbwKKGRzJWZK0sU90culoJxMrjoCkTlL9pXkcpnl gFh3yND+TlBj133ne0HR+mHAx0RzEPI9fzOCEQNFGXDWfWHHnjth8/apmuzbbZGG82uU Y8h0ya4Yo0NQV0SxPkQBLP9CSiVN3YyrwqhKwkHxOI/yUIVTsGf/X2GzY5VD2jcqSTfx ihkAbvijK9Gdkfvz9c4X80A+hzWehjpPOgdRoHdqLUcPGGWL2C2zWLiq0SskzrcukoIV auhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781697312; x=1782302112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=934hamAJ+JSUr2HsPwZHL2EyxcVP/T+xXV5QPm/j1Y4=; b=LX7VNZGe0IxYcE1AHaKfpfMt27yYGUMOkQCFV1PXRw3ahoPpfUjw30jofUCTBiLISP RbkyG6liWRBQxB2CLH6nnI3es1AYHcyeLEPrIgYk3q+OBN7U4o5F8GbyOLtqgMech3Ea ZABunrKo9gOOvtuurz+lCRmCFd2xE0jXx4TCKN4xQCZWN1ujdKFJcoypWdl39tjcJIax +jk/CXWp1Q8g4EQqpYYdQtGpBAH+1ClIb+kIJRco35XMwVWopplrw1YjUKjL+LPwgKdl VmJwhesPa4vnKgO+saiZsxEa1bHBMF7a8d+df3ZTNbLG2sNqvvgeRrML3Z+L0ZcgJLZP ZGNg== X-Forwarded-Encrypted: i=1; AFNElJ9p2CJR2u/oXnH4oxsKVTDyGd0RXAvRI/O/xJjvnSALrvKi3vHtHhwso3Zofh9iuPcjCcWc3+iozg==@nongnu.org X-Gm-Message-State: AOJu0YyCLSb3HY62fX47jlF88S/V3BrVVLdm5BXIxhC0hRi2865I/XTS cZFdK/hzUUBuJiUCYUApxSIETuFcBDtRTGYIkLmGf4puVi+TFDx1bJ2IFoKgCQ== X-Gm-Gg: Acq92OFAPXg6GyCceR6BMh7R2tRcicDmuN83V1guhikfIQlkNDJy6mdxp/QpGEYH9+2 I9ea3Us15iPocj7Za7chlL64ifLDmqCFJGydBdEjHAEP0L0oUJNB5iS58b4wKJbCY6oV7aoej3S cMsCNWyXvf4dgivhT+DajIHWJWiBu9SHCnXaqVeQNy1lc9pb2rwWIozi++bzS1/zHhjumDKcZB9 maLWwwxS+fDasNbW3gdmLDW6Ol6BHF/58uaO59nvrYZUcOhNwY/L7YuV9KjQ+ArTWhp8+gXMxxz QghVIm2bchUsqy/9DnrqXx/TJOUkOZXGv8a6UEJymUx1MWDcfQN/UymcFisfSyWrlQJdI3bjBnH CSxby9vxElrnYzBkyMtrmpWauvToyap+GMn0swlipUf1+Un0urntHNGALiQQ5v71zMm0gmT9mFx 4nEwVBUVYfbSnCXsYjiLc/rZl5 X-Received: by 2002:a17:903:b0d:b0:2c6:95d1:3bbc with SMTP id d9443c01a7336-2c6bc1e0086mr34999805ad.24.1781697311702; Wed, 17 Jun 2026 04:55:11 -0700 (PDT) Received: from localhost.localdomain ([82.40.42.115]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42f1f1014sm163576605ad.16.2026.06.17.04.55.07 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 17 Jun 2026 04:55:11 -0700 (PDT) From: jw_mac <163wangjack@gmail.com> To: qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-trivial@nongnu.org Cc: peter.maydell@linaro.org, mjt@tls.msk.ru, laurent@vivier.eu, Wang Yuxin <163wangjack@gmail.com> Subject: [PATCH trivial] git format-patch -1 --subject-prefix="PATCH trivial"Signed-off-by: jw_mac <163wangjack@gamil.com> Date: Wed, 17 Jun 2026 19:54:42 +0800 Message-ID: <20260617115442.91715-2-163wangjack@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260617115442.91715-1-163wangjack@gmail.com> References: <20260617115442.91715-1-163wangjack@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=163wangjack@gmail.com; helo=mail-pl1-x62a.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_STARTS_WITH_NUMS=0.738, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 17 Jun 2026 08:02:03 -0400 X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org From: Wang Yuxin <163wangjack@gmail.com> hw/timer/imx_epit: Replace DPRINTF with trace events Clean up the codebase by removing the outdated DEBUG_IMX_EPIT and DPRINTF macros, replacing them with modern QEMU trace events. This also removes an empty and meaningless DPRINTF("\n") in the imx_epit_realize function. Signed-off-by: jw_mac <163wangjack@gmail.com> --- hw/timer/imx_epit.c | 25 +++++-------------------- hw/timer/trace-events | 8 ++++++++ 2 files changed, 13 insertions(+), 20 deletions(-) diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c index c67a39f10c..476e2771b3 100644 --- a/hw/timer/imx_epit.c +++ b/hw/timer/imx_epit.c @@ -20,18 +20,7 @@ #include "hw/misc/imx_ccm.h" #include "qemu/module.h" #include "qemu/log.h" - -#ifndef DEBUG_IMX_EPIT -#define DEBUG_IMX_EPIT 0 -#endif - -#define DPRINTF(fmt, args...) \ - do { \ - if (DEBUG_IMX_EPIT) { \ - fprintf(stderr, "[%s]%s: " fmt , TYPE_IMX_EPIT, \ - __func__, ##args); \ - } \ - } while (0) +#include "trace.h" static const char *imx_epit_reg_name(uint32_t reg) { @@ -80,7 +69,7 @@ static uint32_t imx_epit_get_freq(IMXEPITState *s) uint32_t prescaler = 1 + extract32(s->cr, CR_PRESCALE_SHIFT, CR_PRESCALE_BITS); uint32_t f_in = imx_ccm_get_clock_frequency(s->ccm, imx_epit_clocks[clksrc]); uint32_t freq = f_in / prescaler; - DPRINTF("ptimer frequency is %u\n", freq); + trace_imx_epit_get_freq(freq); return freq; } @@ -146,8 +135,7 @@ static uint64_t imx_epit_read(void *opaque, hwaddr offset, unsigned size) HWADDR_PRIx "\n", TYPE_IMX_EPIT, __func__, offset); break; } - - DPRINTF("(%s) = 0x%08x\n", imx_epit_reg_name(offset >> 2), reg_value); + trace_imx_epit_read(imx_epit_reg_name(offset >> 2), reg_value); return reg_value; } @@ -328,8 +316,7 @@ static void imx_epit_write(void *opaque, hwaddr offset, uint64_t value, { IMXEPITState *s = IMX_EPIT(opaque); - DPRINTF("(%s, value = 0x%08x)\n", imx_epit_reg_name(offset >> 2), - (uint32_t)value); + trace_imx_epit_write(imx_epit_reg_name(offset >> 2), (uint32_t)value); switch (offset >> 2) { case 0: /* CR */ @@ -362,7 +349,7 @@ static void imx_epit_cmp(void *opaque) /* The cmp ptimer can't be running when the peripheral is disabled */ assert(s->cr & CR_EN); - DPRINTF("sr was %d\n", s->sr); + trace_imx_epit_cmp(s->sr); /* Set interrupt status bit SR.OCIF and update the interrupt state */ s->sr |= SR_OCIF; imx_epit_update_int(s); @@ -399,8 +386,6 @@ static void imx_epit_realize(DeviceState *dev, Error **errp) IMXEPITState *s = IMX_EPIT(dev); SysBusDevice *sbd = SYS_BUS_DEVICE(dev); - DPRINTF("\n"); - sysbus_init_irq(sbd, &s->irq); memory_region_init_io(&s->iomem, OBJECT(s), &imx_epit_ops, s, TYPE_IMX_EPIT, 0x00001000); diff --git a/hw/timer/trace-events b/hw/timer/trace-events index ac5afe84e8..3c282800c6 100644 --- a/hw/timer/trace-events +++ b/hw/timer/trace-events @@ -122,3 +122,11 @@ hpet_ram_write_tn_cmp(uint8_t reg_off) "hpet_ram_writel HPET_TN_CMP + %" PRIu8 hpet_ram_write_invalid_tn_cmp(void) "invalid HPET_TN_CMP + 4 write" hpet_ram_write_invalid(void) "invalid hpet_ram_writel" hpet_ram_write_counter_write_while_enabled(void) "Writing counter while HPET enabled!" + +# imx_epit.c +imx_epit_get_freq(uint32_t freq) "ptimer frequency is %u" +imx_epit_read(const char *name, uint32_t value) "(%s) = 0x%08x" +imx_epit_write(const char *name, uint32_t value) "(%s, value = 0x%08x)" +imx_epit_cmp(uint32_t sr) "sr was %d" + + -- 2.53.0