From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F174CD98F0 for ; Wed, 17 Jun 2026 12:31:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P3jzRlAvbMS4PO93S55ryEyDMN65oeegQnxAP31x6UM=; b=OG4yd/eOFEX61e n68taGPbr+q6k6TL2AuyCqdo508E5BSBNb5h7pW6nvmtiTMJbg42gXAyKXxAGGbxb49epA6Tnv5GZ UD+tIXJ+sTtS2XLq9S+kOlZpfp5QSFXN+vADG7YT+karWtCExHsHcdHxricghYZ2Bzc8tbf74c8TF By0jIbYzQWgfvbYhhZtw76H67rEhXAoGMPj0+thdZ6/r3U9hqBX2y6LHs1QqCs5VWxLYJ/tSJB0Hy m6IJqEnbmUyWwwWNBj3p/ufF8xrJ0q98gAAA2H1sLss9oSapR3O8onxhc/y2J34t93FOoQ4Xag2+F Rm9xiJOfW6tGDytn3TpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZpQU-0000000HLQE-0MWj; Wed, 17 Jun 2026 12:31:26 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZpQS-0000000HLQ6-44lt for linux-phy@lists.infradead.org; Wed, 17 Jun 2026 12:31:25 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 67B9B40A0E; Wed, 17 Jun 2026 12:31:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D76D91F000E9; Wed, 17 Jun 2026 12:31:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781699484; bh=eazbb0s9Zzrv47U0UWMgcTY7KPZuo6+Xj9akgfjv5Bk=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=lV7H05RqKV8yrqDAxr0l/CiM7ocXK2eVD+uvb1y5HnhiUNMxBKvxkpf6YHnZNQKeK d0XlVnYcO3eeLYm747KXYOpxgDUBBeI6mR4YBxRkE1hDi4fMNcFmIsDvEzQll6x5FJ ctA56dkA06EnQH9o7iViG3BieafHxy3g0Q4l19sVjD2F3TWmBrsp+dcBUvrqA/Ljou eAuXTuVgEegrtYGu8R512E7an1AhjbS3/yPuZNZYO2dClHBrU8gMDSTTf4hlcpIiXz +/s2hef34Xn4l7znAbcG7En0ByCafjO36iu4b7Q9WxIh7PUf+nnrgeh1nhFcb3kh7C zEErXy/inB9lQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH 1/3] phy: rockchip: phy-rockchip-inno-csidphy: fix rk1808 hsfreq table To: "Gerald Loacker" Cc: devicetree@vger.kernel.org, neil.armstrong@linaro.org, conor+dt@kernel.org, vkoul@kernel.org, robh@kernel.org, olteanv@gmail.com, linux-phy@lists.infradead.org In-Reply-To: <20260617-feature-mipi-csi-dphy-4k60-v1-1-4611ff00b0ff@wolfvision.net> References: <20260617-feature-mipi-csi-dphy-4k60-v1-0-4611ff00b0ff@wolfvision.net> <20260617-feature-mipi-csi-dphy-4k60-v1-1-4611ff00b0ff@wolfvision.net> Date: Wed, 17 Jun 2026 12:31:23 +0000 Message-Id: <20260617123123.D76D91F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtIaWdoXSBWYWxpZCBsb3ctZnJlcXVlbmN5IHJhbmdlcyBtYXBwaW5nIHRvIGNvbmZpZ3VyYXRp b24gYml0IDB4MDAgYXJlIGluY29ycmVjdGx5IHJlamVjdGVkIGFzIGVycm9ycy4KLS0KCmNvbW1p dCA3M2U4NjgzOTY1MjU1YzM0NGJlYzQxYjQ0ZDQ4MGMxY2VjZTMzYjU3CkF1dGhvcjogR2VyYWxk IExvYWNrZXIgPGdlcmFsZC5sb2Fja2VyQHdvbGZ2aXNpb24ubmV0PgoKcGh5OiByb2NrY2hpcDog cGh5LXJvY2tjaGlwLWlubm8tY3NpZHBoeTogZml4IHJrMTgwOCBoc2ZyZXEgdGFibGUKClRoaXMg Y29tbWl0IGV4dGVuZHMgdGhlIGZpbmFsIGVudHJ5IGluIHRoZSByazE4MDggaHNmcmVxIHRhYmxl IHRvIGV4YWN0bHkKMjUwMCBNYnBzLiBUaGlzIGFsbG93cyB0aGUgUkszNTg4LCB3aGljaCByZXVz ZXMgdGhpcyBhcnJheSwgdG8gZnVsbHkKc3VwcG9ydCByYXRlcyB1cCB0byAyNTAwIE1icHMuCgo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BoeS9yb2NrY2hpcC9waHktcm9ja2NoaXAtaW5uby1jc2lk cGh5LmMgYi9kcml2ZXJzL3BoeS9yb2NrY2hpcC9waHktcm9ja2NoaXAtaW5uby1jc2lkcGh5LmMK PiBpbmRleCBjNzlmYjUzZDhlZTVjLi41MjgxZjhkZWEwYWQzIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvcGh5L3JvY2tjaGlwL3BoeS1yb2NrY2hpcC1pbm5vLWNzaWRwaHkuYwo+ICsrKyBiL2RyaXZl cnMvcGh5L3JvY2tjaGlwL3BoeS1yb2NrY2hpcC1pbm5vLWNzaWRwaHkuYwo+IEBAIC0xNzAsNyAr MTcwLDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBoc2ZyZXFfcmFuZ2UgcmsxODA4X21pcGlkcGh5 X2hzZnJlcV9yYW5nZXNbXSA9IHsKPiAgCXsgMjk5LCAweDA2fSwgeyAzOTksIDB4MDh9LCB7IDQ5 OSwgMHgwYn0sIHsgNTk5LCAweDBlfSwKPiAgCXsgNjk5LCAweDEwfSwgeyA3OTksIDB4MTJ9LCB7 IDk5OSwgMHgxNn0sIHsxMTk5LCAweDFlfSwKPiAgCXsxMzk5LCAweDIzfSwgezE1OTksIDB4MmR9 LCB7MTc5OSwgMHgzMn0sIHsxOTk5LCAweDM3fSwKPiAtCXsyMTk5LCAweDNjfSwgezIzOTksIDB4 NDF9LCB7MjQ5OSwgMHg0Nn0KPiArCXsyMTk5LCAweDNjfSwgezIzOTksIDB4NDF9LCB7MjUwMCwg MHg0Nn0KPiAgfTsKPiAgCj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgaHNmcmVxX3JhbmdlIHJrMzMy Nl9taXBpZHBoeV9oc2ZyZXFfcmFuZ2VzW10gPSB7CgpbU2V2ZXJpdHk6IEhpZ2hdClRoaXMgaXMg YSBwcmUtZXhpc3RpbmcgaXNzdWUsIGJ1dCB3aGlsZSBsb29raW5nIGF0IHRoZXNlIGZyZXF1ZW5j eSByYW5nZQp0YWJsZXMgaXQgYXBwZWFycyB0aGF0IHZhbGlkIGxvdy1mcmVxdWVuY3kgY29uZmln dXJhdGlvbnMgYXJlIGluY29ycmVjdGx5CnJlamVjdGVkIGFzIGVycm9ycy4KCkluIHJvY2tjaGlw X2lubm9fY3NpZHBoeV9jb25maWd1cmUoKSwgdGhlIGNvZGUgaXRlcmF0ZXMgdGhyb3VnaCB0aGUK aHNmcmVxX3JhbmdlcyB0byBmaW5kIHRoZSBjZmdfYml0OgoKZHJpdmVycy9waHkvcm9ja2NoaXAv cGh5LXJvY2tjaGlwLWlubm8tY3NpZHBoeS5jOnJvY2tjaGlwX2lubm9fY3NpZHBoeV9jb25maWd1 cmUoKSB7CiAgICAuLi4KICAgIGlmICghaHNmcmVxKQogICAgICAgIHJldHVybiAtRUlOVkFMOwog ICAgLi4uCn0KClRoZSByazMzMjZfbWlwaWRwaHlfaHNmcmVxX3JhbmdlcyB0YWJsZSBkZWZpbmVz IGFuIGVudHJ5IGZvciBmcmVxdWVuY2llcyB1cAp0byAxMDkgTWJwcyB3aXRoIGEgdmFsaWQgY2Zn X2JpdCBvZiAweDAwOgoKICAgIHsgMTA5LCAweDAwfSwgeyAxNDksIDB4MDF9LCB7IDE5OSwgMHgw Mn0sIHsgMjQ5LCAweDAzfSwKCklmIHRoZSBkYXRhIHJhdGUgZmFsbHMgaW50byB0aGlzIGxvd2Vz dCByYW5nZSwgaHNmcmVxIGlzIGNvcnJlY3RseSBzZXQKdG8gMHgwMCwgYnV0IHRoZSBzdWJzZXF1 ZW50IGlmICghaHNmcmVxKSBjaGVjayBldmFsdWF0ZXMgdG8gdHJ1ZSBhbmQKaW5jb3JyZWN0bHkg cmV0dXJucyAtRUlOVkFMIGluc3RlYWQgb2YgYXBwbHlpbmcgdGhlIGNvbmZpZ3VyYXRpb24uCgpB IHNpbWlsYXIgaXNzdWUgYXBwZWFycyBpbiBya19kcGh5X2NvbmZpZ3VyZSgpIGluc2lkZSAKZHJp dmVycy9waHkvcm9ja2NoaXAvcGh5LXJvY2tjaGlwLWRwaHktcngwLmMgd2l0aCB0YWJsZXMgbGlr ZQpyazMzOTlfbWlwaWRwaHlfaHNmcmVxX3JhbmdlcyB3aGljaCBoYXMgeyA4OSwgMHgwMCB9LgoK Q291bGQgdGhpcyB2YWxpZGF0aW9uIGJlIG1vZGlmaWVkIHRvIHZlcmlmeSBpZiBhIHZhbGlkIG1h dGNoIHdhcyBmb3VuZCAKZHVyaW5nIGl0ZXJhdGlvbiByYXRoZXIgdGhhbiBjaGVja2luZyBpZiB0 aGUgcmVzdWx0aW5nIGNvbmZpZ3VyYXRpb24gYml0IAppcyBub24temVybz8KCi0tIApTYXNoaWtv IEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA2MTctZmVh dHVyZS1taXBpLWNzaS1kcGh5LTRrNjAtdjEtMC00NjExZmYwMGIwZmZAd29sZnZpc2lvbi5uZXQ/ cGFydD0xCgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 024EE3F0A9F for ; Wed, 17 Jun 2026 12:31:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781699486; cv=none; b=gRQhtBZwIL3ZukeZBRGrhH86sKkCJ6ZWneFiKTzD9s0D15ARu9NAkdF0MYBkOcTO7c0Cs/QduOq2id6i3Qy+R7kXQmcbSTry1so2Q4uwK6O0t7242C5tix/LC8wukYoIgRRhqmBuLIlE/un+JjrggaE2l6OCbH9oBYZ4gjwxMgs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781699486; c=relaxed/simple; bh=Ec2O03+8FL79cABuBc08lOUQlC3R5Ia0iaAbOWW9Qbs=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=gR6V0xpQZtFe7XJcr/uLUbqXD4gpUZXF3Y3J8DeSDZ09N32kuWLeGnLgnniDGxslwsCEdtM+fT5qvN64T0w8ZPJpCdPtm1h7IJ5U/jVYGhlChShAEtZ+EvkfHDDnjHD7CgL6pGvM+TJG5SYwmYKsf4rvNZRC8leSqaZYLQjWJS0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lV7H05Rq; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lV7H05Rq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D76D91F000E9; Wed, 17 Jun 2026 12:31:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781699484; bh=eazbb0s9Zzrv47U0UWMgcTY7KPZuo6+Xj9akgfjv5Bk=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=lV7H05RqKV8yrqDAxr0l/CiM7ocXK2eVD+uvb1y5HnhiUNMxBKvxkpf6YHnZNQKeK d0XlVnYcO3eeLYm747KXYOpxgDUBBeI6mR4YBxRkE1hDi4fMNcFmIsDvEzQll6x5FJ ctA56dkA06EnQH9o7iViG3BieafHxy3g0Q4l19sVjD2F3TWmBrsp+dcBUvrqA/Ljou eAuXTuVgEegrtYGu8R512E7an1AhjbS3/yPuZNZYO2dClHBrU8gMDSTTf4hlcpIiXz +/s2hef34Xn4l7znAbcG7En0ByCafjO36iu4b7Q9WxIh7PUf+nnrgeh1nhFcb3kh7C zEErXy/inB9lQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH 1/3] phy: rockchip: phy-rockchip-inno-csidphy: fix rk1808 hsfreq table Reply-To: sashiko-reviews@lists.linux.dev To: "Gerald Loacker" Cc: devicetree@vger.kernel.org, neil.armstrong@linaro.org, conor+dt@kernel.org, vkoul@kernel.org, robh@kernel.org, olteanv@gmail.com, linux-phy@lists.infradead.org In-Reply-To: <20260617-feature-mipi-csi-dphy-4k60-v1-1-4611ff00b0ff@wolfvision.net> References: <20260617-feature-mipi-csi-dphy-4k60-v1-0-4611ff00b0ff@wolfvision.net> <20260617-feature-mipi-csi-dphy-4k60-v1-1-4611ff00b0ff@wolfvision.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 17 Jun 2026 12:31:23 +0000 Message-Id: <20260617123123.D76D91F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: Pre-existing issues: - [High] Valid low-frequency ranges mapping to configuration bit 0x00 are i= ncorrectly rejected as errors. -- commit 73e8683965255c344bec41b44d480c1cece33b57 Author: Gerald Loacker phy: rockchip: phy-rockchip-inno-csidphy: fix rk1808 hsfreq table This commit extends the final entry in the rk1808 hsfreq table to exactly 2500 Mbps. This allows the RK3588, which reuses this array, to fully support rates up to 2500 Mbps. > diff --git a/drivers/phy/rockchip/phy-rockchip-inno-csidphy.c b/drivers/p= hy/rockchip/phy-rockchip-inno-csidphy.c > index c79fb53d8ee5c..5281f8dea0ad3 100644 > --- a/drivers/phy/rockchip/phy-rockchip-inno-csidphy.c > +++ b/drivers/phy/rockchip/phy-rockchip-inno-csidphy.c > @@ -170,7 +170,7 @@ static const struct hsfreq_range rk1808_mipidphy_hsfr= eq_ranges[] =3D { > { 299, 0x06}, { 399, 0x08}, { 499, 0x0b}, { 599, 0x0e}, > { 699, 0x10}, { 799, 0x12}, { 999, 0x16}, {1199, 0x1e}, > {1399, 0x23}, {1599, 0x2d}, {1799, 0x32}, {1999, 0x37}, > - {2199, 0x3c}, {2399, 0x41}, {2499, 0x46} > + {2199, 0x3c}, {2399, 0x41}, {2500, 0x46} > }; > =20 > static const struct hsfreq_range rk3326_mipidphy_hsfreq_ranges[] =3D { [Severity: High] This is a pre-existing issue, but while looking at these frequency range tables it appears that valid low-frequency configurations are incorrectly rejected as errors. In rockchip_inno_csidphy_configure(), the code iterates through the hsfreq_ranges to find the cfg_bit: drivers/phy/rockchip/phy-rockchip-inno-csidphy.c:rockchip_inno_csidphy_conf= igure() { ... if (!hsfreq) return -EINVAL; ... } The rk3326_mipidphy_hsfreq_ranges table defines an entry for frequencies up to 109 Mbps with a valid cfg_bit of 0x00: { 109, 0x00}, { 149, 0x01}, { 199, 0x02}, { 249, 0x03}, If the data rate falls into this lowest range, hsfreq is correctly set to 0x00, but the subsequent if (!hsfreq) check evaluates to true and incorrectly returns -EINVAL instead of applying the configuration. A similar issue appears in rk_dphy_configure() inside=20 drivers/phy/rockchip/phy-rockchip-dphy-rx0.c with tables like rk3399_mipidphy_hsfreq_ranges which has { 89, 0x00 }. Could this validation be modified to verify if a valid match was found=20 during iteration rather than checking if the resulting configuration bit=20 is non-zero? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260617-feature-mi= pi-csi-dphy-4k60-v1-0-4611ff00b0ff@wolfvision.net?part=3D1