From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD4FE3BED76 for ; Wed, 17 Jun 2026 12:32:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781699543; cv=none; b=cZ/bM4lzRDZ4sjvp6d7cUrGtH0hguLklW8C3M9OoP9YamAqPZ+NtkC2/n0toZvuKxGOI68LEBkv1JrpD9gDjDMx+pDg6J2TaC/KtRJFeuBNZ+e80Qt2nMyKk4D+nnnRXxMdTBmthS03iaiJNVqOgn3Ty/v9ZBenuZaUxTv6LPjA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781699543; c=relaxed/simple; bh=tTH8NONTChM82m/DO1zeRlGkqjc0KyAS6AVoZvl/peo=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=pUHCjEDoA9tULSoIJiSX4y4eBNYERfTaiprinKawju2zadH/KwRyrNe2Wpoj5OQeRdgiRLT8/1UAGrHC8FdNEMP6znS+7NnTmUceVaZohdDfgD+FG5Ze0uWdwCRKUDlD+oO0aWR4f25Q6EDJexQ617/dXwdjPslt1mGm8nKBLTs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nhRCnVWN; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nhRCnVWN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3818E1F000E9; Wed, 17 Jun 2026 12:32:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781699542; bh=cvBZCD+ESZXuE0hqtc7yYxl9khsYkQUqRu69GHQbo9c=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=nhRCnVWNxFW/vIkLzgOoLH8L7JneoCmav2faJv9FLjQZPbzXhFMpXfZ7wT1o8WyUg 9CEamXoSD0366pGEfeVf45IEwWd1bi8RKCr0abS8W8EPLeaqBhioldMXSsRJWbW/Fe Hno3RUOEbiUy7MIhy2BHbfEtEv33ecUPl5I6UYX7ieu4CUNe+fYv/vsD9RTT/ErvIR wgigJ3UHBA1HHdHnaX5XfrIoBkxbjTaCwvZqJwXmkKdYWuwBaSMLEHKd96COJPzROb nSCdDBjTIdNpRwNoBmF/csW4zrODnZcQIKPoz4zoLdWvMNPdxZXiZcTQyPsMta96k/ UvWFl36qpqMdg== From: sashiko-bot@kernel.org Subject: Re: [PATCH 3/3] phy: rockchip: phy-rockchip-inno-csidphy: add clock lane phase tuning Reply-To: sashiko-reviews@lists.linux.dev To: "Gerald Loacker" Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com, vkoul@kernel.org, linux-phy@lists.infradead.org, robh@kernel.org In-Reply-To: <20260617-feature-mipi-csi-dphy-4k60-v1-3-4611ff00b0ff@wolfvision.net> References: <20260617-feature-mipi-csi-dphy-4k60-v1-0-4611ff00b0ff@wolfvision.net> <20260617-feature-mipi-csi-dphy-4k60-v1-3-4611ff00b0ff@wolfvision.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 17 Jun 2026 12:32:21 +0000 Message-Id: <20260617123222.3818E1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The macro `CSIDPHY_CLK_PHASE_DEFAULT` is defined but never used. -- commit bfbb498bdd0c6aad9c80d6fe31b34f8a03261c76 Author: Gerald Loacker phy: rockchip: phy-rockchip-inno-csidphy: add clock lane phase tuning This commit adds support for parsing and applying the optional 'rockchip,clk-lane-phase' device tree property. It allows for board-specific tuning of the clock lane sampling phase. If the property is absent, the dri= ver relies on the hardware default without actively writing to the register. > diff --git a/drivers/phy/rockchip/phy-rockchip-inno-csidphy.c b/drivers/p= hy/rockchip/phy-rockchip-inno-csidphy.c > index 5281f8dea0ad3..3a15840e86cad 100644 > --- a/drivers/phy/rockchip/phy-rockchip-inno-csidphy.c > +++ b/drivers/phy/rockchip/phy-rockchip-inno-csidphy.c > @@ -69,6 +69,10 @@ > #define RK1808_CSIDPHY_CLK_CALIB_EN 0x168 > #define RK3568_CSIDPHY_CLK_CALIB_EN 0x168 > =20 > +#define CSIDPHY_LANE_CLK_3_PHASE 0x38 > +#define CSIDPHY_CLK_PHASE_MASK GENMASK(6, 4) > +#define CSIDPHY_CLK_PHASE_DEFAULT 3 [Severity: Low] This isn't a bug, but it looks like CSIDPHY_CLK_PHASE_DEFAULT is defined here but never actually used in the driver code. Since the fallback logic correctly relies on leaving the hardware at its default state when the device tree property is missing (by initializing clk_phase to -1), could this unused macro be removed to avoid keeping dead code around? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260617-feature-mi= pi-csi-dphy-4k60-v1-0-4611ff00b0ff@wolfvision.net?part=3D3 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63B78CD98F0 for ; Wed, 17 Jun 2026 12:32:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wIc3AJnvXYpNvhE0walxV2vtJWxXfm5z2oR2eRfGwzM=; b=uJOBoXrw97hPku lWMJWQ6bfFyLS+KAHxD0hxbrwJW5DXF/JXiTzqg20N+csqj1eOZBBTL/7JYvvyVju6ouulqDA2xxr 3LCK0kiepzYZ7YL/HphVi17lyrCGBin2kdGKT7J+iCYxQef7cKzhG+ym64rqodxgS9hM7x2i8D1ma rHZGkk/TRgU3iBeqoAHsx+nQpD7ycBtBQBZg8MLldvP4M/krm8/Xp7zxHqbWjIv8l/KF6eQ7EYvfh iVLsZtWri/I/HwuVgU4twtXXpM3/xIwP2gYq+VPQlD3ioXmEpY9fmAChkEApvntprVvr1bf5Fju07 +kEShlw1eanKIvJborIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZpRQ-0000000HLTE-0kHO; Wed, 17 Jun 2026 12:32:24 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZpRO-0000000HLT0-3rXD for linux-phy@lists.infradead.org; Wed, 17 Jun 2026 12:32:22 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id AAD834374C; Wed, 17 Jun 2026 12:32:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3818E1F000E9; Wed, 17 Jun 2026 12:32:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781699542; bh=cvBZCD+ESZXuE0hqtc7yYxl9khsYkQUqRu69GHQbo9c=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=nhRCnVWNxFW/vIkLzgOoLH8L7JneoCmav2faJv9FLjQZPbzXhFMpXfZ7wT1o8WyUg 9CEamXoSD0366pGEfeVf45IEwWd1bi8RKCr0abS8W8EPLeaqBhioldMXSsRJWbW/Fe Hno3RUOEbiUy7MIhy2BHbfEtEv33ecUPl5I6UYX7ieu4CUNe+fYv/vsD9RTT/ErvIR wgigJ3UHBA1HHdHnaX5XfrIoBkxbjTaCwvZqJwXmkKdYWuwBaSMLEHKd96COJPzROb nSCdDBjTIdNpRwNoBmF/csW4zrODnZcQIKPoz4zoLdWvMNPdxZXiZcTQyPsMta96k/ UvWFl36qpqMdg== From: sashiko-bot@kernel.org Subject: Re: [PATCH 3/3] phy: rockchip: phy-rockchip-inno-csidphy: add clock lane phase tuning To: "Gerald Loacker" Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com, vkoul@kernel.org, linux-phy@lists.infradead.org, robh@kernel.org In-Reply-To: <20260617-feature-mipi-csi-dphy-4k60-v1-3-4611ff00b0ff@wolfvision.net> References: <20260617-feature-mipi-csi-dphy-4k60-v1-0-4611ff00b0ff@wolfvision.net> <20260617-feature-mipi-csi-dphy-4k60-v1-3-4611ff00b0ff@wolfvision.net> Date: Wed, 17 Jun 2026 12:32:21 +0000 Message-Id: <20260617123222.3818E1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0xvd10gVGhlIG1hY3JvIGBDU0lE UEhZX0NMS19QSEFTRV9ERUZBVUxUYCBpcyBkZWZpbmVkIGJ1dCBuZXZlciB1c2VkLgotLQoKY29t bWl0IGJmYmI0OThiZGQwYzZhYWQ5YzgwZDZmZTMxYjM0ZjhhMDMyNjFjNzYKQXV0aG9yOiBHZXJh bGQgTG9hY2tlciA8Z2VyYWxkLmxvYWNrZXJAd29sZnZpc2lvbi5uZXQ+CgpwaHk6IHJvY2tjaGlw OiBwaHktcm9ja2NoaXAtaW5uby1jc2lkcGh5OiBhZGQgY2xvY2sgbGFuZSBwaGFzZSB0dW5pbmcK ClRoaXMgY29tbWl0IGFkZHMgc3VwcG9ydCBmb3IgcGFyc2luZyBhbmQgYXBwbHlpbmcgdGhlIG9w dGlvbmFsCidyb2NrY2hpcCxjbGstbGFuZS1waGFzZScgZGV2aWNlIHRyZWUgcHJvcGVydHkuIEl0 IGFsbG93cyBmb3IgYm9hcmQtc3BlY2lmaWMKdHVuaW5nIG9mIHRoZSBjbG9jayBsYW5lIHNhbXBs aW5nIHBoYXNlLiBJZiB0aGUgcHJvcGVydHkgaXMgYWJzZW50LCB0aGUgZHJpdmVyCnJlbGllcyBv biB0aGUgaGFyZHdhcmUgZGVmYXVsdCB3aXRob3V0IGFjdGl2ZWx5IHdyaXRpbmcgdG8gdGhlIHJl Z2lzdGVyLgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJvY2tjaGlw LWlubm8tY3NpZHBoeS5jIGIvZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJvY2tjaGlwLWlubm8t Y3NpZHBoeS5jCj4gaW5kZXggNTI4MWY4ZGVhMGFkMy4uM2ExNTg0MGU4NmNhZCAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL3BoeS9yb2NrY2hpcC9waHktcm9ja2NoaXAtaW5uby1jc2lkcGh5LmMKPiAr KysgYi9kcml2ZXJzL3BoeS9yb2NrY2hpcC9waHktcm9ja2NoaXAtaW5uby1jc2lkcGh5LmMKPiBA QCAtNjksNiArNjksMTAgQEAKPiAgI2RlZmluZSBSSzE4MDhfQ1NJRFBIWV9DTEtfQ0FMSUJfRU4J CTB4MTY4Cj4gICNkZWZpbmUgUkszNTY4X0NTSURQSFlfQ0xLX0NBTElCX0VOCQkweDE2OAo+ICAK PiArI2RlZmluZSBDU0lEUEhZX0xBTkVfQ0xLXzNfUEhBU0UJCTB4MzgKPiArI2RlZmluZSBDU0lE UEhZX0NMS19QSEFTRV9NQVNLCQkJR0VOTUFTSyg2LCA0KQo+ICsjZGVmaW5lIENTSURQSFlfQ0xL X1BIQVNFX0RFRkFVTFQJCTMKCltTZXZlcml0eTogTG93XQpUaGlzIGlzbid0IGEgYnVnLCBidXQg aXQgbG9va3MgbGlrZSBDU0lEUEhZX0NMS19QSEFTRV9ERUZBVUxUIGlzIGRlZmluZWQKaGVyZSBi dXQgbmV2ZXIgYWN0dWFsbHkgdXNlZCBpbiB0aGUgZHJpdmVyIGNvZGUuCgpTaW5jZSB0aGUgZmFs bGJhY2sgbG9naWMgY29ycmVjdGx5IHJlbGllcyBvbiBsZWF2aW5nIHRoZSBoYXJkd2FyZSBhdCBp dHMKZGVmYXVsdCBzdGF0ZSB3aGVuIHRoZSBkZXZpY2UgdHJlZSBwcm9wZXJ0eSBpcyBtaXNzaW5n IChieSBpbml0aWFsaXppbmcKY2xrX3BoYXNlIHRvIC0xKSwgY291bGQgdGhpcyB1bnVzZWQgbWFj cm8gYmUgcmVtb3ZlZCB0byBhdm9pZCBrZWVwaW5nCmRlYWQgY29kZSBhcm91bmQ/CgotLSAKU2Fz aGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYwNjE3 LWZlYXR1cmUtbWlwaS1jc2ktZHBoeS00azYwLXYxLTAtNDYxMWZmMDBiMGZmQHdvbGZ2aXNpb24u bmV0P3BhcnQ9MwoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtcGh5Cg==