From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, Andi Shyti <andi.shyti@kernel.org>,
Mika Westerberg <westeri@kernel.org>,
hardikprakash.official@gmail.com
Subject: Re: [PATCH v1 1/1] i2c: acpi: Free resource list at appropriate time
Date: Wed, 17 Jun 2026 15:02:07 +0200 [thread overview]
Message-ID: <20260617130207.GH2990@black.igk.intel.com> (raw)
In-Reply-To: <20260617092046.2649219-1-andriy.shevchenko@linux.intel.com>
On Wed, Jun 17, 2026 at 11:20:46AM +0200, Andy Shevchenko wrote:
> We do unneeded "double free" (emptying an empty list) in one case.
> At the same time we shadow a real error code. Address them by
> refactoring the code in question.
>
> Both are not critical issues at all, they just make code robust
> against any possible future changes in the flow.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
prev parent reply other threads:[~2026-06-17 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 9:20 [PATCH v1 1/1] i2c: acpi: Free resource list at appropriate time Andy Shevchenko
2026-06-17 13:02 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260617130207.GH2990@black.igk.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hardikprakash.official@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.