Re: [PATCH v4 5/5] arm64: dts: qcom: sm8650-hdk: add SPMI ADC channels and thermal nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [High] Dangerously high and ineffective passive trip points for skin and ambient thermal zones.
- [Low] Use of undefined macro ADC5_GEN3_DIE_TEMP(x) causes a DTC syntax error.
- [Low] The unit-address of the pm8550ve_die_temp ADC channel node does not match its reg property.
--

commit f0b9d1fd765aad624439c8e56ebe37c1e26e52c9
Author: Neil Armstrong <neil.armstrong@linaro.org>

arm64: dts: qcom: sm8650-hdk: add SPMI ADC channels and thermal nodes
    
Add the SPMI ADC channels on the PMK8550 SPMI5 ADC3 for the
other PMICS on the system.

> diff --git a/arch/arm64/boot/dts/qcom/sm8650-hdk.dts b/arch/arm64/boot/dts/qcom/sm8650-hdk.dts
> index eabc828c05b4c..05af2913055ed 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8650-hdk.dts
> @@ -220,6 +220,92 @@ platform {
>  		};
>  	};
>  
> +	thermal-zones {
> +		skin-thermal {
> +			thermal-sensors = <&pmk8550_vadc ADC5_GEN3_AMUX1_THM_100K_PU(1)>;

[Severity: Low]
Is the header defining parameterized macros like ADC5_GEN3_AMUX1_THM_100K_PU(x) 
missing? Without it, the C preprocessor leaves the macro unexpanded, or expands 
the parameterless constant in include/linux/iio/adc/qcom-adc5-gen3-common.h to 
0x03(1), which causes a DTC syntax error and breaks the build.

> +
> +			trips {
> +				active-config0 {
> +					temperature = <125000>;
> +					hysteresis = <1000>;
> +					type = "passive";
> +				};

[Severity: High]
Is it intentional to set the passive trip point for the skin-thermal zone to 
125°C? While 125°C is a typical critical threshold for internal silicon dies, 
it is physically impossible for skin or external surface temperatures without 
causing severe burns or melting the device. Does this functionally disable 
skin thermal mitigation?

[ ... ]

> @@ -1041,27 +1127,218 @@ led@3 {
>  	};
>  };

[ ... ]

> +	/* PM8550VE Channel nodes */
> +	channel@503 {
> +		reg = <ADC5_GEN3_DIE_TEMP(PMK8550VE_SID)>;
> +		label = "pm8550ve_die_temp";

[Severity: Low]
Does the unit-address channel@503 match the evaluated reg property here? 
Assuming PMK8550VE_SID is 8, the standard SPMI ADC encoding (sid << 8 | offset) 
would evaluate to 0x803, making the unit-address channel@503 mismatched. 
Should this be updated to channel@803 to avoid dtc validation warnings?

> +		qcom,pre-scaling = <1 1>;
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260617-topic-sm8x50-adc5-gen3-v4-0-4af9251731f1@linaro.org?part=5