From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D7C73655C3 for ; Wed, 17 Jun 2026 17:44:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781718255; cv=none; b=QXbbbxSRALfcSWB7lVY2rryA54eO0+jqIXEAcae2seOQEJkPNol3+6GhLpbmwe1q55EF1AyReGj3X6/PFST1t0L5eABys3o8yFczsVuDkjZ3CJuJhi98LpjM3uLrmq0XSj99odVrME21O348nUkVQEt2/lLt/CA9Ua7F8Yh5e04= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781718255; c=relaxed/simple; bh=D7YsTeS2SJsOFVEkydcQ+J71qHUgcO91GdcN8kX2NUI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KD+rRR7JDkL8N9PFZRWS85fYVlywr8ludd+1ca5fK+9z2FxdOUcKfv9RPhtsZ6MW9RXIXdGxlaXR9kKrI6yoVXs5WchPh6UMHBn6x9uDdm3mJwqgTmQOpaW9RR2Pg4Sy89MrOEtAb3YlabAw4fQMqx+6CmRyGGdG5+L9mJNPIuU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=OYCkud8V; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="OYCkud8V" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65HFpp27744622; Wed, 17 Jun 2026 17:43:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=sa9nIsnpz+3tquoRF rPdyrke4h+lWN5t6FKPUHN9HxE=; b=OYCkud8VwOfOv+tdoiWJHuN0x4cR4G/2d tTA4o/wwDuf/nBzmmdVhQ01Cw3AYC2/SqcRxXgm/PGJLSAp1xVBfOhwKj/CeMdw3 EVpGeXeVVrbwFR+ykq4VLgbo05pvwJleC2lkTosUj5KXnIv9lLTI7SJ2P6U5bWVQ 6MwNO9evVbWARxn7f6UorS80XUKsf4htyXmSiI8wFX2kE+23k1xd7cgpSyCx7Mk3 IITFHW7whmcjukfXuxrbcTwkftXutcPFVPdkObLjZ6ruMa3rigibI6DOZCt6CiOj iPPmLpOZ1tS5wTLPNA5QCgiD3w6ffGIiyviNULWEan8I4Jiq1g2vA== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4eueqx477v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Jun 2026 17:43:50 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 65HHYhQ8031104; Wed, 17 Jun 2026 17:43:49 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4eudvacc3s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Jun 2026 17:43:49 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 65HHhkjF31588618 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Jun 2026 17:43:46 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0732220049; Wed, 17 Jun 2026 17:43:46 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EA13220040; Wed, 17 Jun 2026 17:43:38 +0000 (GMT) Received: from li-7bb28a4c-2dab-11b2-a85c-887b5c60d769.ibm.com.com (unknown [9.39.28.77]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 17 Jun 2026 17:43:38 +0000 (GMT) From: Shrikanth Hegde To: linux-kernel@vger.kernel.org, mingo@kernel.org, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, yury.norov@gmail.com, kprateek.nayak@amd.com, iii@linux.ibm.com Cc: sshegde@linux.ibm.com, tglx@kernel.org, gregkh@linuxfoundation.org, pbonzini@redhat.com, seanjc@google.com, vschneid@redhat.com, huschle@linux.ibm.com, rostedt@goodmis.org, dietmar.eggemann@arm.com, mgorman@suse.de, bsegall@google.com, maddy@linux.ibm.com, srikar@linux.ibm.com, hdanton@sina.com, chleroy@kernel.org, vineeth@bitbyteword.org, frederic@kernel.org, arighi@nvidia.com, pauld@redhat.com, christian.loehle@arm.com, tj@kernel.org, tommaso.cucinotta@gmail.com, maz@kernel.org, rafael@kernel.org Subject: [PATCH v4 10/20] sched/core: Push current task from non preferred CPU Date: Wed, 17 Jun 2026 23:11:29 +0530 Message-ID: <20260617174139.155540-11-sshegde@linux.ibm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260617174139.155540-1-sshegde@linux.ibm.com> References: <20260617174139.155540-1-sshegde@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE3MDE2NiBTYWx0ZWRfX/VyuMGzwK/98 UPJJP+BGim9mX5DHI9vwh9IOkOK2WWS1Llp6DtT6kij0pL7tyEHdxnlgX32XopvSc2k5nkyRMHz HfXDp3A7vybj7d54yM6aftVu3SX3Av9qibADtn1q6rUQNjp5gZg6ah7hU73Fto8jg4D+wfeF2PD NYlSlpdwcCIQdWHmRDYhgOzFVbp25NeLEgzXuYQ432vF1XiHJ7nNtEmxldze49V6WX0FzMZ41vL gTpxbI0s9tEMlsHqfxGk7waWcl8Te+TtoBH+zgPgPiroG2IprLV0kBHwG2qq+FCHGX3H2Hb0khz X69UgdreuPnDr6kym030fLai0fDUvtyDZLp1EMEj/k4eWu4xzguFIqfENvk5P6XFP6h9UqHlSn7 MB2+SR3idhG8cDpaxIllFmkvGvwye06UcN/3tIiVPULj1vIvxVYxta193NrJJ22EhIldyDRbQZb ilQZflE5UJKw9k/7rmg== X-Proofpoint-GUID: 0klB-Uu-2MXMSpZj864FxA1kgzxVSewf X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE3MDE2NiBTYWx0ZWRfXyHGYrSWHojZF oHs/zz7LzH/CbKTgdpisdsEbDsmsfhmweCT24e/lPMOWkJPCkICYDJE7DerOWlAmadZAAaCjeqn Fxn3WvyUM49oRx+Hy0HZO9w8eJIPY8o= X-Proofpoint-ORIG-GUID: XXjJ86IpLS1mc0MNus-byXWVouNCcmR9 X-Authority-Analysis: v=2.4 cv=auGCzyZV c=1 sm=1 tr=0 ts=6a32dcd7 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=FelO9ux0wxsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VnNF1IyMAAAA:8 a=-V1Il3ZtyC_IZvi6r-EA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-17_02,2026-06-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606170166 Actively push out task running on a non-preferred CPU. Since the task is running on the CPU, need to stop the cpu and push the task out. However, if the task in pinned only to non-preferred CPUs, it will continue running there. This will help in maintaining the userspace affinities unlike CPU hotplug or isolated cpusets. Though code is almost same as __balance_push_cpu_stop and quite close to push_cpu_stop, it is being kept separate as it provides a cleaner implementation w.r.t CONFIG_HOTPLUG_CPU. Add push_task_work_done flag to protect work buffer. Works only with FAIR class. Signed-off-by: Shrikanth Hegde --- v3->v4: - Drop irqsave - Add guard for rq - Drop RT support kernel/sched/core.c | 81 ++++++++++++++++++++++++++++++++++++++++++++ kernel/sched/sched.h | 8 +++++ 2 files changed, 89 insertions(+) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 390a4de28b3c..4b835cf2464a 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -5793,6 +5793,9 @@ void sched_tick(void) unsigned long hw_pressure; u64 resched_latency; + if (!cpu_preferred(cpu)) + sched_push_current_non_preferred_cpu(rq); + if (housekeeping_cpu(cpu, HK_TYPE_KERNEL_NOISE)) arch_scale_freq_tick(); @@ -11302,3 +11305,81 @@ void sched_change_end(struct sched_change_ctx *ctx) p->sched_class->prio_changed(rq, p, ctx->prio); } } + +#ifdef CONFIG_PREFERRED_CPU +/* npc - non preferred CPU */ +static DEFINE_PER_CPU(struct cpu_stop_work, npc_push_task_work); + +static int sched_non_preferred_cpu_push_stop(void *arg) +{ + struct task_struct *p = arg; + struct rq *rq = this_rq(); + struct rq_flags rf; + int cpu; + + /* sanity check */ + if (cpu_preferred(rq->cpu)) + return 0; + + raw_spin_lock_irq(&p->pi_lock); + rq_lock(rq, &rf); + rq->push_task_work_done = 0; + + update_rq_clock(rq); + + if (task_rq(p) == rq && task_on_rq_queued(p)) { + cpu = select_fallback_rq(rq->cpu, p); + rq = __migrate_task(rq, &rf, p, cpu); + } + + rq_unlock(rq, &rf); + raw_spin_unlock_irq(&p->pi_lock); + put_task_struct(p); + + return 0; +} + +/* + * Push the current task running on non-preferred CPU. + * Using this non preferred CPU will lead to more vCPU preemptions + * in the host. So it is better not to use this CPU. + * + * Since task is running, call a stopper to push the task out. This is + * similar to how task moves during hotplug. In select_fallback_rq a + * preferred CPU will be chosen and henceforth task shouldn't come back to + * this CPU again. + * + * Works for FAIR class only + * + * If task is affined only non-preferred CPUs, it can't be moved out + */ +void sched_push_current_non_preferred_cpu(struct rq *rq) +{ + struct task_struct *push_task = rq->curr; + + /* Push only if it is FAIR class */ + if (push_task->sched_class != &fair_sched_class) + return; + + if (kthread_is_per_cpu(push_task) || + is_migration_disabled(push_task)) + return; + + /* Is there any preferred CPU in the affinity list */ + if (!task_has_preferred_cpus(push_task)) + return; + + /* There is already a stopper thread for this. Dont race with it */ + if (rq->push_task_work_done == 1) + return; + + /* sched_tick runs with interrupts disabled. Don't disable again */ + get_task_struct(push_task); + + scoped_guard (rq_lock, rq) + rq->push_task_work_done = 1; + + stop_one_cpu_nowait(rq->cpu, sched_non_preferred_cpu_push_stop, + push_task, this_cpu_ptr(&npc_push_task_work)); +} +#endif diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index f194a5007e3a..5e9b8aaf9a9a 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -1274,6 +1274,8 @@ struct rq { struct list_head cfs_tasks; + bool push_task_work_done; + struct sched_avg avg_rt; struct sched_avg avg_dl; #ifdef CONFIG_HAVE_SCHED_AVG_IRQ @@ -4234,4 +4236,10 @@ static inline bool task_has_preferred_cpus(struct task_struct *p) else return cpumask_intersects(p->cpus_ptr, cpu_preferred_mask); } + +#ifdef CONFIG_PREFERRED_CPU +void sched_push_current_non_preferred_cpu(struct rq *rq); +#else /* !CONFIG_PREFERRED_CPU */ +static inline void sched_push_current_non_preferred_cpu(struct rq *rq) { } +#endif #endif /* _KERNEL_SCHED_SCHED_H */ -- 2.47.3