From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f172.google.com (mail-dy1-f172.google.com [74.125.82.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 694633D4116 for ; Wed, 17 Jun 2026 21:07:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781730470; cv=none; b=bfqvGtNNBozHNvhEhd19JCv87qNuY0fVckUoKcBe3Y/pwo0qJ/kgDmYQvKZVOrpFE78BmCTa6qQ1KenfXoBG1m4flvaT1dB4ABFLxEWhJquoPouCTx1h47xf5wCz6D3qH8okfLe3SyHQ51eX6R/1dG4CqsB7Cz65gpEHWVm/nN4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781730470; c=relaxed/simple; bh=AQHGa7C+PsKFd92HBNOc4W0hXFzueGHdPwJA0P+13QQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=p5zmNe9gkKXiMrxlV5pNjyeQpkpwO4WhYCo/pi6YsSOjm9HSggkC4FjW48d0L3dws9nLh2bwXdrhP5pacWBggTcgEAlfDSG5+klGRLJbBVyWEwYoWBv7ra1S3l5Rfrbho8Z9c7AlOUtNvWFjbZ1e8H4vvbNx1/IViI0L3YZHeTs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OCd1fMON; arc=none smtp.client-ip=74.125.82.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OCd1fMON" Received: by mail-dy1-f172.google.com with SMTP id 5a478bee46e88-30bbe98c3f0so815056eec.0 for ; Wed, 17 Jun 2026 14:07:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781730468; x=1782335268; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=NYPxVmfK+JFkSo6OAzJGIDU9L0WOJKUthcrwdrPYEZw=; b=OCd1fMONKgkIsNqh0lGZs6O4FDrjQhSzQwHrV3SxGiHqijQ1ZhDEEGBho/yDNXRkT+ OLhtf7MjSnMOHUUqfIJt39ZF3ZtBGqDYv68r92veeIFQqCifg6r3M1/kHv847+aqmEbl sU85H6EduLOb0QgMVQsnwJ4vPwY6Bn/IDIWk1dPgT6Dlf+XRRf+soHJCgf8AAR7npw7w btyPdf73NVitiFto25mhComM5+P4T3SUWfYl89WBNZJr17jSeU3xC3Ni3AY0FW8rvfgM Q1/CiFkiBvXBTrmX3bCcRVjFhmk6esfJRGGFB0PmwoKxcpj0m0oJ3tKS0F3MtD6eIYqD PUgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781730468; x=1782335268; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NYPxVmfK+JFkSo6OAzJGIDU9L0WOJKUthcrwdrPYEZw=; b=LwGv9FsvWTYfdbkUtb6SWUej00aI/RKh+0waoBOLyDFp742WONrIqzZdNxKpuFdLZg fFMAvzrH8Wx2DLYzV7PRue/8hu+g7HZJulBoS06hrgVxxYE/nSnptnM3XjBrCmpupXx6 a8lSF7rXp0LhRGqyd0zzyjaCjXZOiuFJ1j300ivmNPe46WuYCc6l7lGG+LkXVDEuA7Lk d55VNR4TSa65QHtA5Uo8pyll1qsitOO7ODro/fmgyEyoISuJDb/hkPg1bJ8xrfa5S17a s18AGTGryHfcYHgTKNpewJdJfGDZcmogF5vmpBEAzTlhUv8Wa7drbuIWGM+hSZ0sVBzo l1tw== X-Forwarded-Encrypted: i=1; AFNElJ/14fCKE5MbS1leuRYIlRHByYqnnACUFpnQXxMLNZ3UTZwacmkVFFdL+2wwJm6I/XuUHNcCx+D1Lti8PRA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9heE6XnvbiYL2atLfj0QHrsfCaLyqs5UbOiBUifSlhfnORUu0 XmkDQBUad9VJhpeJLhgHh36+LpKrZ1NGeJP6x4OiZ6v1YcRqRQbclCzh X-Gm-Gg: AfdE7cnxl/JBxDIzVsLIXxVdYWGPs52O17a0bHA1vKxa+CSNeH+7J1E5sLL+YlXk7r9 4I5DqRJTh+0qTPFtlhYORpi0gUj2QX68irU06HcbCGsIzZgP1nyjDS+8Ed8zPrnSwRbtgRjYERC EDuhzXrPZl+nbH3cypSo5idFhdKRGoUJVCRT3kIC1CFEn8DP52XojYEMOkRiZ3qoceMFZ7nkqBN 03+xQVg808Pt5a+DUOQh3/M8W8UcP6YwRqieiZxk4VHoRj73GxtRekZ+1hKa04ZBT/fsyuCkc2s /dQSG+iwLL1KJ6JQ8oeH9ThJjNFFc1SulTX3VBlfO/tq4CsjXT5YoGAhIIEKAUfy5zz8rz6V9Do h28dOuCwYTJk1fZD5wLuO2bqQM9k3+RzdOkVAwbPzEvOUFppVDROGTOOjV+W+7xsK5QG94kD7rc 3DFA2ToQ== X-Received: by 2002:a05:7301:1985:b0:307:2e1c:17f1 with SMTP id 5a478bee46e88-30bca0cebb2mr3003624eec.25.1781730468297; Wed, 17 Jun 2026 14:07:48 -0700 (PDT) Received: from qchaos ([186.143.206.197]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081e48e412sm26051224eec.4.2026.06.17.14.07.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 14:07:47 -0700 (PDT) From: "Pablo D. Bergamasco" To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, danpablo@gmail.com Subject: [QUESTION] staging: octeon: is the FIXME in cvm_oct_sgmii_init stale? Date: Wed, 17 Jun 2026 18:07:43 -0300 Message-ID: <20260617210743.1825733-1-danpablo@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Greg, While looking at drivers/staging/octeon/ethernet-sgmii.c I noticed a FIXME comment in cvm_oct_sgmii_init(): cvm_oct_common_init(dev); /* FIXME: Need autoneg logic */ return 0; After tracing the code, I believe autoneg is already handled when the interface is opened: cvm_oct_sgmii_open() -> cvm_oct_common_open() -> cvm_oct_phy_setup_device() -> phy_start() -> phy_state_machine() -> _phy_start_aneg() -> genphy_config_aneg() Is my analysis correct? If so, should I send a patch to remove the stale FIXME comment? Thanks, Pablo D. Bergamasco