All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Gabriel Krisman Bertazi <krisman@suse.de>
Cc: stable@vger.kernel.org, io-uring@vger.kernel.org,
	Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH stable-6.18.y] io_uring/net: Avoid msghdr on op_connect/op_bind async data
Date: Thu, 18 Jun 2026 00:31:39 +0530	[thread overview]
Message-ID: <2026061804-slab-agent-a134@gregkh> (raw)
In-Reply-To: <87zf0tdn7r.fsf@mailhost.krisman.be>

On Wed, Jun 17, 2026 at 02:40:56PM -0400, Gabriel Krisman Bertazi wrote:
> Greg KH <gregkh@linuxfoundation.org> writes:
> 
> > On Wed, Jun 17, 2026 at 01:51:02PM -0400, Gabriel Krisman Bertazi wrote:
> >> [ Upstream commit 3979840cd858f30f43ea9f4e7f7f1f56de82d698 ]
> >> This fixes a memory leak due to the lack of the cleanup hook for the
> >> iovec.  The stable backport differs from upstream by dropping the
> >> io_connect_bpf_populate hunk, which didn't exist at the time and by
> >> fixing the merge conflict due to the introduction of
> >> io_bind_file_create.
> >> 
> >> Both IORING_OP_CONNECT and IORING_OP_BIND reuse the msghdr object just
> >> to store the sockaddr. Beyond allocating a much larger object than
> >> needed, msghdr can also wrap an iovec, which will be recycled
> >> unnecessarily. This uses the sockaddr directly.
> >> 
> >> Cc: stable@vger.kernel.org
> >> Signed-off-by: Gabriel Krisman Bertazi <krisman@suse.de>
> >> Link: https://patch.msgid.link/20260602215327.1885109-2-krisman@suse.de
> >> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> >> Signed-off-by: Gabriel Krisman Bertazi <krisman@suse.de>
> >> ---
> >>  io_uring/net.c   | 36 ++++++++++++++++++------------------
> >>  io_uring/opdef.c |  4 ++--
> >>  2 files changed, 20 insertions(+), 20 deletions(-)
> >
> > This isn't in any release yet?
> 
> It is queued in Linus tree during the current merge window for 7.2

Ah, so it's not even in a released -rc yet.

> >  why just 6.18?
> 
> The backports are slightly different, so they were sent separately. The bug
> exists since 6.12.

I missed seeing a backport for 7.0, shouldn't it also go there?

thanks,

greg k-h

      parent reply	other threads:[~2026-06-17 19:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-17 17:51 [PATCH stable-6.18.y] io_uring/net: Avoid msghdr on op_connect/op_bind async data Gabriel Krisman Bertazi
2026-06-17 18:07 ` Greg KH
2026-06-17 18:40   ` Gabriel Krisman Bertazi
2026-06-17 18:45     ` Gabriel Krisman Bertazi
2026-06-17 19:02       ` Greg KH
2026-06-17 19:27         ` [PATCH stable-7.0.y] " Gabriel Krisman Bertazi
2026-06-17 19:01     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026061804-slab-agent-a134@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    --cc=krisman@suse.de \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.