From: Francesco Dolcini <francesco@dolcini.it>
To: joy.zou@oss.nxp.com
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Frank Li <Frank.Li@nxp.com>,
Ye Li <ye.li@nxp.com>, Jacky Bai <ping.bai@nxp.com>,
Peng Fan <peng.fan@nxp.com>, Joy Zou <joy.zou@nxp.com>,
imx@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] regulator: pf0900: Modify volatile register range definition
Date: Thu, 18 Jun 2026 08:54:29 +0200 [thread overview]
Message-ID: <20260618065429.GA18945@francesco-nb> (raw)
In-Reply-To: <20260618-b4-regulator-opt-v1-2-c43b1f62aaf6@oss.nxp.com>
Hello Joy,
thanks for the patch
On Thu, Jun 18, 2026 at 10:03:06AM +0800, joy.zou@oss.nxp.com wrote:
> From: Joy Zou <joy.zou@nxp.com>
>
> The pf0900_range was incorrectly defined as a single continuous range
> from PF0900_REG_DEV_ID to PF0900_REG_SYS_DIAG, which includes many
> non-volatile registers. This could lead to unnecessary I2C/SPI reads
> and potential performance issues.
>
> Ensures only volatile registers are read from the device
> on each access, while other registers can be cached by regmap.
>
> Fixes: 162e23657e53 ("regulator: pf0900: Add PMIC PF0900 support")
>
> Signed-off-by: Joy Zou <joy.zou@nxp.com>
No empty lines in-between tags. Remove the newline after Fixes:
Francesco
prev parent reply other threads:[~2026-06-18 6:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 2:03 [PATCH 0/2] regulator code improvements joy.zou
2026-06-18 2:03 ` [PATCH 1/2] regulator: pca9450: Correct default t_off_deb for PCA9451A/PCA9452 joy.zou
2026-06-18 3:07 ` Frank Li
2026-06-18 2:03 ` [PATCH 2/2] regulator: pf0900: Modify volatile register range definition joy.zou
2026-06-18 2:06 ` sashiko-bot
2026-06-18 6:54 ` Francesco Dolcini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260618065429.GA18945@francesco-nb \
--to=francesco@dolcini.it \
--cc=Frank.Li@nxp.com \
--cc=broonie@kernel.org \
--cc=imx@lists.linux.dev \
--cc=joy.zou@nxp.com \
--cc=joy.zou@oss.nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=ping.bai@nxp.com \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.