From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C39DCD98F2 for ; Thu, 18 Jun 2026 07:20:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7FDBA10F1A6; Thu, 18 Jun 2026 07:20:35 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="kZAjktbS"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id D143710F1A6 for ; Thu, 18 Jun 2026 07:20:34 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 9054842A3C for ; Thu, 18 Jun 2026 07:20:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20A481F000E9; Thu, 18 Jun 2026 07:20:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781767234; bh=As0/LnI6+OcaBsgMP7BjAXMFViZQzf0n7GoqXvf85vc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=kZAjktbSuXsFAOziR6q5OgbQNAz+l6OAWeWAhiA3bnRNJxiMKtTSm3vlevOVUPXHq /N750WW3zg5fPqnxPFwGysaEQkBsXTEbnNJnh2eGkaBsygZGhvYYT4OvIwivozM3Xr R72A+jeb/YU1bJL61RqNcbyQP8PA8RIGGV6jPQdfkUsgNawKqsot69kQ/jGObKkUFj JZ6G+n2AMTk+fd8Ory4dC65kODzv2bhrWCA3VQpwAKsK3Cu1FEYe/On2FM0w1izh+m +oLGUipZ7ViWIh+GqCYYsdgb1LWlJQe5F+xh1KEqxFrLeiJWgybc9zPhdiBropTkKk Uqy6PCnp9UxPQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH 11/11] ARM: dts: ux500: Remove DB8500 EPOD regulators To: "Linus Walleij" Cc: dmaengine@vger.kernel.org, robh@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, vkoul@kernel.org, Frank.Li@kernel.org, conor+dt@kernel.org In-Reply-To: <20260618-ux500-power-domains-v7-1-v1-11-eb5e50b1a588@kernel.org> References: <20260618-ux500-power-domains-v7-1-v1-0-eb5e50b1a588@kernel.org> <20260618-ux500-power-domains-v7-1-v1-11-eb5e50b1a588@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 18 Jun 2026 07:20:33 +0000 Message-Id: <20260618072034.20A481F000E9@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [Critical] Removing the EPOD regulator nodes and consumer supply properti= es breaks backwards compatibility with older kernels. - [Low] Removed EPOD regulators and `epod-supply` property are still marked= as required in their respective YAML binding schemas, causing `make dtbs_c= heck` to fail. -- commit cc40a973d5076813fb2d1de31c4ef7f4d0231e78 Author: Linus Walleij ARM: dts: ux500: Remove DB8500 EPOD regulators This commit deletes the obsolete DB8500 EPOD regulator nodes from the device tree. It retains only the VAPE and VSMPS2 compatibility regulators. > diff --git a/arch/arm/boot/dts/st/ste-dbx5x0.dtsi b/arch/arm/boot/dts/st/= ste-dbx5x0.dtsi > index fd6a075e4c93c..18727953a8630 100644 > --- a/arch/arm/boot/dts/st/ste-dbx5x0.dtsi > +++ b/arch/arm/boot/dts/st/ste-dbx5x0.dtsi > @@ -663,97 +663,17 @@ thermal: thermal@801573c0 { > #thermal-sensor-cells =3D <0>; > }; > =20 > - /* > - * TODO: Delete these bogus regulators and replace with power > - * domains. > - */ > db8500-prcmu-regulators { > compatible =3D "stericsson,db8500-prcmu-regulator"; [Severity: Low] Does this commit also need to update the YAML binding schemas?=20 It appears that Documentation/devicetree/bindings/mfd/stericsson,db8500-prc= mu.yaml still mandates the presence of deleted EPOD nodes (e.g., db8500_varm, db850= 0_sga)=20 in its required: block, which could cause dtbs_check to fail. [ ... ] > @@ -1215,8 +1127,6 @@ gpu@a0300000 { > clocks =3D <&prcmu_clk PRCMU_ACLK>, <&prcmu_clk PRCMU_SGACLK>; > clock-names =3D "bus", "core"; > power-domains =3D <&pm_domains DOMAIN_SGA>; > - /* TODO: delete and replace with power-domain handling */ > - mali-supply =3D <&db8500_sga_reg>; > }; [Severity: Critical] Does removing the mali-supply property and its target regulator break=20 backwards compatibility with older kernels?=20 Device trees are considered a stable ABI, and older kernels lacking the upd= ated ste-ux500-pm-domain driver might rely entirely on the legacy=20 db8500-prcmu-regulator driver to power these components.=20 By aggressively removing these regulators, older kernels might fall back to= dummy regulators and leave the physical hardware unpowered, leading to crashes wh= en drivers attempt to access unclocked and unpowered hardware registers. > =20 > mcde@a0350000 { > @@ -1224,8 +1134,6 @@ mcde@a0350000 { > reg =3D <0xa0350000 0x1000>; > interrupts =3D ; > power-domains =3D <&pm_domains DOMAIN_B2R2_MCDE>; > - /* TODO: delete and replace with power-domain handling */ > - epod-supply =3D <&db8500_b2r2_mcde_reg>; [Severity: Critical] Similar to the mali-supply removal above, does dropping the epod-supply=20 property break the display subsystem power management on older kernels that= =20 rely on it? [Severity: Low] Additionally, is epod-supply still required by the display subsystem bindin= g=20 schema? Documentation/devicetree/bindings/display/ste,mcde.yaml seems to st= ill=20 mandate epod-supply in its required: block. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260618-ux500-powe= r-domains-v7-1-v1-0-eb5e50b1a588@kernel.org?part=3D11