From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 088A33D813D for ; Thu, 18 Jun 2026 07:50:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781769022; cv=none; b=XliM85/VkuImkuiffOM55D0WdnyI+XDSOu/dudqe5GlLS1nDpVZ7kj8E2PDYlxSGZY7wjc2dTSxUUYAhWDZrsZMFPj0H/988agEc2FLHh/pJqd+x+grVglKJf95PXG8cu+CS9ipMCCiH/TQjux7jOKFjhJjqAXj/yHQnjCxryK4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781769022; c=relaxed/simple; bh=4VcO4tbL3Wl76GHBGPK3YhJER0zqoz1hA3peXtjMNFw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PLfknjkNpVG4b76cn1t9f/5S0jVzG+UfML2q9tKf3D2P2JhkT2qCm2StOu2+r7AO1cDa8MpcKyVrGx/0jiq+Kq+eSmdN4r/f6kbe5Ru/nc7dF+ioAKqtWD7TD8kO8CrvGDvpvV02SfEKRjwWVyOOdBYMtC8wXRoVHhNnpTlipOw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HWf3B/jQ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HWf3B/jQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781769020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EdzUYONYH0uLiBPvAlzV12zgQzsVl5igAxk2V09HO0w=; b=HWf3B/jQ/0YJGj75WtitznBGORT6LicwPmp23EZoVub3agZHMXvLjUr/FuI3UUuVORqJNd Xzo77dw8bu5YzI1aSeMMIXRiOcOV5bdfK0TEnZCRa9GvEb9yPNWw4kls88X+xTv2uZcCyV Sf6ZrRwvNHPbGKr1aL4sP9bThUUf8UY= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-471-VH6O75-OMEyDhlLBozidhA-1; Thu, 18 Jun 2026 03:50:16 -0400 X-MC-Unique: VH6O75-OMEyDhlLBozidhA-1 X-Mimecast-MFC-AGG-ID: VH6O75-OMEyDhlLBozidhA_1781769015 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 663081802679; Thu, 18 Jun 2026 07:50:15 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.44.50.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5CBE4180049F; Thu, 18 Jun 2026 07:50:13 +0000 (UTC) From: David Howells To: Christian Brauner Cc: David Howells , Marc Dionne , linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 16/17] afs: Fix missing NULL pointer check in afs_break_some_callbacks() Date: Thu, 18 Jun 2026 08:48:59 +0100 Message-ID: <20260618074903.2374756-17-dhowells@redhat.com> In-Reply-To: <20260618074903.2374756-1-dhowells@redhat.com> References: <20260618074903.2374756-1-dhowells@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Fix afs_break_some_callbacks() to check to see if afs_lookup_volume_rcu() returned NULL (e.g. the specified volume is unknown). Fixes: 8230fd8217b7 ("afs: Make callback processing more efficient.") Closes: https://sashiko.dev/#/patchset/20260609081738.770127-1-dhowells%40redhat.com Signed-off-by: David Howells cc: Marc Dionne cc: linux-afs@lists.infradead.org --- fs/afs/callback.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/afs/callback.c b/fs/afs/callback.c index 0035f51ce24a..03a66d7033ef 100644 --- a/fs/afs/callback.c +++ b/fs/afs/callback.c @@ -214,7 +214,9 @@ static void afs_break_some_callbacks(struct afs_server *server, rcu_read_lock(); volume = afs_lookup_volume_rcu(server->cell, vid); - if (cbb->fid.vnode == 0 && cbb->fid.unique == 0) { + if (!volume) { + /* Ignore breaks on unknown volumes. */ + } else if (cbb->fid.vnode == 0 && cbb->fid.unique == 0) { afs_break_volume_callback(server, volume); *_count -= 1; if (*_count)