All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Christian Brauner <christian@brauner.io>
Cc: David Howells <dhowells@redhat.com>,
	Marc Dionne <marc.dionne@auristor.com>,
	linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, Nan Li <tonanli66@gmail.com>,
	stable@kernel.org, Yuan Tan <yuantan098@gmail.com>,
	Yifan Wu <yifanwucs@gmail.com>,
	Juefei Pu <tomapufckgml@gmail.com>, Xin Liu <bird@lzu.edu.cn>,
	Ren Wei <n05ec@lzu.edu.cn>
Subject: [PATCH v2 01/17] afs: handle CB.InitCallBackState3 requests without a server record
Date: Thu, 18 Jun 2026 08:48:44 +0100	[thread overview]
Message-ID: <20260618074903.2374756-2-dhowells@redhat.com> (raw)
In-Reply-To: <20260618074903.2374756-1-dhowells@redhat.com>

From: Nan Li <tonanli66@gmail.com>

The cache manager callback path now attaches the server record to an
incoming call through the rxrpc peer's app data.  That association is
not guaranteed to exist for every callback request, and most callback
handlers already tolerate that case.

Make CB.InitCallBackState3 follow the same pattern by checking whether a
server record was attached before using it.  If the peer is not mapped
to a server record, trace the request and ignore it, matching the
existing behaviour for other unmatched callback requests.

This keeps the callback handler consistent with the rest of the cache
manager service and avoids depending on peer state that may not be
available for a given request.

Fixes: 40e8b52fe8c8 ("afs: Use the per-peer app data provided by rxrpc")
Cc: stable@kernel.org
Reported-by: Yuan Tan <yuantan098@gmail.com>
Reported-by: Yifan Wu <yifanwucs@gmail.com>
Reported-by: Juefei Pu <tomapufckgml@gmail.com>
Reported-by: Xin Liu <bird@lzu.edu.cn>
Signed-off-by: Nan Li <tonanli66@gmail.com>
Signed-off-by: Ren Wei <n05ec@lzu.edu.cn>
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
---
 fs/afs/cmservice.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/fs/afs/cmservice.c b/fs/afs/cmservice.c
index 5540ae1cad59..263c60c811a5 100644
--- a/fs/afs/cmservice.c
+++ b/fs/afs/cmservice.c
@@ -364,6 +364,11 @@ static int afs_deliver_cb_init_call_back_state3(struct afs_call *call)
 	if (!afs_check_call_state(call, AFS_CALL_SV_REPLYING))
 		return afs_io_error(call, afs_io_error_cm_reply);
 
+	if (!call->server) {
+		trace_afs_cm_no_server_u(call, call->request);
+		return 0;
+	}
+
 	if (memcmp(call->request, &call->server->_uuid, sizeof(call->server->_uuid)) != 0) {
 		pr_notice("Callback UUID does not match fileserver UUID\n");
 		trace_afs_cm_no_server_u(call, call->request);


  reply	other threads:[~2026-06-18  7:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-18  7:48 [PATCH v2 00/17] afs: Miscellaneous fixes David Howells
2026-06-18  7:48 ` David Howells [this message]
2026-06-18  7:48 ` [PATCH v2 02/17] afs: Fix error code in afs_extract_vl_addrs() David Howells
2026-06-18  7:48 ` [PATCH v2 03/17] afs: fix NULL pointer dereference in afs_get_tree() David Howells
2026-06-18  7:48 ` [PATCH v2 04/17] afs: Remove setting of AS_RELEASE_ALWAYS for symlinks and mountpoints David Howells
2026-06-18  7:48 ` [PATCH v2 05/17] afs: use kvfree() to free memory allocated by kvcalloc() David Howells
2026-06-18  7:48 ` [PATCH v2 06/17] afs: Remove erroneous seq |= 1 in volume lookup loop David Howells
2026-06-18  7:48 ` [PATCH v2 07/17] afs: check for duplicate servers in VL server list David Howells
2026-06-18  7:48 ` [PATCH v2 08/17] afs: Fix bulk lookup malfunction due to change in dir_emit() API David Howells
2026-06-18  7:48 ` [PATCH v2 09/17] afs: Fix misplaced inc of net->cells_outstanding David Howells
2026-06-18  7:48 ` [PATCH v2 10/17] afs: Fix reinitialisation of the inode, in particular ->lock_work David Howells
2026-06-18  7:48 ` [PATCH v2 11/17] afs: Fix callback service message parsers to pass through -EAGAIN David Howells
2026-06-18  7:48 ` [PATCH v2 12/17] afs: Fix double netfs initialisation in afs_root_iget() David Howells
2026-06-18  7:48 ` [PATCH v2 13/17] afs: Don't use AS_RELEASE_ALWAYS for dir/symlinks part 2 David Howells
2026-06-18  7:48 ` [PATCH v2 14/17] afs: Remove erroneous seq |= 1 in volume lookup loop David Howells
2026-06-18  8:25   ` Oleg Nesterov
2026-06-18 11:59     ` David Howells
2026-06-18  8:43   ` 答复: [????] " Li,Rongqing
2026-06-18  7:48 ` [PATCH v2 15/17] afs: Fix leak of ungot volume David Howells
2026-06-18  7:48 ` [PATCH v2 16/17] afs: Fix missing NULL pointer check in afs_break_some_callbacks() David Howells
2026-06-18  7:49 ` [PATCH v2 17/17] afs: Fix vllist leak David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260618074903.2374756-2-dhowells@redhat.com \
    --to=dhowells@redhat.com \
    --cc=bird@lzu.edu.cn \
    --cc=christian@brauner.io \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.dionne@auristor.com \
    --cc=n05ec@lzu.edu.cn \
    --cc=stable@kernel.org \
    --cc=tomapufckgml@gmail.com \
    --cc=tonanli66@gmail.com \
    --cc=yifanwucs@gmail.com \
    --cc=yuantan098@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.