From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52FD33E44FE for ; Thu, 18 Jun 2026 10:32:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781778728; cv=none; b=pUKd9OE0bBU6SC3Wfu+2IZK1qqWGWah4nCSdPIheimhX1r1EVEF87xOFjyFWtpX4UeGGklt4AOOHWjzDj5/ssE10rSGK3VYjN2aeGCQTh4pEEOAXnQNir/2E4xPMtcOraBunQovx2BBLRvG//LEB4blwSGAvdNN4B0dRDBdbSjs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781778728; c=relaxed/simple; bh=m6JrdCcwvYDdWdWhK6uH1Sd+R5tuJLKpQ5jhLNJ58Hw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZrX0xc7+XWa2XHvmmcPu6jmeL33mHnfILTohAMfz8wwU+i54sPK2PxXVf/MINbjQp7jhKLYVGTp2ocftQYY3tgLF0oTtw2tWQ4L0L4Yary5m3sfkPvNLLx4wXOi8DzuPHIKIpCDZsSpuBMeT/5eFlyu31P3Ep3rK4dlSONCn0wU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Q1seo4dZ; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Q1seo4dZ" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QRkM+HDJO7grYsJFfDBvpZiBW1fAnQmr2qPJBelM8z8=; b=Q1seo4dZIrzgftRd/7jr91aXBf /KuJVvpMOBEuGtFUx2X/B4rXw2ThGjJRWzQPNVCNQ+anKJ/FUO8/a87AbvuazkX38WYaaycs/QKJ7 0maR6a4RZdtVRn5/9m05hDjt2fNqcBtW2TKhMmCHByWsXbaxzjfmVf6duiNgjVQ2zsvmfCImDRko3 Jj6JNbCnOF3TGpkzG+tvJOPJVZT2WLD6X/aGa0sT7E7Pgmug+KgswsQGCFx1xeJlDL1+oGvSYMeZb cV3pCDxqOlVhYz+JHlV6gY7DiVUjqVT432IPpV0jCSl4qknR/WBzYon707YiiTSxkVf22CyrZa6dZ du3UccmQ==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1waA2K-0000000EIJR-2bwf; Thu, 18 Jun 2026 10:31:53 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id EA66C300578; Thu, 18 Jun 2026 12:31:51 +0200 (CEST) Date: Thu, 18 Jun 2026 12:31:51 +0200 From: Peter Zijlstra To: Xin Zhao Cc: aiqun.yu@oss.qualcomm.com, bsegall@google.com, dietmar.eggemann@arm.com, juri.lelli@redhat.com, kprateek.nayak@amd.com, linux-kernel@vger.kernel.org, mgorman@suse.de, mingo@redhat.com, pauld@redhat.com, rostedt@goodmis.org, vincent.guittot@linaro.org, vschneid@redhat.com Subject: Re: [PATCH v5 2/2] sched/fair: Simplify balance_interval reset logic in sched_balance_rq() Message-ID: <20260618103151.GO49951@noisy.programming.kicks-ass.net> References: <20260618094056.GN42921@noisy.programming.kicks-ass.net> <20260618101740.2753705-1-jackzxcui1989@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260618101740.2753705-1-jackzxcui1989@163.com> On Thu, Jun 18, 2026 at 06:17:40PM +0800, Xin Zhao wrote: > On Thu, 18 Jun 2026 11:40:56 +0200 Peter Zijlstra wrote: > > > This is very confusing, and my AI helper isn't helping much this time > > around. > > > > active_balance is initialized 0, it is only (but not always) set 1 when > > need_active_balance(). > > > > Therefore, the condition: !active_balance || need_active_balance() is a > > truism and can be removed. > > > > Or am I missing something more complicated? > > Sorry for my poor English again. No need to be; English isn't my native tongue either, although it is much closer linguistically. It just takes a little patience (and LLM help these days), but we'll get there. > I will change the commit log as below: No need, I shall edit, the patch itself looked fine.