From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: devel@lists.libvirt.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Christian Brauner" <brauner@kernel.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Dr. David Alan Gilbert" <dave@treblig.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@mailo.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH v3 19/35] monitor: use dynamic cast in monitor_is_hmp_non_interactive
Date: Thu, 18 Jun 2026 11:58:20 +0100 [thread overview]
Message-ID: <20260618105836.991609-20-berrange@redhat.com> (raw)
In-Reply-To: <20260618105836.991609-1-berrange@redhat.com>
Rather than checking !monitor_is_qmp(), use a dynamic cast to
check for HMP.
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
monitor/monitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/monitor/monitor.c b/monitor/monitor.c
index 0db7903795..15e49d78d7 100644
--- a/monitor/monitor.c
+++ b/monitor/monitor.c
@@ -168,7 +168,7 @@ static inline bool monitor_uses_readline(const MonitorHMP *mon)
static inline bool monitor_is_hmp_non_interactive(const Monitor *mon)
{
- if (monitor_is_qmp(mon)) {
+ if (!object_dynamic_cast(OBJECT(mon), TYPE_MONITOR_HMP)) {
return false;
}
--
2.54.0
next prev parent reply other threads:[~2026-06-18 11:02 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 10:58 [PATCH v3 00/35] monitor: turn QMP and HMP into QOM objects Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 01/35] qom: replace 'can_be_deleted' with 'prepare_delete' Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 02/35] monitor: replace 'common' with 'parent_obj' in MonitorHMP Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 03/35] monitor: replace 'common' with 'parent_obj' in MonitorQMP Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 04/35] monitor: rename monitor_init* to monitor_new* Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 05/35] monitor: minimal conversion of monitors to QOM Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 06/35] monitor: add 'chardev' property to Monitor base class Daniel P. Berrangé
2026-06-18 11:54 ` marcandre.lureau
2026-06-18 10:58 ` [PATCH v3 07/35] monitor: add 'readline' property to HMP Monitor class Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 08/35] monitor: add 'pretty' property to QMP " Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 09/35] monitor: remove 'skip_flush' field Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 10/35] monitor: move monitor_data_(init|destroy) into QOM init/finalize Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 11/35] monitor: use class methods for monitor_vprintf Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 12/35] monitor: use class methods for monitor_qapi_event_emit Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 13/35] monitor: use class methods for monitor_accept_input Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 14/35] monitor: use class method for I/O thread request Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 15/35] monitor: use dynamic cast in monitor_qmp_requests_pop_any_with_lock Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 16/35] util: use dynamic cast in error vreport Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 17/35] monitor: drop unused monitor_cur_is_qmp Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 18/35] monitor: use dynamic cast in QMP commands Daniel P. Berrangé
2026-06-18 10:58 ` Daniel P. Berrangé [this message]
2026-06-18 10:58 ` [PATCH v3 20/35] monitor: drop unused monitor_is_qmp method Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 21/35] monitor: eliminate monitor_is_hmp_non_interactive method Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 22/35] monitor: implement "user creatable" interface for adding monitors Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 23/35] monitor: convert from oneshot BH to persistent BH Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 24/35] monitor: reject attempts to delete the current monitor Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 25/35] monitor: protect qemu_chr_fe_accept_input with monitor lock Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 26/35] monitor: implement support for deleting QMP objects Daniel P. Berrangé
2026-06-18 11:54 ` marcandre.lureau
2026-06-18 10:58 ` [PATCH v3 27/35] tests/qtest: add tests for dynamic monitor add/remove Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 28/35] tests/functional: add e2e test for dynamic QMP monitor hotplug Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 29/35] tests/functional: add a stress test for monitor hot unplug Daniel P. Berrangé
2026-06-18 11:54 ` marcandre.lureau
2026-06-18 10:58 ` [PATCH v3 30/35] qom: add method for getting the "id" of a QOM object Daniel P. Berrangé
2026-06-18 11:54 ` marcandre.lureau
2026-06-18 10:58 ` [PATCH v3 31/35] qom: add trace events for user creatable create/delete APIs Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 32/35] monitor: add support for auto-deleting monitors upon close Daniel P. Berrangé
2026-06-18 11:54 ` marcandre.lureau
2026-06-18 10:58 ` [PATCH v3 33/35] tests: switch from -mon to -object monitor-qmp Daniel P. Berrangé
2026-06-18 10:58 ` [PATCH v3 34/35] qemu-options: document new monitor-hmp and monitor-qmp objects Daniel P. Berrangé
2026-06-18 11:54 ` marcandre.lureau
2026-06-18 10:58 ` [PATCH v3 35/35] docs: mark '-mon' as deprecated in favour of -object Daniel P. Berrangé
2026-06-18 11:54 ` marcandre.lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260618105836.991609-20-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=brauner@kernel.org \
--cc=dave@treblig.org \
--cc=devel@lists.libvirt.org \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@mailo.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.