From: sashiko-bot@kernel.org
To: "Dongdong Hao" <doubled@leap-io-kernel.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH v3 2/2] scsi: leapraid: Add driver documentation
Date: Thu, 18 Jun 2026 13:22:20 +0000 [thread overview]
Message-ID: <20260618132221.150FA1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <bab9637bf1646c6d0c5d82c22328f120e02cc4c6.1781767278.git.doubled@leap-io-kernel.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The documentation incorrectly names the module parameter for multipath support as `enable_mpio` instead of `enable_mp`.
--
commit 958c37a9e9c4054d4110e1b080f8c3be25877cb6
Author: Dongdong Hao <doubled@leap-io-kernel.com>
scsi: leapraid: Add driver documentation
This patch adds the necessary documentation for the LeapRAID SCSI driver
to the kernel's documentation tree.
> diff --git a/Documentation/scsi/leapraid.rst b/Documentation/scsi/leapraid.rst
> new file mode 100644
> index 0000000000000..e4a6a61c13f8e
> --- /dev/null
> +++ b/Documentation/scsi/leapraid.rst
[ ... ]
> +2. enable_mpio
> +--------------
> +
> +This parameter enables or disables multipath support for target devices.
[Severity: Medium]
Should this module parameter be documented as enable_mp instead of
enable_mpio?
If users attempt to configure multipath support using enable_mpio via the
kernel command line or modprobe config, they will encounter unknown
parameter errors.
> +When set to 1, multipath functionality is enabled (default), allowing
> +multiple paths to be established. Setting it to 0 disables multipath
> +handling.
> +
> +3. msix_disable
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1781767278.git.doubled@leap-io-kernel.com?part=2
prev parent reply other threads:[~2026-06-18 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 8:37 [PATCH v3 0/2] scsi: Add LeapRAID driver support Dongdong Hao
2026-06-18 8:37 ` [PATCH v3 1/2] scsi: leapraid: Add new SCSI driver Dongdong Hao
2026-06-18 8:37 ` [PATCH v3 2/2] scsi: leapraid: Add driver documentation Dongdong Hao
2026-06-18 13:22 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260618132221.150FA1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=doubled@leap-io-kernel.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.