From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE31D1DC985; Thu, 18 Jun 2026 16:27:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781800057; cv=none; b=dl4qQb529RsglhYlfv9gcfF+ac4FvZ3gEbJcC+zKcHwyFBJhNBfQgmadb8v3JQ/vx2lvTjCSeODjBwZ9XmJW9kNNW6DOOrzAiT9pTm040u5XKiEjZ8tEMuOgeZyfmqq2DFJPPeU+QIs5rdb3psarD2JxomJRdD4g3DY3MgHeQNY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781800057; c=relaxed/simple; bh=hDbhm1IAaZUIWZQchTNsmYp0wDA7JG5CsEgKLQo+WeY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bdMjX3C5QkFXU4QGruLjOp4cETku4SqPOdtqHa6Dqy6vx1rKoO/bWqA7UgoF/44RlXgBTM2GxLMpiFet7QifARnXq90rSBhb7eozGRh9KBCbXxn1wxT/SBcUVDSOX8lAAeNZPTlgKHhrhH22RuA1vWDL+9NA8OqAZ0Ab0F9UUcg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hlY5dcHw; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hlY5dcHw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 791F21F000E9; Thu, 18 Jun 2026 16:27:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781800056; bh=hDbhm1IAaZUIWZQchTNsmYp0wDA7JG5CsEgKLQo+WeY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=hlY5dcHwzatI7ydD9NMrwhkmZTZ8k+kfAPV9tGeXFV/z8BBmRyVNpuG4zGSHljfdm IyKJKrUQJYdtL8m5iMGbadW8uPda/Vo15zCBU7VCkEEFcdHxegtGfHzv9hcE+iblJa qrTiLW4NHH8JtBkRxZ3rePqQp3q7KueeiYNUXZu3GAQ3wX6yuz4pXp72s/2OdBeuFg zrZcTwLk9hkLVP60PZ+ydhf+EYQ/G39EHE34QTjZMg9uTlkH+ynyaC3bmPeW37w6oW qDLzgRJx7ik2gneVFDl+H6JkhbV+xNNWykK6sMWNKJ3lX7nu2act/vvbU0K5t7jEFS lR8kmwwLb4PMA== From: Sasha Levin To: Greg Kroah-Hartman , Harshit Mogalapalli Cc: Sasha Levin , stable@vger.kernel.org, patches@lists.linux.dev, Weiming Shi , Xiang Mei , Pablo Neira Ayuso , Vegard Nossum Subject: Re: [PATCH 6.12 100/261] netfilter: nf_log: validate MAC header was set before dumping it Date: Thu, 18 Jun 2026 12:27:33 -0400 Message-ID: <20260618134208.nf-log-mac-header-a84b6fedbc97@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <9d7e82ba-3f92-4ef4-bba9-c62c019252c9@oracle.com> References: <20260616145044.869532709@linuxfoundation.org> <20260616145049.667194632@linuxfoundation.org> <2026061823-film-pastrami-44cf@gregkh> <9d7e82ba-3f92-4ef4-bba9-c62c019252c9@oracle.com> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, Jun 18, 2026 at 05:08:46PM +0530, Harshit Mogalapalli wrote: >Now, this particular backport "[PATCH 6.12 100/261] netfilter: nf_log: >validate MAC header was set before dumping it" assumes that check is >already present. Not sure what's the best way to handle it. Drop this as >well and backport them separately along with the prerequisite: >62443dc21114 ("netfilter: require Ethernet MAC header before using >eth_hdr()") ? you're right that a84b6fedbc97 on its own only covers the fallback path and leaves the eth_hdr() consumers unguarded without the prereq. rather than dropping it, i'll queue 62443dc21114 ("netfilter: require Ethernet MAC header before using eth_hdr()") on top in all the affected versions (5.15, 6.1, 6.6, 6.12, 6.18, 7.0) so the gap is fully closed. thanks for catching it. -- Thanks, Sasha