From: SeongJae Park <sj@kernel.org>
To: sashiko-bot@kernel.org
Cc: SeongJae Park <sj@kernel.org>, damon@lists.linux.dev
Subject: Re: [RFC PATCH v1.2 09/11] mm/damon/sysfs: kobject_del() probe filter dirs
Date: Thu, 18 Jun 2026 17:23:09 -0700 [thread overview]
Message-ID: <20260619002309.8518-1-sj@kernel.org> (raw)
In-Reply-To: <20260618153451.1E7171F000E9@smtp.kernel.org>
On Thu, 18 Jun 2026 15:34:50 +0000 sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
>
> Pre-existing issues:
> - [Medium] Missing `kobject_del()` call in `damos_sysfs_region_add_dirs()` error path causes delayed sysfs directory removal and subsequent `-EEXIST` name conflicts.
> - [Medium] Missing `kobject_del()` in `damos_sysfs_probes_rm_dirs()` leaves child probe directories lingering in sysfs on error paths.
Both are wrong. Since users cannot arbitrarily add/remove probe dirs without
it's parent, and because the parent is patched too call kobject_del(), probe
directories don't need to be kobject_del()-ed.
Thanks,
SJ
[...]
next prev parent reply other threads:[~2026-06-19 0:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 15:15 [RFC PATCH v1.2 00/11] mm/damon/sysfs: kobject_del() directories that users can create/remove SeongJae Park
2026-06-18 15:15 ` [RFC PATCH v1.2 01/11] mm/damon/sysfs: kobject_del() target (normal), context and kdamond dirs SeongJae Park
2026-06-18 15:15 ` [RFC PATCH v1.2 02/11] mm/damon/sysfs: kobject_del() region and target (error) dirs SeongJae Park
2026-06-18 15:15 ` [RFC PATCH v1.2 03/11] mm/damon/sysfs-schemes: kobject_del() scheme dirs SeongJae Park
2026-06-18 15:15 ` [RFC PATCH v1.2 04/11] mm/damon/sysfs-schemes: kobject_del() scheme region dirs SeongJae Park
2026-06-18 15:15 ` [RFC PATCH v1.2 05/11] mm/damon/sysfs-schemes: kobject_del() scheme filter dirs SeongJae Park
2026-06-18 15:15 ` [RFC PATCH v1.2 06/11] mm/damon/sysfs-schemes: kobject_del() scheme quota goal dirs SeongJae Park
2026-06-18 15:15 ` [RFC PATCH v1.2 07/11] mm/damon/sysfs-schemes: kobject_del() scheme action destination dirs SeongJae Park
2026-06-18 15:15 ` [RFC PATCH v1.2 08/11] mm/damon/sysfs: kobject_del() probe dirs SeongJae Park
2026-06-18 15:15 ` [RFC PATCH v1.2 09/11] mm/damon/sysfs: kobject_del() probe filter dirs SeongJae Park
2026-06-18 15:34 ` sashiko-bot
2026-06-19 0:23 ` SeongJae Park [this message]
2026-06-18 15:15 ` [RFC PATCH v1.2 10/11] mm/damon/sysfs: kobject_del() probe dirs in probes_addd_dir error path SeongJae Park
2026-06-18 15:15 ` [RFC PATCH v1.2 11/11] mm/damon/sysfs-schemes: kobject_del() region for populate_region error SeongJae Park
2026-06-18 15:38 ` sashiko-bot
2026-06-19 0:26 ` SeongJae Park
2026-06-19 0:30 ` [RFC PATCH v1.2 00/11] mm/damon/sysfs: kobject_del() directories that users can create/remove SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260619002309.8518-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=damon@lists.linux.dev \
--cc=sashiko-bot@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.