Re: [PATCH RFC 1/3] dt-bindings: iio: adc: Add reference-source property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `reference-source` property lacks specification for the order of positive and negative reference sources when two items are provided.
--

commit 5840bfcda5df91dc955f660547ba3a189d50489a
Author: Kurt Borja <kuurtb@gmail.com>

dt-bindings: iio: adc: Add reference-source property

This commit adds a new reference-source property to the IIO ADC bindings 
to allow configuring the voltage reference source or sources for each channel.

> diff --git a/Documentation/devicetree/bindings/iio/adc/adc.yaml b/Documentation/devicetree/bindings/iio/adc/adc.yaml
> --- a/Documentation/devicetree/bindings/iio/adc/adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adc.yaml
> @@ -73,6 +73,16 @@ properties:
>        device design and can interact with other characteristics such as
>        settling time.
>  
> +  reference-source:
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    maxItems: 2
> +    minItems: 1
> +    description:
> +      Indicates the voltage reference source or sources for this channel.
> +
> +      This array describes either a single reference source or a positive and
> +      negative reference sources.

[Severity: Medium]
When two items are provided, how do we know which index corresponds to the
positive source and which to the negative source?

Without defining the order explicitly (for example, whether the first value
is positive and the second is negative), could this ambiguity lead to
inconsistent interpretations across different drivers and device trees?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260618-new-channel-props-v1-0-963c1b5cf40a@gmail.com?part=1