All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ackerley Tng via B4 Relay" <devnull+ackerleytng.google.com@kernel.org>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH v8 19/46] KVM: guest_memfd: Use actual size for invalidation in kvm_gmem_release()
Date: Fri, 19 Jun 2026 00:49:19 +0000	[thread overview]
Message-ID: <20260619004919.852921F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260618-gmem-inplace-conversion-v8-19-9d2959357853@google.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message incorrectly references `__kvm_gmem_invalidate_begin()` instead of the actual function name `__kvm_gmem_invalidate_start()`.
--

commit 50ac1910099f66ea81813150ac7efe43b67fe2df
Author: Ackerley Tng <ackerleytng@google.com>

KVM: guest_memfd: Use actual size for invalidation in kvm_gmem_release()

This commit modifies kvm_gmem_release to calculate the actual size of the
guest_memfd inode. This size is then used as the end range for invalidating
SPTEs instead of relying on -1ul.

> __kvm_gmem_invalidate_begin() and __kvm_gmem_invalidate_end() actually do
> not specially handle -1ul. -1ul is used as a huge number, which legal
> indices do not exceed, and hence the invalidation works as expected.

[Severity: Low]
This isn't a bug, but should the commit message reference
__kvm_gmem_invalidate_start instead of __kvm_gmem_invalidate_begin? The
underlying function in the code appears to be named
__kvm_gmem_invalidate_start.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260618-gmem-inplace-conversion-v8-0-9d2959357853@google.com?part=19

  reply	other threads:[~2026-06-19  0:49 UTC|newest]

Thread overview: 126+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-19  0:31 [PATCH v8 00/46] guest_memfd: In-place conversion support Ackerley Tng
2026-06-19  0:31 ` Ackerley Tng via B4 Relay
2026-06-19  0:31 ` [PATCH v8 01/46] KVM: guest_memfd: Introduce per-gmem attributes, use to guard user mappings Ackerley Tng
2026-06-19  0:31   ` Ackerley Tng via B4 Relay
2026-06-19  0:31 ` [PATCH v8 02/46] KVM: Rename KVM_GENERIC_MEMORY_ATTRIBUTES to KVM_VM_MEMORY_ATTRIBUTES Ackerley Tng
2026-06-19  0:31   ` Ackerley Tng via B4 Relay
2026-06-19  0:31 ` [PATCH v8 03/46] KVM: Move KVM_VM_MEMORY_ATTRIBUTES config definition to x86 Ackerley Tng
2026-06-19  0:31   ` Ackerley Tng via B4 Relay
2026-06-19  0:31 ` [PATCH v8 04/46] KVM: Decouple kvm_has_arch_private_mem from CONFIG_KVM_VM_MEMORY_ATTRIBUTES Ackerley Tng
2026-06-19  0:31   ` Ackerley Tng via B4 Relay
2026-06-19  8:10   ` Fuad Tabba
2026-06-19  0:31 ` [PATCH v8 05/46] KVM: Make CONFIG_KVM_VM_MEMORY_ATTRIBUTES selectable Ackerley Tng
2026-06-19  0:31   ` Ackerley Tng via B4 Relay
2026-06-19  8:12   ` Fuad Tabba
2026-06-19 12:51   ` Julian Braha
2026-06-19  0:31 ` [PATCH v8 06/46] KVM: Enumerate support for PRIVATE memory iff kvm_arch_has_private_mem is defined Ackerley Tng
2026-06-19  0:31   ` Ackerley Tng via B4 Relay
2026-06-19  0:31 ` [PATCH v8 07/46] KVM: Rename memory attribute APIs to prepare for in-place gmem conversion Ackerley Tng
2026-06-19  0:31   ` Ackerley Tng via B4 Relay
2026-06-19  0:55   ` sashiko-bot
2026-06-19  8:17     ` Fuad Tabba
2026-06-19  8:16   ` Fuad Tabba
2026-06-19  0:31 ` [PATCH v8 08/46] KVM: Provide generic interface for checking memory private/shared status Ackerley Tng
2026-06-19  0:31   ` Ackerley Tng via B4 Relay
2026-06-19  0:51   ` sashiko-bot
2026-06-19  8:19   ` Fuad Tabba
2026-06-19  8:21     ` Fuad Tabba
2026-06-19  9:57       ` Suzuki K Poulose
2026-06-19  0:31 ` [PATCH v8 09/46] KVM: guest_memfd: Introduce function to check GFN " Ackerley Tng
2026-06-19  0:31   ` Ackerley Tng via B4 Relay
2026-06-19  0:49   ` sashiko-bot
2026-06-19  8:24     ` Fuad Tabba
2026-06-19  8:25   ` Fuad Tabba
2026-06-19  0:31 ` [PATCH v8 10/46] KVM: guest_memfd: Wire up core private/shared attribute interfaces Ackerley Tng
2026-06-19  0:31   ` Ackerley Tng via B4 Relay
2026-06-19  8:34   ` Fuad Tabba
2026-06-19  0:31 ` [PATCH v8 11/46] KVM: Consolidate private memory and guest_memfd ifdeffery in kvm_host.h Ackerley Tng
2026-06-19  0:31   ` Ackerley Tng via B4 Relay
2026-06-19 11:02   ` Fuad Tabba
2026-06-19  0:31 ` [PATCH v8 12/46] KVM: guest_memfd: Only prepare folios for private pages Ackerley Tng
2026-06-19  0:31   ` Ackerley Tng via B4 Relay
2026-06-19  0:31 ` [PATCH v8 13/46] KVM: guest_memfd: Add base support for KVM_SET_MEMORY_ATTRIBUTES2 Ackerley Tng
2026-06-19  0:31   ` Ackerley Tng via B4 Relay
2026-06-19  9:25   ` Fuad Tabba
2026-06-19  0:31 ` [PATCH v8 14/46] KVM: guest_memfd: Ensure pages are not in use before conversion Ackerley Tng
2026-06-19  0:31   ` Ackerley Tng via B4 Relay
2026-06-19  0:31 ` [PATCH v8 15/46] KVM: guest_memfd: Call arch invalidate hooks on conversion Ackerley Tng
2026-06-19  0:31   ` Ackerley Tng via B4 Relay
2026-06-19 10:09   ` Fuad Tabba
2026-06-19  0:31 ` [PATCH v8 16/46] KVM: guest_memfd: Return early if range already has requested attributes Ackerley Tng
2026-06-19  0:31   ` Ackerley Tng via B4 Relay
2026-06-19  0:31 ` [PATCH v8 17/46] KVM: guest_memfd: Advertise KVM_SET_MEMORY_ATTRIBUTES2 ioctl Ackerley Tng
2026-06-19  0:31   ` Ackerley Tng via B4 Relay
2026-06-19  0:53   ` sashiko-bot
2026-06-19 10:35     ` Fuad Tabba
2026-06-19 10:35   ` Fuad Tabba
2026-06-19  0:31 ` [PATCH v8 18/46] KVM: guest_memfd: Handle lru_add fbatch refcounts during conversion safety check Ackerley Tng
2026-06-19  0:31   ` Ackerley Tng via B4 Relay
2026-06-19  0:31 ` [PATCH v8 19/46] KVM: guest_memfd: Use actual size for invalidation in kvm_gmem_release() Ackerley Tng
2026-06-19  0:31   ` Ackerley Tng via B4 Relay
2026-06-19  0:49   ` sashiko-bot [this message]
2026-06-19 10:46   ` Fuad Tabba
2026-06-19  0:31 ` [PATCH v8 20/46] KVM: guest_memfd: Determine invalidation filter from memory attributes Ackerley Tng
2026-06-19  0:31   ` Ackerley Tng via B4 Relay
2026-06-19  0:31 ` [PATCH v8 21/46] KVM: guest_memfd: Zero page while getting pfn Ackerley Tng
2026-06-19  0:31   ` Ackerley Tng via B4 Relay
2026-06-19 10:51   ` Fuad Tabba
2026-06-19  0:31 ` [PATCH v8 22/46] KVM: SEV: Make 'uaddr' parameter optional for KVM_SEV_SNP_LAUNCH_UPDATE Ackerley Tng
2026-06-19  0:31   ` Ackerley Tng via B4 Relay
2026-06-19 11:01   ` Fuad Tabba
2026-06-19  0:32 ` [PATCH v8 23/46] KVM: TDX: Make source page optional for KVM_TDX_INIT_MEM_REGION Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19  0:58   ` sashiko-bot
2026-06-19 11:09   ` Fuad Tabba
2026-06-19  0:32 ` [PATCH v8 24/46] KVM: guest_memfd: Make in-place conversion the default Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19  0:58   ` sashiko-bot
2026-06-19  0:32 ` [PATCH v8 25/46] KVM: guest_memfd: Enable INIT_SHARED on guest_memfd for x86 Coco VMs Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19  0:32 ` [PATCH v8 26/46] KVM: selftests: Create gmem fd before "regular" fd when adding memslot Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19  0:32 ` [PATCH v8 27/46] KVM: selftests: Rename guest_memfd{,_offset} to gmem_{fd,offset} Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19  0:56   ` sashiko-bot
2026-06-19  0:32 ` [PATCH v8 28/46] KVM: selftests: Add support for mmap() on guest_memfd in core library Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19  0:32 ` [PATCH v8 29/46] KVM: selftests: Add selftests global for guest memory attributes capability Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19  0:32 ` [PATCH v8 30/46] KVM: selftests: Add helpers for calling ioctls on guest_memfd Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19  0:32 ` [PATCH v8 31/46] KVM: selftests: Test basic single-page conversion flow Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19  0:32 ` [PATCH v8 32/46] KVM: selftests: Test conversion flow when INIT_SHARED Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19  0:32 ` [PATCH v8 33/46] KVM: selftests: Test conversion precision in guest_memfd Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19  0:32 ` [PATCH v8 34/46] KVM: selftests: Test conversion before allocation Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19  0:32 ` [PATCH v8 35/46] KVM: selftests: Convert with allocated folios in different layouts Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19  0:32 ` [PATCH v8 36/46] KVM: selftests: Test that truncation does not change shared/private status Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19  0:32 ` [PATCH v8 37/46] KVM: selftests: Test that shared/private status is consistent across processes Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19  1:02   ` sashiko-bot
2026-06-19  0:32 ` [PATCH v8 38/46] KVM: selftests: Add helpers to pin pages with CONFIG_GUP_TEST Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19  3:02   ` sashiko-bot
2026-06-19  0:32 ` [PATCH v8 39/46] KVM: selftests: Test conversion with elevated page refcount Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19  1:07   ` sashiko-bot
2026-06-19  0:32 ` [PATCH v8 40/46] KVM: selftests: Reset shared memory after hole-punching Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19  0:32 ` [PATCH v8 41/46] KVM: selftests: Provide function to look up guest_memfd details from gpa Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19  0:32 ` [PATCH v8 42/46] KVM: selftests: Provide common function to set memory attributes Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19  0:32 ` [PATCH v8 43/46] KVM: selftests: Check fd/flags provided to mmap() when setting up memslot Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19  0:32 ` [PATCH v8 44/46] KVM: selftests: Make TEST_EXPECT_SIGBUS thread-safe Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19  0:32 ` [PATCH v8 45/46] KVM: selftests: Update private_mem_conversions_test to mmap() guest_memfd Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19  0:32 ` [PATCH v8 46/46] KVM: selftests: Update private memory exits test to work with per-gmem attributes Ackerley Tng
2026-06-19  0:32   ` Ackerley Tng via B4 Relay
2026-06-19 12:28 ` [PATCH v8 00/46] guest_memfd: In-place conversion support Garg, Shivank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260619004919.852921F00A3A@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=devnull+ackerleytng.google.com@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.