All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Onur Özkan" <work@onurozkan.dev>
To: Philipp Stanner <phasta@mailbox.org>
Cc: "Philipp Stanner" <phasta@kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Tamir Duberstein" <tamird@kernel.org>,
	"Alexandre Courbot" <acourbot@nvidia.com>,
	"Alexander Viro" <viro@zeniv.linux.org.uk>,
	"Christian Brauner" <brauner@kernel.org>,
	"Jan Kara" <jack@suse.cz>, "Lyude Paul" <lyude@redhat.com>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	"Frederic Weisbecker" <frederic@kernel.org>,
	"Neeraj Upadhyay" <neeraj.upadhyay@kernel.org>,
	"Joel Fernandes" <joelagnelf@nvidia.com>,
	"Josh Triplett" <josh@joshtriplett.org>,
	"Uladzislau Rezki" <urezki@gmail.com>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
	"Lai Jiangshan" <jiangshanlai@gmail.com>,
	Zqiang <qiang.zhang@linux.dev>,
	"Christian Schrefl" <chrisi.schrefl@gmail.com>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, rcu@vger.kernel.org
Subject: Re: [PATCH 3/3] rust: sync: Use safe synchronize_rcu() abstraction in poll
Date: Fri, 19 Jun 2026 10:18:08 +0300	[thread overview]
Message-ID: <20260619071809.12809-1-work@onurozkan.dev> (raw)
In-Reply-To: <c449f26e2283a2df6d5240879f85bee1b2fd4c50.camel@mailbox.org>

On Fri, 19 Jun 2026 08:55:44 +0200
Philipp Stanner <phasta@mailbox.org> wrote:

> On Thu, 2026-06-18 at 21:11 +0300, Onur Özkan wrote:
> > On Thu, 18 Jun 2026 11:59:52 +0200
> > Philipp Stanner <phasta@kernel.org> wrote:
> > 
> > > We now have a safe wrapper for the foreign function synchronize_rcu().
> > > 
> > > Use it in poll.rs.
> > > 
> > > Signed-off-by: Philipp Stanner <phasta@kernel.org>
> > > ---
> > >  rust/kernel/sync/poll.rs | 6 ++----
> > >  1 file changed, 2 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/rust/kernel/sync/poll.rs b/rust/kernel/sync/poll.rs
> > > index 0ec985d560c8..401cf4d3f35f 100644
> > > --- a/rust/kernel/sync/poll.rs
> > > +++ b/rust/kernel/sync/poll.rs
> > > @@ -8,7 +8,7 @@
> > >      bindings,
> > >      fs::File,
> > >      prelude::*,
> > > -    sync::{CondVar, LockClassKey},
> > > +    sync::{rcu::synchronize_rcu, CondVar, LockClassKey},
> > 
> > nit: Missing vertical import. Same in the other module as well.
> 
> Was already like that when I came here ;)
> 
> But if it helps I can format it while I'm at it..

Yeah there are still horizontal imports in certain modules and it's a perfect
opportunity to fix them if we already making changes on them.

- Onur

> 
> 
> P.

  reply	other threads:[~2026-06-19  7:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-18  9:59 [PATCH 0/3] Add and use abstraction for synchronize_rcu() Philipp Stanner
2026-06-18  9:59 ` [PATCH 1/3] rust: sync: Add " Philipp Stanner
2026-06-18 11:40   ` Philipp Stanner
2026-06-18 11:47     ` Alice Ryhl
2026-06-18 12:47       ` Philipp Stanner
2026-06-18 13:06         ` Alice Ryhl
2026-06-18  9:59 ` [PATCH 2/3] rust: revocable: Use safe synchronize_rcu() abstraction Philipp Stanner
2026-06-18  9:59 ` [PATCH 3/3] rust: sync: Use safe synchronize_rcu() abstraction in poll Philipp Stanner
2026-06-18 12:00   ` Alice Ryhl
2026-06-18 18:11   ` Onur Özkan
2026-06-19  6:55     ` Philipp Stanner
2026-06-19  7:18       ` Onur Özkan [this message]
2026-06-19  7:19       ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260619071809.12809-1-work@onurozkan.dev \
    --to=work@onurozkan.dev \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=brauner@kernel.org \
    --cc=chrisi.schrefl@gmail.com \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=frederic@kernel.org \
    --cc=gary@garyguo.net \
    --cc=jack@suse.cz \
    --cc=jiangshanlai@gmail.com \
    --cc=joelagnelf@nvidia.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=lyude@redhat.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=neeraj.upadhyay@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=paulmck@kernel.org \
    --cc=phasta@kernel.org \
    --cc=phasta@mailbox.org \
    --cc=qiang.zhang@linux.dev \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tamird@kernel.org \
    --cc=tmgross@umich.edu \
    --cc=urezki@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.