From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F024381B0A for ; Fri, 19 Jun 2026 12:15:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781871332; cv=none; b=hwNIGyFQljle31yfVvR7q7pu7BKCKAZyxuSA3QcnThSgHWtVVLjEc0B/xOc7ekyrf0Nh5v6wreGI7pC9L68AhJhGYN/yV+gRnLpEnyC9psD57XAX+8+VFFrMSJHSNnlGuvxo9eNxBPQB77tfHQZPXBZKgdfcagmTG2mFeeFRcc8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781871332; c=relaxed/simple; bh=v7V8Qk/v/uUBAB9tQ6cAgU4TL3hMiwFhRqAWMCCQ+3g=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sNRQe851ty5OH6FFl/kCvMP6hjsbheQfEnP88y1wxiLaFFX1zT3d8NsK1CMlyxmxYmE6gbGV1Fq3epY7n8NGnwRzAnN9rwkmBpJKz8VjQnBsrReLVejljVweU2ME9sUExzI68aA51NFjd2mMX+RF3h2KAqXc5EEVELdOGMwt2zE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf01.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 71243A037D; Fri, 19 Jun 2026 12:15:20 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: rostedt@goodmis.org) by omf01.hostedemail.com (Postfix) with ESMTPA id 8D8BE60018; Fri, 19 Jun 2026 12:15:15 +0000 (UTC) Date: Fri, 19 Jun 2026 08:15:13 -0400 From: Steven Rostedt To: Linus Torvalds Cc: Yury Norov , LKML , Masami Hiramatsu , Mathieu Desnoyers , Ao Sun , David Carlier , Karl Mehltretter , Martin Kaiser , Pengpeng Hou , Qian-Yu Lin , Rik van Riel , Rosen Penev , Shuvam Pandey , Vineeth Pillai , Yash Suthar , Yu Peng Subject: Re: [GIT PULL] tracing: Updates for 7.2 Message-ID: <20260619081513.3e4a1fb0@fedora> In-Reply-To: References: <20260616180122.57a3b426@fedora> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspamout02 X-Rspamd-Queue-Id: 8D8BE60018 X-Stat-Signature: d9side4euqqigb4gsr3qpmrsr5zompd3 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1/JX0eSfDcJKdV9lEE9YCEjCdo03g/80mI= X-HE-Tag: 1781871315-604298 X-HE-Meta: U2FsdGVkX19+Z8YqV0UFuT3ZCCywNThWBbJPv0lSn7DOGJUH0/dy+I1l7xkpSmXHSikymAjXCufn0zSfSlAKEptL4TEZggY5z36Axy7knCyxIIOFf46XfMLp49sWhfKYKKi84GCflabdul6zm+5hB0CfylO0LO6B3jymFjOWMhf3P/VrJFhF0UonuF8edKZMWSC9lHKrYioW5FLeUEQtZox7WNlJ1P6aQ5vWD1ar45kKM3rXG2QO8nwR1fIFpfm/Fk2iStfb1//mc8cPaT74cMnNQKA3OqYn8Qtm02+MwkHR0JKrQOm1M0C5ig82toZPceUWdfAinSmpPhpn2r5+/EFXme2eLsR4Xicmsuv3UCPnUvWOp+8DNJwue82uDQHc On Thu, 18 Jun 2026 21:23:04 -0700 Linus Torvalds wrote: > The intent was clearly to make people who actually needed the > trace_printk() functionality to include the header - that's what the > commit log says. But that's not how any of it works ;( > > So all that commit did was to make things look like they wouldn't hurt > as much as they do, and that trivial change to that file causes a full > rebuild of the kernel. > > I'm not seeing any patches even being discussed that would make only > files that need it to include that file and remove it from > linux/kernel.h that *everybody* uses. Yet that was the *only* point of > making it a separate header in the first place. Yury? Many developers use trace_printk() over printk(). Requiring people to add that include for every use case would severely limit debugging of the kernel. Would you be OK if we did the same for printk? That is, if you want to add a printk to a function, you had to add a include printk.h to the file before doing so? -- Steve