Re: [PATCH v8 23/25] PCI/sysfs: Convert legacy I/O and memory attributes to static definitions

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unused fields `legacy_io` and `legacy_mem` in `struct pci_bus`.
--

commit 7da0447cc07dd2c8c43599562ff0122344fb1754
Author: Krzysztof Wilczyński <kwilczynski@kernel.org>

PCI/sysfs: Convert legacy I/O and memory attributes to static definitions

This commit converts legacy_io and legacy_mem sysfs attributes from dynamic
allocation to static definitions. It leverages static attribute groups and
is_bin_visible() callbacks to handle sysfs creation and removal automatically.

> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> index 7f1d8e07924f5..dfb4e06677fce 100644
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
[ ... ]
> -void pci_create_legacy_files(struct pci_bus *b)
> -{
> -	int error;
> -
> -	if (!sysfs_initialized)
> -		return;
> -
> -	b->legacy_io = kzalloc_objs(struct bin_attribute, 2, GFP_ATOMIC);

[Severity: Low]
Since this patch removes the dynamic allocation and assignments to
b->legacy_io and b->legacy_mem, are these fields in struct pci_bus
(defined in include/linux/pci.h) now completely unused?

If they are dead code, should they also be removed from struct pci_bus
to reduce the size of the structure?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260619085200.3729431-1-kwilczynski@kernel.org?part=23