From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Caio <caio.groff@usp.br>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: light: tsl2591: replace persist switch statements with lookup table
Date: Fri, 19 Jun 2026 09:31:29 +0200 [thread overview]
Message-ID: <20260619093129.00003800@gmail.com> (raw)
In-Reply-To: <20260617164258.9007-1-caio.groff@usp.br>
On Wed, 17 Jun 2026 13:42:58 -0300
Caio <caio.groff@usp.br> wrote:
> tsl2591_persist_cycle_to_lit() and tsl2591_persist_lit_to_cycle() are
> inverse mappings of the same 15-entry table, duplicating the same
> pairs across two switch statements. Replace both with a shared
> tsl2591_persist_table[] array and simple linear searches, eliminating
> the duplication.
>
> Signed-off-by: Caio <caio.groff@usp.br>
> ---
Alongside David's comment, you're missing your full name in the
Signed-off-by tag.
--
Kind regards
CJD
next prev parent reply other threads:[~2026-06-19 7:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 16:42 [PATCH] iio: light: tsl2591: replace persist switch statements with lookup table Caio
2026-06-17 17:01 ` David Lechner
2026-06-19 7:31 ` Joshua Crofts [this message]
2026-06-19 9:12 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260619093129.00003800@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=andy@kernel.org \
--cc=caio.groff@usp.br \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.