From: Mohammadfaiz Bawa <mbawa@redhat.com>
To: "Stefan Berger" <stefanb@linux.vnet.ibm.com>,
"Philippe Mathieu-Daudé" <philmd@mailo.com>,
qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>
Cc: Zhao Liu <zhao1.liu@intel.com>
Subject: [PATCH v3 0/3] hw/tpm: fix tpm-tis-device backward migration on aarch64
Date: Fri, 19 Jun 2026 15:01:37 +0530 [thread overview]
Message-ID: <20260619093140.832136-1-mbawa@redhat.com> (raw)
46cd2c1050f0 ("hw/tpm: add PPI support to tpm-tis-device for ARM64
virt") unconditionally registers a "tpm-ppi" RAMBlock when the TPM
TIS sysbus device is realized. This breaks backward migration: a
QEMU with PPI support cannot migrate to an older QEMU without it:
Unknown ramblock "tpm-ppi", cannot accept migration
The failure is 100% reproducible on any aarch64 guest that uses
tpm-tis-device when migrating to a host whose QEMU predates the PPI
commit.
Fix by gating the PPI memory region behind a new "ppi" device
property, and disabling it via hw_compat_11_0[] for machine types
<= virt-11.0. Also move the sysbus_init_mmio() calls from
instance_init to realizefn so the memory regions are properly
initialized before being registered (Peter).
Not exposing the 2nd MMIO slot when ppi=off triggers a NULL
dereference in platform_bus_get_mmio_addr(), so patch 1 adds a
guard first.
Changes in v3:
- Reordered: platform-bus NULL guard is now patch 1 (Peter)
Changes in v2:
- Dropped zero-size memory region hack (Peter)
- Moved sysbus_init_mmio() from initfn to realizefn (Peter)
- Only expose PPI MMIO region when ppi=on (Peter)
- Added NULL guard in platform_bus_get_mmio_addr() (found via testing)
- v1: https://lore.kernel.org/qemu-devel/20260618123317.633869-1-mbawa@redhat.com
- v2: https://lore.kernel.org/qemu-devel/20260619053623.756021-1-mbawa@redhat.com
Signed-off-by: Mohammadfaiz Bawa <mbawa@redhat.com>
Mohammadfaiz Bawa (3):
hw/core/platform-bus: guard platform_bus_get_mmio_addr() against NULL
hw/tpm: gate PPI support on tpm-tis-device behind a device property
hw/core/machine: disable tpm-tis-device PPI for machine type <= 11.0
hw/core/machine.c | 1 +
hw/core/platform-bus.c | 3 +--
hw/tpm/tpm_tis.h | 1 +
hw/tpm/tpm_tis_sysbus.c | 18 +++++++++++-------
4 files changed, 14 insertions(+), 9 deletions(-)
--
2.54.0
next reply other threads:[~2026-06-19 9:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-19 9:31 Mohammadfaiz Bawa [this message]
2026-06-19 9:31 ` [PATCH v3 1/3] hw/core/platform-bus: guard platform_bus_get_mmio_addr() against NULL Mohammadfaiz Bawa
2026-06-19 9:31 ` [PATCH v3 2/3] hw/tpm: gate PPI support on tpm-tis-device behind a device property Mohammadfaiz Bawa
2026-07-07 15:01 ` Stefan Berger
2026-06-19 9:31 ` [PATCH v3 3/3] hw/core/machine: disable tpm-tis-device PPI for machine type <= 11.0 Mohammadfaiz Bawa
2026-07-07 15:02 ` Stefan Berger
2026-06-29 4:53 ` [PATCH v3 0/3] hw/tpm: fix tpm-tis-device backward migration on aarch64 Mohammadfaiz Bawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260619093140.832136-1-mbawa@redhat.com \
--to=mbawa@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@mailo.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.