Re: [PATCH v4] dt-bindings: misc: convert lis302.txt to YAML

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The YAML binding erroneously forbids `Vdd-supply` and `Vdd_IO-supply` for the SPI variant by setting them to `false`.
--

commit 286d4c20f34dbb3740102063ad8a21275e5828b2
Author: Jad Keskes <inasj268@gmail.com>
dt-bindings: misc: convert lis302.txt to YAML

This commit converts the old LIS302 accelerometer plain text binding into a
YAML schema. It covers both I2C and SPI variants and retains deprecated
property names for backwards compatibility.

> diff --git a/Documentation/devicetree/bindings/misc/st,lis3lv02d.yaml b/Documentation/devicetree/bindings/misc/st,lis3lv02d.yaml
> new file mode 100644
> index 0000000000000..c73371b754a1e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/st,lis3lv02d.yaml

[ ... ]

> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          not:
> +            contains:
> +              const: st,lis302dl-spi
> +    then:
> +      required:
> +        - Vdd-supply
> +        - Vdd_IO-supply
> +    else:
> +      properties:
> +        Vdd-supply: false
> +        Vdd_IO-supply: false

[Severity: Medium]
Does forbidding these power supplies for the SPI variant prevent accurate
hardware description?

The hardware physically requires Vdd and Vdd_IO power supplies to function,
regardless of whether it is accessed via I2C or SPI. Setting these
properties to false in the else branch explicitly forbids device tree
writers from modeling the physical regulators powering the SPI device,
which will cause valid hardware descriptions to fail dtbs_check schema
validation.

> +      required:
> +        - spi-max-frequency
> +        - interrupts

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260619124426.882626-1-inasj268@gmail.com?part=1