Re: [RFC PATCH net-next v8 09/12] net: phylink: add .pcs_link_down PCS OP

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Copy-paste error in the kernel-doc comment for the newly added `pcs_link_down` function incorrectly names it `pcs_link_up`.
--

commit 2d1df5800af742cd81f1378ff1f3f3bc3801c928
Author: Christian Marangi <ansuelsmth@gmail.com>

net: phylink: add .pcs_link_down PCS OP

Permits a PCS driver to define a specific operation to tear down the link
between the MAC and the PCS. Adds a new .pcs_link_down callback which is
called after .mac_link_down during phylink_link_down().

> diff --git a/include/linux/phylink.h b/include/linux/phylink.h
> index 15e6b1a39dfe2..ecf4c384fd31c 100644
> --- a/include/linux/phylink.h
> +++ b/include/linux/phylink.h

[ ... ]

> @@ -690,6 +692,16 @@ void pcs_an_restart(struct phylink_pcs *pcs);
>  void pcs_link_up(struct phylink_pcs *pcs, unsigned int neg_mode,
>  		 phy_interface_t interface, int speed, int duplex);
>  
> +/**
> + * pcs_link_up() - tear down link between MAC and PCS

[Severity: Low]
This isn't a bug, but should this kernel-doc block name the function
pcs_link_down() instead of pcs_link_up()? It appears the function name was
carried over from above, which might trigger kernel-doc warnings during
documentation builds.

> + * @pcs: a pointer to a &struct phylink_pcs.
> + *
> + * This call will be made just after mac_link_down() to inform the PCS the
> + * link has gone down. PCS should be configured to stop processing packets
> + * for transmission and reception.
> + */
> +void pcs_link_down(struct phylink_pcs *pcs);
> +
>  /**
>   * pcs_disable_eee() - Disable EEE at the PCS
>   * @pcs: a pointer to a &struct phylink_pcs

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260618125752.1223-1-ansuelsmth@gmail.com?part=9