From: sashiko-bot@kernel.org
To: gutierrez.asier@huawei-partners.com
Cc: damon@lists.linux.dev
Subject: Re: [PATCH v2 3/3] Docs/mm/damon/design: Document hugepage_mem_bp target metric
Date: Fri, 19 Jun 2026 15:06:34 +0000 [thread overview]
Message-ID: <20260619150634.945D01F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260619145821.2109933-4-gutierrez.asier@huawei-partners.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message body contains a typo regarding the metric name, referring to it as `huge_mem_bp` instead of `hugepage_mem_bp`.
--
commit 2ffffa695a51c9a7abedd1fec09204d864318807
Author: Asier Gutierrez <gutierrez.asier@huawei-partners.com>
Docs/mm/damon/design: Document hugepage_mem_bp target metric
This commit updates the DAMON design documentation to include the new
hugepage_mem_bp metric exposed by sysfs.
> Document huge_mem_bp metric exposed by sysfs.
[Severity: Low]
This isn't a bug, but there is a slight mismatch in the metric name here.
The patch subject and the actual documentation additions use hugepage_mem_bp,
while this line in the commit message body uses huge_mem_bp. Could the
commit message be updated to match the documented metric name?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260619145821.2109933-1-gutierrez.asier@huawei-partners.com?part=3
next prev parent reply other threads:[~2026-06-19 15:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-19 14:58 [PATCH v2 0/3] mm/damon: Introduce a huge page collapsing mechanism using auto tuning gutierrez.asier
2026-06-19 14:58 ` [PATCH v2 1/3] mm/damon: Introduce DAMOS_QUOTA_HUGEPAGE " gutierrez.asier
2026-06-19 15:12 ` sashiko-bot
2026-06-19 14:58 ` [PATCH v2 2/3] mm/damon/sysfs: support hugepage_mem_bp quota goal metric gutierrez.asier
2026-06-19 15:13 ` sashiko-bot
2026-06-19 14:58 ` [PATCH v2 3/3] Docs/mm/damon/design: Document hugepage_mem_bp target metric gutierrez.asier
2026-06-19 15:06 ` sashiko-bot [this message]
2026-06-19 15:59 ` [PATCH v2 0/3] mm/damon: Introduce a huge page collapsing mechanism using auto tuning SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260619150634.945D01F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon@lists.linux.dev \
--cc=gutierrez.asier@huawei-partners.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.