From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0496BCDB46B for ; Fri, 19 Jun 2026 17:05:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1702F10E0F5; Fri, 19 Jun 2026 17:05:19 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="BHq5Ju2u"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 53AF710E0DB for ; Fri, 19 Jun 2026 17:05:08 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 3988840569; Fri, 19 Jun 2026 17:05:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B7BF1F000E9; Fri, 19 Jun 2026 17:05:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781888708; bh=0LWz96AeAA9EAxmEvhCnS5urxZhCUU14/jNxWfhGneo=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=BHq5Ju2uJJ03TJtlx1HdwkVu6AVsMXsOIB7vjguk/J62GgVRdOxazs9rJ7ylUNFrJ UYyWiYZmdSqiRWpd3xq6whxy7aPbqJ/lEE1if7ajTzqskYYrw2xWGhSJBPfX3Hv6N6 mXSocUr/283Bmpct7Qo6vDwV3xPzAV4b/zpmDksPjdYVtFUdxC/4fbxlVMvsvMSIp2 Hx3MsNIU6D+V/LCO3Xy5+1JyYw1feumB2bR85yaZ6DQE2Rvabct64sL10+1y7e+z8B jufv4ZB08Aj6weN/B0b3C/neztF07aP7IxuCn1vHptbSe38sJs2Zor7y9jOv0OeeuE YiiMxKyWEwHpg== From: sashiko-bot@kernel.org Subject: Re: [PATCH 05/10] rust: driver: centralize device ID handling To: "Gary Guo" Cc: "Danilo Krummrich" , ojeda@kernel.org, robh@kernel.org, conor+dt@kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, "Alexandre Courbot" , dri-devel@lists.freedesktop.org In-Reply-To: <20260618-id_info-v1-5-96af1e559ef9@garyguo.net> References: <20260618-id_info-v1-0-96af1e559ef9@garyguo.net> <20260618-id_info-v1-5-96af1e559ef9@garyguo.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 19 Jun 2026 17:05:07 +0000 Message-Id: <20260619170507.9B7BF1F000E9@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > Move the `IdArray` creation from individual buses to be handled by shared > code in `device_id.rs`. >=20 > Signed-off-by: Gary Guo Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260618-id_info-v1= -0-96af1e559ef9@garyguo.net?part=3D5