Re: [RFC PATCH 13/13] mm/damon: remove damon_region->nr_accesses_bp

[SeongJae Park <sj@kernel.org>]

On Fri, 19 Jun 2026 19:49:02 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Stale comment in kdamond_fn() references the removed nr_accesses_bp field.
> --
> 
> commit 7fe8c1a02c74da4804760b45a04f15189947a500
> Author: SeongJae Park <sj@kernel.org>
> 
> mm/damon: remove damon_region->nr_accesses_bp
> 
> This commit removes the unused nr_accesses_bp field from struct damon_region,
> as well as its associated kernel-doc comments.
> 
> > diff --git a/include/linux/damon.h b/include/linux/damon.h
> > index 4f73d27979f0b..a18d905f28e14 100644
> > --- a/include/linux/damon.h
> > +++ b/include/linux/damon.h
> [ ... ]
> > @@ -77,7 +68,6 @@ struct damon_region {
> >  	struct damon_addr_range ar;
> >  	unsigned long sampling_addr;
> >  	unsigned int nr_accesses;
> > -	unsigned int nr_accesses_bp;
> 
> [Severity: Low]
> Is this a minor regression that leaves a stale comment in kdamond_fn()?
> 
> Looking at mm/damon/core.c, kdamond_fn() still explicitly references the
> nr_accesses_bp field:
> 
> mm/damon/core.c:kdamond_fn() {
>     ...
> 				 * information reset for all regions.  Then,
> 				 * following kdamond_reset_aggregated() call
> 				 * will make the region information invalid,
> 				 * particularly for ->nr_accesses_bp.
>     ...
> }
> 
> Should this comment in mm/damon/core.c be updated or removed to reflect the
> field's deletion?

Nice catch.  I will remove the mention of the field in the next revision.


Thanks,
SJ

[...]