From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57E0440D57A for ; Sat, 20 Jun 2026 05:07:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781932039; cv=none; b=hBu8XgAAP8ImCUxTtLzVwOk/F70B6AlVxSxbeGZd1ndB9lMZILwMhKTzV0mGGiKin5BLynfaVSclOfBCrersB9sn92bzo2iv6Xn8yJpi9nayJXRifm0mbMjsPLlxcZeSF2QURzEfRaa4iNO4+5O+jb1WheBpA268znAiZVkiuwc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781932039; c=relaxed/simple; bh=o5ozxRgIrnfg5IUvREvX7bW1hb6EaL1JrV/QBLbKLUk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YzGRlCyzo7s6JWjNgnoAH9RmE0mw6GD6PvJW9Uxj0jxM1FoGRjlcRJeX8uqkY5Q7S24o73u/vId8kTFdF40YeKdxvKvVMFJAqOKsL+rBsRmkci7v2QNxGjB7B087v0MHVtIFPQsvzGh6GhYXZ1RGy7YVSMWaJgmQUwUNSbnNiLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jVE4OD55; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jVE4OD55" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 739CB1F000E9; Sat, 20 Jun 2026 05:07:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781932038; bh=2pPUIHij7M7mxV5xh2vNOjYjc6TGY2WD0ya2f49U3vQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=jVE4OD55uko4MjoBCFpvBQ/6h5StD0b/q2TVWBVaJWZBEy/5bhk5z6G8AhVOSfrgD YoV1XxjVuPBtlu9kFxfd0IHySIwV91xOsW0coTgpbtQGi+8s8DnI2Stb/1zNQ97Hiy 5CtO3PqGCSco+EHFnM5SHUHbuq/R4ovD2Cen9DtM= Date: Sat, 20 Jun 2026 07:06:10 +0200 From: Greg KH To: Rishi Chhibber Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, vamsi-krishna.brahmajosyula@broadcom.com, yin.ding@broadcom.com, tapas.kundu@broadcom.com Subject: Re: [PATCH] misc: vmw_zerocopy: Add VMware zero-copy buffer sharing driver Message-ID: <2026062008-green-slashing-b3c7@gregkh> References: <20260617203125.397427-1-rishi.chhibber@broadcom.com> <20260619182710.2498154-1-rishi.chhibber@broadcom.com> <2026062044-crib-commodore-bea7@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2026062044-crib-commodore-bea7@gregkh> On Sat, Jun 20, 2026 at 07:04:55AM +0200, Greg KH wrote: > On Fri, Jun 19, 2026 at 11:27:10AM -0700, Rishi Chhibber wrote: > > This driver implements a misc character device (/dev/vmw_zc) that allows > > guest userspace applications to share pinned memory buffers with a > > VMware hypervisor-side peer using the VMCI datagram interface. > > > > The driver pins user pages via get_user_pages_fast(), transmits their > > physical page frame numbers to the hypervisor peer over VMCI, and avoids > > an intermediate copy between the guest workload VM and the hypervisor. > > > > The hypervisor-side peer for this interface only speaks VMCI; there is no > > virtio backend implemented on the VMware host for it. The closest > > existing upstream transport, vsock (virtio-vsock), provides a socket > > bytestream/datagram abstraction and does not expose a way to hand a set > > of pinned guest page frame numbers to the host for true zero-copy > > access; it would still require copying the payload through the socket. > > This driver's purpose is specifically to pin guest pages and pass their > > PFNs to the host so the payload is never copied. It also supports > > bundling multiple buffers in a single request, which is required for the > > all-or-none semantics of page-level zero-copy transfers. > > > > Signed-off-by: Rishi Chhibber > > --- > > Changes in v3: > > There is no "v3" in the subject line :( And, because of this, I will strongly recommend and almost require now, for you to get another internal person that has experience doing kernel development, to review and sign off on the next version of your patch. The community shouldn't be forced to do basic review like this, that's what your coworkers are for. thanks, greg k-h