Re: [PATCH net v3 2/2] selftests/bpf: Add LWT encap tests for skb metadata

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The assertion `ASSERT_GE(tap_ifindex, 0)` incorrectly accepts 0, which is the error return value of `if_nametoindex()`, masking interface lookup failures.
--

commit 78aa5c949a7515e0e86daf8bde1669b476228831
Author: Jakub Sitnicki <jakub@cloudflare.com>

selftests/bpf: Add LWT encap tests for skb metadata

This commit adds testing for LWT encapsulation and XDP metadata sitting in the
skb headroom. It exercises LWT dispatch paths including BPF, mpls, seg6, and
ioam6 to ensure outer headers do not silently corrupt metadata.

> diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_context_test_run.c b/tools/testing/selftests/bpf/prog_tests/xdp_context_test_run.c
> index 26159e0499c76..448807676176c 100644
> --- a/tools/testing/selftests/bpf/prog_tests/xdp_context_test_run.c
> +++ b/tools/testing/selftests/bpf/prog_tests/xdp_context_test_run.c
[ ... ]
> @@ -518,3 +559,137 @@ void test_xdp_context_tuntap(void)
[ ... ]
> +	SYS(close, "ip neigh add fd00::2 lladdr " TX_MAC " nud permanent dev " TAP_NAME);
> +	SYS(close, "ip -6 route add fd00:1::/64 %s dev %s", encap, TAP_NAME);
> +
> +	tap_ifindex = if_nametoindex(TAP_NAME);
> +	if (!ASSERT_GE(tap_ifindex, 0, "if_nametoindex"))
> +		goto close;

[Severity: Low]
Does this properly catch interface lookup failures? 

Looking at if_nametoindex(), it returns 0 on error, so using ASSERT_GE
will evaluate to true when tap_ifindex is 0. This allows the test to mask
the lookup failure and inappropriately proceed with an invalid interface index
to bpf_xdp_attach().

Could this be ASSERT_GT(tap_ifindex, 0, ...) instead?

> +
> +	ret = bpf_xdp_attach(tap_ifindex, bpf_program__fd(skel->progs.ing_xdp),
> +			     0, NULL);
> +	if (!ASSERT_GE(ret, 0, "bpf_xdp_attach"))
> +		goto close;
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260619-bpf-lwt-drop-skb-metadata-v3-0-71d6a33ab76b@cloudflare.com?part=2