Re: [PATCH 2/3] arm64: dts: qcom: Add HP EliteBook X G2q 14 AI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing `port@2` (SBU mux) in `pmic-glink` Type-C connectors, breaking DisplayPort alt-mode AUX routing on cable flip.
--

commit e810bc690ae1ce5520333f631dcdd9b455aa35d1
Author: Jason Pettit <jason.pettit@oss.qualcomm.com>

arm64: dts: qcom: Add HP EliteBook X G2q 14 AI

This commit adds the device tree for the HP EliteBook X G2q 14" Next Gen AI PC
based on the Snapdragon X2 Elite (Glymur) platform.

> diff --git a/arch/arm64/boot/dts/qcom/glymur-hp-elitebook-x-g2q.dts b/arch/arm64/boot/dts/qcom/glymur-hp-elitebook-x-g2q.dts
> new file mode 100644
> index 0000000000000..795940a999466
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/glymur-hp-elitebook-x-g2q.dts

[ ... ]

> +	pmic-glink {
> +		compatible = "qcom,glymur-pmic-glink",
> +			     "qcom,pmic-glink";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		/* Left side display-adjacent port */
> +		connector@0 {
> +			compatible = "usb-c-connector";
> +			reg = <0>;
> +			power-role = "dual";
> +			data-role = "dual";
> +
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +
> +					pmic_glink_hs_in: endpoint {
> +						remote-endpoint = <&usb_0_dwc3_hs>;
> +					};
> +				};
> +
> +				port@1 {
> +					reg = <1>;
> +
> +					pmic_glink_ss_in: endpoint {
> +						remote-endpoint = <&usb_0_qmpphy_out>;
> +					};
> +				};
> +			};
> +		};

[Severity: Medium]
The commit message mentions "2x USB Type-C with DisplayPort alt-mode", but
are connector@0 and connector@1 missing port@2 and an SBU mux (e.g.,
gpio-sbu-mux) here for the DisplayPort AUX channel?

Without the SBU mux defined in the graph, the pmic_glink_altmode driver
cannot locate it to flip the SBU lines when the Type-C cable is inserted
upside-down. Does this cause DisplayPort alt-mode to fail link training in
one of the cable orientations?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260620-glymur-send-v1-0-fc4a2cfd107c@oss.qualcomm.com?part=2