From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 078D42DCBFA; Sun, 21 Jun 2026 21:40:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782078050; cv=none; b=E7Mj2dGhsO3ta9WczvCRyOiEBDKahNKHD9i1oqxNnJkJotuiCzykba318GUmXjtO3KByM5XEmegGS0c7gdsledBGRJpABju2u9gsCwS2sB2c7LJ+/I+bYcBZMAKZ873yaomGLbrPfK4SwtMAgiw6BIk5MaEw5iY4pcsB+xqaUCw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782078050; c=relaxed/simple; bh=X5pGV1s0tb8RzbdB2MLctPvgkzsHzHWrGSc/nN3KGsM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aEjKExGp8UkQxxTgjemYAiYI4dwQH3mM7ScfXig7SI2x0tBKfx5A1eDSwXnfKxBaIdYrshMY2sktzMMubHHpiAGoKzPR/ZPtTqHtgLaKY6AYPEZvhNQ2jq+Yzd6rxnklarFr4HRMznJSZKHcskI3cC6NIn2JMr6G/HpMdcFbAN4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LEyG607A; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LEyG607A" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE6BB1F000E9; Sun, 21 Jun 2026 21:40:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782078049; bh=X5pGV1s0tb8RzbdB2MLctPvgkzsHzHWrGSc/nN3KGsM=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=LEyG607AjsH9UuvhNVXOCOfCZ9MkEPbKo2G30XGhwLDJbqZnDBH3zCYT5N0S/4qGQ JdVH1dj/RFyr7nTj4rpAPcqN33Zq7b0Py9ZxtZjTL7fMNaSViW70Z56YZD6KNZBX4U B7k2DgD1WtW2EiqJrtipDrqeUrTMBZHTDoMmPcWgH4sh8uCi4sPFyb99KbNjtURp83 jlMxEnmkJPeFLolkG/0STMvHgY7WK2+b3yZ6g2ZTotb4P5UFY9nYDBl/2Etfw7U/BA xLtdkOLRgINbK/ONjHXP37Jo+MfG70fUWctXloQuqvnquIgZs0EAp8Qi3tYCnC6c7t oqmkYatHIV8Jg== Date: Sun, 21 Jun 2026 14:40:47 -0700 From: Jakub Kicinski To: =?UTF-8?B?VGjDqW8=?= Lebrun Cc: Nicolas Ferre , Claudiu Beznea , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Haavard Skinnemoen , Jeff Garzik , Conor Dooley , Paolo Valerio , Nicolai Buchwitz , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Vladimir Kondratiev , Gregory CLEMENT , =?UTF-8?B?QmVub8OudA==?= Monin , Tawfik Bayouk , Thomas Petazzoni , Maxime Chevallier , stable@vger.kernel.org Subject: Re: [PATCH net v3 1/2] net: macb: give reasons for Tx SKB kfree Message-ID: <20260621144047.3db74e2b@kernel.org> In-Reply-To: <20260617-macb-drop-tx-v3-1-d4c7e57d890b@bootlin.com> References: <20260617-macb-drop-tx-v3-0-d4c7e57d890b@bootlin.com> <20260617-macb-drop-tx-v3-1-d4c7e57d890b@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 17 Jun 2026 11:17:29 +0200 Th=C3=A9o Lebrun wrote: > Fixes: 89e5785fc8a6 ("[PATCH] Atmel MACB ethernet driver") > Cc: stable@vger.kernel.org Interesting, did AI suggest this? It's fairly uncommon for drivers to care about drop reasons, packet loss on egress ports is pretty clearly attributed by tx_drops. I don't think this belongs in net, net-next would be fine, if you think it's necessary. Sashiko seems to point out a few more clear cut bugs. --=20 pw-bot: cr