Re: [PATCH bpf-next 2/3] selftests/bpf: Add tracing_multi link info tests

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect assertion failure message tag for invalid `addrs` pointer test.
--

commit edec3b6e703fee4df106f0b3f019e87b22c606fc
Author: Jiri Olsa <jolsa@kernel.org>

selftests/bpf: Add tracing_multi link info tests

This commit adds new tests for tracing_multi link info. The tests follow the
existing logic used for kprobe_multi and uprobe_multi tests.

> diff --git a/tools/testing/selftests/bpf/prog_tests/fill_link_info.c b/tools/testing/selftests/bpf/prog_tests/fill_link_info.c
> index f589eefbf9fbd..969f04ee9ac6a 100644
> --- a/tools/testing/selftests/bpf/prog_tests/fill_link_info.c
> +++ b/tools/testing/selftests/bpf/prog_tests/fill_link_info.c

[ ... ]

> +static void verify_tracing_multi_invalid_user_buffer(int fd, const struct tmulti_target *targets)
> +{
> +	__u32 ids[TRACING_MULTI_CNT] = {};
> +	struct bpf_link_info info;
> +	__u32 len = sizeof(info);
> +	int err, i;

[ ... ]

> +	/* Invalid cookies pointer -> EFAULT */
> +	memset(&info, 0, sizeof(info));
> +	info.tracing_multi.cookies = 0x1;
> +	info.tracing_multi.count = TRACING_MULTI_CNT;
> +	err = bpf_link_get_info_by_fd(fd, &info, &len);
> +	ASSERT_EQ(err, -EFAULT, "tracing_multi.bad_cookies");
> +
> +	/* Invalid addrs pointer -> EFAULT */
> +	memset(&info, 0, sizeof(info));
> +	info.tracing_multi.addrs = 0x1;
> +	info.tracing_multi.count = TRACING_MULTI_CNT;
> +	err = bpf_link_get_info_by_fd(fd, &info, &len);
> +	ASSERT_EQ(err, -EFAULT, "tracing_multi.bad_cookies");

[Severity: Low]
This isn't a bug, but is this tag a copy-paste error? The comment mentions
testing an invalid addrs pointer, but the assertion in
verify_tracing_multi_invalid_user_buffer() uses the
"tracing_multi.bad_cookies" tag rather than something like
"tracing_multi.bad_addrs".

> +}

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260621204524.61067-1-jolsa@kernel.org?part=2