From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F39E5372063 for ; Mon, 22 Jun 2026 23:55:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782172536; cv=none; b=WBDbwMmR/LkXttGWr8JWk9sY84ueYQVHuwg40NRpRdZ+/y0F2Q2x21P9vKDOBtI7JDZwVDOR0mTeB1rVsy7TbEmwSOqEpry/i/yj+TAqZdt0etZozg0UkIR6Q556Z9sqdQFf4jyh6i9m7xWfXRi/x+tqsTvaI4EXa8NPA6BmyJw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782172536; c=relaxed/simple; bh=gokVUSh2aCHv64iZ9iLvkNxqTSkJDs8XN4M4koe4Cuw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RO/Lw1A4p/sq/S2wI29Va5qzF6acIdSwzTOmMGyh+4gX79hO3m9eXYwOQiTEJi/aJ2GWhji0jLyPFOInv7UzRhOqPskegua99VLMltaORzKVgmylf0aEajuP9oE3V7HhWI3nEu23gh8aYZSwmsefNr+jRousxKY+YXo9v+MioMQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=BxSf3tO8; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="BxSf3tO8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782172535; x=1813708535; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=gokVUSh2aCHv64iZ9iLvkNxqTSkJDs8XN4M4koe4Cuw=; b=BxSf3tO8m1FpBS+o0M37xH2aeeujSLGQzZZ8x12eTzMkDqFeL4Oz5sKv 524eItbWx07j1B5bWDO4Yc+PqMo/WywfhhikZkVbUr0OOtfwBpU+F9bDW m6h75480JUJgb9KvjiRwgEWx420kiomdnLraOjQ/EDJa/snOYy1Ut8aTJ 1mYnjIie6Nkblkfj8u39w+nmbTMh7q2qHc2eUYJGd2lh9uFJV39CILldR UQ6O4C56+mOg/7HXjmn74lSv54w+YJUSvmNcPK6Y1WL7DYpXSAok7iA4f LaS9TTl183ScmeYb0vC6msFOK+NUksgILzXMvxPqH34+xKOyhFuJSlAEY Q==; X-CSE-ConnectionGUID: XNdaxO1QThSrzHcf4MlvXQ== X-CSE-MsgGUID: OY2kEUbBR9SM9xaLWrPXcQ== X-IronPort-AV: E=McAfee;i="6800,10657,11825"; a="82014491" X-IronPort-AV: E=Sophos;i="6.24,219,1774335600"; d="scan'208";a="82014491" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2026 16:55:31 -0700 X-CSE-ConnectionGUID: WEJNhn3NSrqOaH5o+Kp8dw== X-CSE-MsgGUID: +RsXrgmaSWys7rRh0JNcYQ== X-ExtLoop1: 1 Received: from unknown (HELO [172.25.112.21]) ([172.25.112.21]) by fmviesa003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2026 16:55:30 -0700 From: Ricardo Neri Date: Mon, 22 Jun 2026 17:05:52 -0700 Subject: [PATCH v5 2/6] sched/fair: Also gate overloaded status update for SD_ASYM_CPUCAPACITY Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260622-rneri-fix-cas-clusters-v5-2-19968f2d1497@linux.intel.com> References: <20260622-rneri-fix-cas-clusters-v5-0-19968f2d1497@linux.intel.com> In-Reply-To: <20260622-rneri-fix-cas-clusters-v5-0-19968f2d1497@linux.intel.com> To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Tim C Chen , Chen Yu , Christian Loehle , K Prateek Nayak , Barry Song Cc: "Rafael J. Wysocki" , Andrea Righi , Len Brown , ricardo.neri@intel.com, linux-kernel@vger.kernel.org, Ricardo Neri X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1782173185; l=1527; i=ricardo.neri-calderon@linux.intel.com; s=20250602; h=from:subject:message-id; bh=gokVUSh2aCHv64iZ9iLvkNxqTSkJDs8XN4M4koe4Cuw=; b=n2xQUwalGB3oIJuJNye0BW2THI+900LFdDdfF05tQ6NDObl9xF0Bjf52VFjAWdmYZq9r41JVS bj38p3u/fq9DyEDD/FUTUSvnqFJU3chJig2DWBIOWcvu/hk/WiS2K33 X-Developer-Key: i=ricardo.neri-calderon@linux.intel.com; a=ed25519; pk=NfZw5SyQ2lxVfmNMaMR6KUj3+0OhcwDPyRzFDH9gY2w= The argument sg_overloaded of update_sg_lb_stats() is only consumed when balancing at the root domain. It only makes sense to update it in such a case. Commit 3229adbe7875 ("sched/fair: Do not compute overloaded status unnecessarily during lb") updated the logic accordingly but missed the case in which the root domain has the SD_ASYM_CPUCAPACITY flag. Fix this. Fixes: 3229adbe7875 ("sched/fair: Do not compute overloaded status unnecessarily during lb") Tested-by: Christian Loehle Reported-by: Chen Yu Signed-off-by: Ricardo Neri --- Changes in v5: * Added Tested-by tag from Christian. Thanks! Changes in v4: * Introduced this patch. Changes in v3: * N/A Changes in v2: * N/A --- kernel/sched/fair.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 892abd7fcc18..31baa0000616 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -11863,7 +11863,9 @@ static inline void update_sg_lb_stats(struct lb_env *env, /* Check for a misfit task on the cpu */ if (sgs->group_misfit_task_load < rq->misfit_task_load) { sgs->group_misfit_task_load = rq->misfit_task_load; - *sg_overloaded = 1; + + if (balancing_at_rd) + *sg_overloaded = 1; } } else if (env->idle && sched_reduced_capacity(rq, env->sd)) { /* Check for a task running on a CPU with reduced capacity */ -- 2.43.0