From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 881AF346FAD
	for <linux-kernel@vger.kernel.org>; Mon, 22 Jun 2026 18:46:31 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1782153992; cv=none; b=Kp3zhlEbYbb9kQrTpB11NSwO4s78srFcPQj0Qa2Ay6qoRv0Th8fY3k1WxhOLY600modMdFMDwvIdEVcleIA4qiZEPDf2C0nubjf6dk75LKtjz33IFxaFKXfECE0KjEqAqbaHeT7xasAJjZ1zbrwn0BOIg4mBmjxGLKNnkV8JUFA=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1782153992; c=relaxed/simple;
	bh=TluUmdn22L9xxnEYl9kdqtquBQUhiMUbxE5QKj5uxSg=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=KNLPzwdwtrDxaYh8gHvQ5P27L2CUT19JGURWJOwAs8Ksd3KHuhw9sR6qTGR2vROuRL51ULs6unT8qaZ05p+8YiBV1EBRHA7H9Y+raMT2ScUFnbpcORkx506YfLV++gwmcA4KXrQsmq2Ca1odGM+Aa7teGfJGe8FnmxHp6xDPYq0=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=yF4J1Q80; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="yF4J1Q80"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 930DA1F000E9;
	Mon, 22 Jun 2026 18:46:30 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org;
	s=korg; t=1782153991;
	bh=Qi2mArupwpa3j9VQdXpjOGXBPKNPXbNfjodHiaTdjHk=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=yF4J1Q80Gw4S03iFDWHoT/JaKx2D14U7KUIGGrnuKgfuHZ3bpnocv1UsOcndXshse
	 4rhMWEAxpKasJ+ddggtIncI5gjKbj4TcS1DhDb/bqKgS/E8flq9rUdhOAYyQ9OzT+d
	 x4v7qYmNJ837T2jymaE8Lq99cDZRhioVvS5VMVIs=
Date: Mon, 22 Jun 2026 20:45:22 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>
Cc: Herve Codina <herve.codina@bootlin.com>, Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] misc: lan966x_pci: depopulate children on populate
 failure
Message-ID: <2026062204-confront-skier-6ff3@gregkh>
References: <20260622153328.81634-1-pengpeng@iscas.ac.cn>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260622153328.81634-1-pengpeng@iscas.ac.cn>

On Mon, Jun 22, 2026 at 11:33:28PM +0800, Pengpeng Hou wrote:
> lan966x_pci_probe() may create child platform devices before
> of_platform_default_populate() returns an error.  The error path unloads
> the overlay immediately, but it does not depopulate any children that
> were already created from overlay nodes.
> 
> Depopulate the children before unloading the overlay when population
> fails.
> 
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
> Reviewed-by: Herve Codina <herve.codina@bootlin.com>
> Reported-by: kernel test robot <lkp@intel.com>

The test robot did not report this problem :(

thanks,

greg k-h