From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B3241096F for ; Mon, 22 Jun 2026 05:18:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782105493; cv=none; b=YYLBBfJrNWmStalvLMhcQ0+2yDuiG8BF2QpUYGRspzLzbg3PKcwBvvV8voCCChIgMu8HBL5Erx7uiAwj48HtHBajVj0ENRM7jtel7fAQvrltVuwRZDtzH5hJgOQB1jfwmqw6yzucElka89T3bOGkWInJv3dxPGMFW9pYxwCpSK8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782105493; c=relaxed/simple; bh=Lf45AR56uftzfrbYIpOCIamKT4US3vSPGzkQ7HSjFQQ=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=HHatlLYOGYMtbz+knOpZQ0/Shux2MqCkV7+jqr7CkmE6Mo1cUTV5T/XbIqCl1WnkZZjbxkhlY8T/4E8TWADj8xERWD289TlWYjzUb8pao8VKgpNAqqpjgBDYwpzZMK6t+iDxs25DfiEsuw1OkbAogqJSAJwCsO0cmUvp64KdFCA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hDv/5pUw; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hDv/5pUw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8B041F000E9; Mon, 22 Jun 2026 05:18:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782105492; bh=SltqxpyAkDKvaQoSenMTMeKUBgLyr0EDUVM+nWznad8=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=hDv/5pUwhhuN1UAESrp1lELKpCcypDT3tBY7cSGQgN5gM0jpeQUB5XWs+J+xJnsOZ i3euhTH+WMdtFx4/G5qUFDqyts7/gUVmhK9ycFfEeVyCj74DVtOIh96YQeJ2iac83e Q/I/7vgc9Elz4+3n/gUZWyh2ZTf1P1WDafO1vzU9wZUOADE6TAEw6xqbdwYIeh+5BN QKRt0XNLUYaKZTAGMMl4EeQ3Z5NinLWxwm0mrmx+vPVwe/cyja/oSeCZqTValLtmKT dgtj5R1nmsvrAfdsMTZI8d0z2CAiTAgEHK1Eqec6xOm8WLZXOT5kZcp7QO+ikUXPew i00a2CucDYhew== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 1/8] dt-bindings: clock: qcom: Move glymur TCSR to own binding Reply-To: sashiko-reviews@lists.linux.dev To: "Qiang Yu" Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260621-tcsr_qref_0622-v6-1-c939c22ded0c@oss.qualcomm.com> References: <20260621-tcsr_qref_0622-v6-0-c939c22ded0c@oss.qualcomm.com> <20260621-tcsr_qref_0622-v6-1-c939c22ded0c@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 22 Jun 2026 05:18:11 +0000 Message-Id: <20260622051811.D8B041F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] The commit message claims to 'Mark the relevant supplies as requ= ired per compatible using allOf/if/then conditionals', but the implementati= on uses an unconditional global `required` list. The conditionals are actua= lly introduced in the subsequent patch 'dt-bindings: clock: qcom,glymur-tcs= r: Add mahua support', making the commit message for this patch inaccurate. -- commit 76f46a44f2c67eac7f27a435d31cca7e4ee64c0c Author: Qiang Yu dt-bindings: clock: qcom: Move glymur TCSR to own binding This commit creates a dedicated binding file for the Qualcomm TCSR clock controller on Glymur, moving it out of the shared sm8550-tcsr binding. It also documents the supply properties required for the QREF block. > Mark the relevant supplies as required per compatible using allOf/if/then > conditionals. [Severity: Medium] Is this description accurate for this specific patch? The commit message mentions using allOf/if/then conditionals to mark supplies as required per compatible, but the required list introduced in qcom,glymur-tcsr.yaml is unconditional and global. Could this paragraph in the commit message have been intended for a subsequent patch that introduces the allOf/if/then conditionals? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260621-tcsr_qref_= 0622-v6-0-c939c22ded0c@oss.qualcomm.com?part=3D1