From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C60E38F95E for ; Mon, 22 Jun 2026 08:13:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782116031; cv=none; b=ses85oXU7AeZei8fNz+GOyDMNbylzzBtCcbBzetouor9Zh20MBDvngT1UrHrQFlJkdLB7qS3gQNyzRekvODF4ajQPQjfZ28J94DEuSKywmgA/uQlr4gXuHIrSgk8jAP3EtaxKgsn4FjxK/msLOGqZ4+xqWq/5AtJdiSpuCtzQ5Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782116031; c=relaxed/simple; bh=F6H+rAEwAFlvo2vcoaq3mMaDhsIksTBUqphzpxP80WY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lnZI06ecKL/oM55jiLws34wr4Rfj21rWP9EluFpno3EPoa/3PKHwie7PEMd4Hjp1YOpyLmg3ibXO7s7n3VYSji+NX12ugysqDrT+i+lI/TvzK2/Q0zhiyPahKEvE4e90jFE8V4RPgMCb9qvRU4MSdr1KRN1rkKSt+Z1SpCuK2vs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mYadQOo4; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mYadQOo4" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-490b3637b90so31019495e9.3 for ; Mon, 22 Jun 2026 01:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782116027; x=1782720827; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=y69DNLtkcPX106ySVX6ZlNH6S9rjQScn7EBr8UTU9k0=; b=mYadQOo46NcgaU12CxB9GSPlIIegnCNLdCNhSOyW/I+Xy07v53GHjb50/R+GSFI+uR YlfBTbDf95ZxaB/UL/7XxShjkXDQD2vQ09dYUezg8LsqE0eDEIUsFBaQut53YdNbx3eO cJYu+JGbxn302NwD1+7xmLweKbs+aIfxkrSyQv2gQHvgLtNUfY5PPhFvCdz0vUe1cvi0 itW/cqtzbndpD86fPZZMZD03nuRNiJ6g1ijby3UiOPkjZXtsZwdDfCrmpkdXd6SM0zSO Gj1NCfGLVSTpe5zsqhmplOlaFb5PhD8s1Jk+ifwjkZhxHZzFqL/da7BZ6D9tFxKu9DZp YToA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782116027; x=1782720827; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=y69DNLtkcPX106ySVX6ZlNH6S9rjQScn7EBr8UTU9k0=; b=e9guhUj/2h/vJVaVqybh3DFdggBN6H8pJK8GGfGDHZsKjUJBm3qcqH7tZ1wWbNMp9r AbORWBj6nUkv1eNQPn6BtBFRXowa7TeYLZee5jo61HZmdBlggriIXYfr/3qZiD5iENRD tvi9geVzTtkCa7HSCf2+SjpfBqBGFLi5rg4hbhEIVq+ExWhIB7ne66REKmAPLOdWqfaI 3TKzqRRN7IrBBaTd7BoRaPYXnoGwhukd2ukovy5f6eK3cVMdty+d9l6Fr+X9ocN4pjkV zR5w421kQQT8sEuACsIOj8lipOfO5w97y7exl1OybguxC3KNmwcWe2k5CExytatNdh92 lDLQ== X-Forwarded-Encrypted: i=1; AFNElJ+l1OdH4KeSMVSGHjXhg76iTuJT/+tmdFH9m1zIy8E5WFoo+SEl349o/MhYXyGimr3x4Fjk55jci9s7ZgM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9dh/Tcpc1217gYCZVp3gq+CuhptOVElLNQco9Wn4gj6UhtceB YBI59mQvcqZX/E+cKdESkTklp68ybf31ByqTaNdXi6XFti9AVpOlTk22 X-Gm-Gg: AfdE7cke5fCCmd+7vARCxJdrEwZsW6nUgUpjpXOCY1QU8arV/IX67klgxjU9BrUAvAv M+LEpY4gIQZe12s9xRTcBAoBTOSkOFU6NeOhqykoiNX3VKSlG8lqF45bZ4Mm7cQOjWJjAuAbmxk sDosDouCWa235NT7S6TAniejF6odUKVg81VYvC2A3nmVWrQWdIcJpilJo2IcT9oVwdKB4OEwQVh /YC/faDis72XkWofRdWF1hG4gSlj72UetJ4xPuHw6M+B3ry7yvYw46bi7S/ah/9SL/NZSyLrsaU uayO8ksf5QT3RMOmwekFCn5bT3Sb7+NiTrB7Dj6k318iROmEXj7u3UbF/QPna6LTIy+Q+rG3PI7 z9j8D+u4DhEMQhrpJGrqAQKzN+QeVrPuJoWSoiPP/e3vVhBOb2/4aiypc34z8mnoY/0w5e8vyQk vGYonHHg1DnFLs3Q4/nptL/F17GNwh7LcJ0QCQLGNVBa5DPmcjNQ== X-Received: by 2002:a05:600c:8719:b0:492:4c60:bfb8 with SMTP id 5b1f17b1804b1-4924c60bfdemr121648545e9.28.1782116026585; Mon, 22 Jun 2026 01:13:46 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4923fd30078sm274806595e9.7.2026.06.22.01.13.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2026 01:13:45 -0700 (PDT) Date: Mon, 22 Jun 2026 09:13:44 +0100 From: David Laight To: David Hu Cc: Sumit Semwal , "Christian =?UTF-8?B?S8O2bmln?=" , Jason Gunthorpe , Nicolin Chen , Leon Romanovsky , Kevin Tian , Ankit Agrawal , Alex Williamson , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, jmoroni@google.com, praan@google.com, kpberry@google.com, sashiko-bot , stable@vger.kernel.org Subject: Re: [PATCH] dma-buf: Split sgl by largest page-aligned chunk Message-ID: <20260622091344.794e0d74@pumpkin> In-Reply-To: <20260621222130.1667453-1-xuehaohu@google.com> References: <20260621222130.1667453-1-xuehaohu@google.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 21 Jun 2026 22:21:30 +0000 David Hu wrote: > Currently, `fill_sg_entry()` splits the scatterlist using `UINT_MAX`. > This creates a non-page-aligned DMA length (`0xFFFFFFFF`) for the > first entry, resulting in non-page-aligned DMA addresses for all > subsequent entries. How did you find this? It requires a single buffer over 4GB - seems highly unlikely. > > While the underlying IOMMU mapping may be contiguous, hardware > DMA engines often require explicit address alignment (e.g., page, > cacheline, or storage sector boundaries). Passing unaligned > addresses and lengths can cause explicit failures in DMA descriptor > creation or silent data corruption if lower unaligned bits are > truncated. > > Fix this by splitting the scatterlist by the largest possible page > aligned chunk within `UINT_MAX` (`ALIGN_DOWN(UINT_MAX, PAGE_SIZE)`). > This ensures all scatterlist DMA addresses and lengths remain page > aligned and satisfy hardware constraints. It would almost certainly better to spilt into 2G chunks. That removes any need for any divisions. > Page-aligned entries allow the system to cleanly chunk payloads into > PCIe MaxPayloadSize (MPS) (e.g., 128 bytes, 256 bytes, 512 bytes). > As a result, this may help reduce TLP fragmentation in P2P transfers > and alleviate potential congestion within a logical PCIe switch > partition, especially when Relaxed Ordering is not possible due to > hardware constraints. > > Reported-by: sashiko-bot > Closes: https://lore.kernel.org/all/20260609165431.778061F00893@smtp.kernel.org/ > Fixes: 3aa31a8bb11e ("dma-buf: provide phys_vec to scatter-gather mapping routine") > Cc: stable@vger.kernel.org > Signed-off-by: David Hu > --- > drivers/dma-buf/dma-buf-mapping.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/dma-buf/dma-buf-mapping.c b/drivers/dma-buf/dma-buf-mapping.c > index 794acff2546a..f2bde38fdb1f 100644 > --- a/drivers/dma-buf/dma-buf-mapping.c > +++ b/drivers/dma-buf/dma-buf-mapping.c > @@ -5,6 +5,9 @@ > */ > #include > #include > +#include > + > +#define MAX_ENT_SZ ALIGN_DOWN(UINT_MAX, PAGE_SIZE) > > static struct scatterlist *fill_sg_entry(struct scatterlist *sgl, size_t length, > dma_addr_t addr) > @@ -12,9 +15,9 @@ static struct scatterlist *fill_sg_entry(struct scatterlist *sgl, size_t length, > unsigned int len, nents; > int i; > > - nents = DIV_ROUND_UP(length, UINT_MAX); > + nents = DIV_ROUND_UP(length, MAX_ENT_SZ); > for (i = 0; i < nents; i++) { Why not change that to 'while (length) {' to avoid the division above. > - len = min_t(size_t, length, UINT_MAX); > + len = min_t(size_t, length, MAX_ENT_SZ); I bet that doesn't need to be min_t() > length -= len; > /* > * DMABUF abuses scatterlist to create a scatterlist > @@ -24,7 +27,7 @@ static struct scatterlist *fill_sg_entry(struct scatterlist *sgl, size_t length, > * does not require the CPU list for mapping or unmapping. > */ > sg_set_page(sgl, NULL, 0, 0); > - sg_dma_address(sgl) = addr + (dma_addr_t)i * UINT_MAX; > + sg_dma_address(sgl) = addr + (dma_addr_t)i * MAX_ENT_SZ; > sg_dma_len(sgl) = len; Replace the multiply with 'addr += len'. -- David > sgl = sg_next(sgl); > } > @@ -41,14 +44,14 @@ static unsigned int calc_sg_nents(struct dma_iova_state *state, > > if (!state || !dma_use_iova(state)) { > for (i = 0; i < nr_ranges; i++) > - nents += DIV_ROUND_UP(phys_vec[i].len, UINT_MAX); > + nents += DIV_ROUND_UP(phys_vec[i].len, MAX_ENT_SZ); > } else { > /* > * In IOVA case, there is only one SG entry which spans > * for whole IOVA address space, but we need to make sure > * that it fits sg->length, maybe we need more. > */ > - nents = DIV_ROUND_UP(size, UINT_MAX); > + nents = DIV_ROUND_UP(size, MAX_ENT_SZ); > } > > return nents;