From: sashiko-bot@kernel.org
To: "Haoxiang Li" <haoxiang_li2024@163.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI/IOV: Drop device reference on sriov_init() failure
Date: Mon, 22 Jun 2026 09:40:36 +0000 [thread overview]
Message-ID: <20260622094036.84D171F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260622093132.910859-1-haoxiang_li2024@163.com>
> sriov_init() takes a reference to another PF device with pci_dev_get()
> when an existing PF is found on the bus. If compute_max_vf_buses() fails
> afterwards, the error path clears dev->sriov and frees the pci_sriov
> structure, but does not drop that reference.
>
> Release iov->dev before freeing iov on the error path, matching the
> cleanup done by sriov_release().
>
> Fixes: ea9a8854161d ("PCI: Set SR-IOV NumVFs to zero after enumeration")
> Cc: stable@vger.kernel.org
> Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260622093132.910859-1-haoxiang_li2024@163.com?part=1
prev parent reply other threads:[~2026-06-22 9:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 9:31 [PATCH] PCI/IOV: Drop device reference on sriov_init() failure Haoxiang Li
2026-06-22 9:40 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260622094036.84D171F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=haoxiang_li2024@163.com \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.