Re: [PATCH v3 3/8] hwmon/misc: amd-sbi: Move sbtsi register transfer to core abstraction

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Using `select AMD_SBTSI` in `CONFIG_SENSORS_SBTSI` bypasses the dependencies of `AMD_SBTSI`, which can cause Kconfig warnings and linker errors (Build Failure).
--

commit 244321241d8d6647a9adc1fb143dcedb41e11593
Author: Prathima <Prathima.Lk@amd.com>

hwmon/misc: amd-sbi: Move sbtsi register transfer to core abstraction
    
Move the I2C read/write byte operations from the sbtsi hwmon driver into
a common sbtsi_xfer() function in tsi-core.c. This decouples the hwmon
sensor driver from the underlying bus transport, preparing for I3C
support in a subsequent patch.

> diff --git a/drivers/misc/amd-sbi/tsi-core.c b/drivers/misc/amd-sbi/tsi-core.c
> new file mode 100644
> index 0000000000000..6ef1831515bbb
> --- /dev/null
> +++ b/drivers/misc/amd-sbi/tsi-core.c
> @@ -0,0 +1,30 @@
[ ... ]
> +/* I2C transfer function */
> +static int sbtsi_i2c_xfer(struct sbtsi_data *data, u8 reg, u8 *val, bool is_read)
> +{
> +	if (is_read) {
> +		int ret = i2c_smbus_read_byte_data(data->client, reg);

[Severity: High]
Will this lead to a linker error (undefined reference to
i2c_smbus_read_byte_data) if a user configures CONFIG_SENSORS_SBTSI=y and
CONFIG_I2C=m?

The Kconfig option SENSORS_SBTSI uses select AMD_SBTSI but fails to
mirror the dependencies required by AMD_SBTSI (such as depends on
I3C_OR_I2C and architecture restrictions like depends on ARM || ARM64 ||
COMPILE_TEST). 

If CONFIG_I2C=m and CONFIG_SENSORS_SBTSI=y, Kconfig forcefully sets
CONFIG_AMD_SBTSI=y. This triggers an unmet direct dependencies Kconfig
warning, and since tsi-core.c is built-in (y) while I2C is a module (m),
it breaks the build.

This problem was introduced earlier in the series, but it remains
unresolved at the end of the series.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260622135821.2190260-1-Akshay.Gupta@amd.com?part=3