From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 929A8330315 for ; Mon, 22 Jun 2026 15:14:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782141294; cv=none; b=jc+869X7b1ACXX1Z9FtxKCW2cbOjd89JTp1WLuLvFPVxQKRHGBuUE351OExIiaE14AXJAccOmrLYqMgeVRNwUmWys9DaIIZ8X4zaks7yzXV7zwQGnYdyZGy3Y/lZsZ/ZpsNpAm1ZS3P/QB03lFK6ubEHTctArWjhHbgFa0Qt6Ns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782141294; c=relaxed/simple; bh=OPKOdVzQxz1dh4B1S7xlpPDqNLIqpvB5YyA31xHEBmQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cxfpv2Jguf3H6BAdl6z9oo5tLqkl9tzo3SESMUsCCj06gC9cdj8zeJ+R8rTXFTSq1XPF4xOaUSFt7VmhzbWoBmIjBbVpPWfIBrZxvd0rbSna2zxvOiCccoLit8jcj6f8APRS+Co1hqAkCvm4iWPUqmJ02cnNh3eSJpok+DAXI0U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DlCjP+3H; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DlCjP+3H" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-8423f236418so2319044b3a.1 for ; Mon, 22 Jun 2026 08:14:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782141293; x=1782746093; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XS2jT7hVM4XCWKhj2hYkN4S7SwrftLDakyjg4kfk5Kc=; b=DlCjP+3H4Ajk7II7LheFEUqQiv1Eru51LkCNbe9AGSVtNF46l8XTmY1QMBUvBp8OiA cPQ2Musze7cYuXnVv0JzZIXpU7a3xH4JNN/clfH3IPSkvZy6JQXBJRrLlGfu78F3VMjq yf+pxmpUHP9jYp8u29RGMrMDbgh8Kyyu32EK3woeQ1YjTcAGHsj6ENUTf06XbNyp71Xt odsMpPOT5fy1yIFG4H9mC2DBkSA4iQzyaQzTfQJ0avEr774p+0+33EsQc7c6Xvi61wff I9o91uh+/49mMaKhNZqiCsk0zIKC8tjmHIGCAyFAXDMoAhj3hcZZ8eQg4h+cJSu4pD3S HpgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782141293; x=1782746093; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XS2jT7hVM4XCWKhj2hYkN4S7SwrftLDakyjg4kfk5Kc=; b=e6K3/WQr+cZoW3BqKL/H6EB61Z15Yrhhh7Az770YFDS22Mm1PMwik9lVQ7z64WJRIq VzClbCHVj2RArN7KDLuT8eCYjpfs6iZr2cSyUAQ6eHqKOa7EpOm2LFleVct3RRPmHXT6 luQlGcRevMawaNqImWOqBJSrcMw8osp7GhyHvF+F55o7yEMnhNM2ZSDXXWmWdfF6t+HB GEi3GwBMAvPoiQ9yt3ydtpdSoKw6LcOWqCbtyin5caLki4TFV5YQSsINcKgcf1tkIIpb BY8Shw98gg7akZOjPKW3ysRYn1wQMPm5PM1+zATczsfvxjr+DzeN5DT4Qxh/gwdJJo8Z Qk4A== X-Forwarded-Encrypted: i=1; AFNElJ9r1AI08SZUDXrKKRl46WzuA2cPdQnVxtQFYCSai5k724sA8C//XU/ENgSVnT+ADSVCjtcNGslbfzP0XzY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3fspLeZHQ4p7e/NW8pofFfcpDl8fX2rhW7sg4baA2rAI1FXoi OzayjO5/Xhs4M1RXo5Yy+DXMqrlhMpu0xcxoH7wzmtEPw1NUvuhQQ4gb X-Gm-Gg: AfdE7ck7y+xvbF7hqvVqwAnwg0EBiGfEh6AjTArqEJELvLQ6WwUnjxthBty+eZFtBTf zESsBhzl79yczNHvmwaPj5J10zKEOF4CVO4t/ZlP7zvR/YNjN2ucEcXNnuKNezD6TLgF+7KBkQS VUxF8LrYR7iKy/BHWTGaRkUmAWuRl1mPZvd+0JNd+1mGbXtQCleUTCeKN6+mtlgEI6m9NbQte4C cgx0Xvx0+MCymwfb8WdKWIsTX9FgbOkSROkXV2zl6kpVSGRrIpsKvknfSNZSd8jvatkp/Y0u/+M g+qvEY0xslIoNO73IoZZMbPqFAWyhNhrKZQJe0DAVWmDwel+2H/OToOdzQukAfLr2okNW79F3L7 LiUpccFyxiv2Hhz6iZjIKk+O4sIQs1YdfykYpNNN10AqmW7EZHXis7zW7zVyIpSvtGRfSQT4lfg bRByGVKnb8kvJNyrqx4Pzc2ONaH7HD+5Z+3Mm8Ed9/BLPa X-Received: by 2002:a05:6a00:a21a:b0:845:2f67:a0e6 with SMTP id d2e1a72fcca58-84550b1a5c8mr15972110b3a.46.1782141292825; Mon, 22 Jun 2026 08:14:52 -0700 (PDT) Received: from LAPTOP-TMVMP5FD.localdomain ([106.222.250.238]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84564d68edasm7514146b3a.1.2026.06.22.08.14.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2026 08:14:52 -0700 (PDT) From: Keshav Verma To: Jaegeuk Kim , Chao Yu Cc: Randall Huang , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Keshav Verma , stable@kernel.org Subject: [PATCH v2] f2fs: fix listxattr handling of corrupted xattr entries Date: Mon, 22 Jun 2026 20:44:21 +0530 Message-Id: <20260622151421.806-1-iganschel@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260618200105.3551-1-iganschel@gmail.com> References: <20260618200105.3551-1-iganschel@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Validate the xattr entry before reading its fields in f2fs_listxattr(). Return -EFSCORRUPTED when the entry is outside the valid xattr storage area instead of returning a successful partial result. Fixes: 688078e7f36c ("f2fs: fix to avoid memory leakage in f2fs_listxattr") Cc: stable@kernel.org Reviewed-by: Chao Yu Signed-off-by: Keshav Verma --- Changes in v2: - Add Fixes tag. - Add Reviewed-by tag. - Add Cc: stable@kernel.org tag. fs/f2fs/xattr.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c index 610d5810074d..18f495db20d2 100644 --- a/fs/f2fs/xattr.c +++ b/fs/f2fs/xattr.c @@ -581,8 +581,6 @@ ssize_t f2fs_listxattr(struct dentry *dentry, char *buffer, size_t buffer_size) size_t prefix_len; size_t size; - prefix = f2fs_xattr_prefix(entry->e_name_index, dentry); - if ((void *)(entry) + sizeof(__u32) > last_base_addr || (void *)XATTR_NEXT_ENTRY(entry) > last_base_addr) { f2fs_err(F2FS_I_SB(inode), "list inode (%llu) has corrupted xattr", @@ -590,9 +588,12 @@ ssize_t f2fs_listxattr(struct dentry *dentry, char *buffer, size_t buffer_size) set_sbi_flag(F2FS_I_SB(inode), SBI_NEED_FSCK); f2fs_handle_error(F2FS_I_SB(inode), ERROR_CORRUPTED_XATTR); - break; + error = -EFSCORRUPTED; + goto cleanup; } + prefix = f2fs_xattr_prefix(entry->e_name_index, dentry); + if (!prefix) continue; -- 2.39.5 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 257ECCD98F2 for ; Mon, 22 Jun 2026 15:15:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-Id:Date:To:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cq2nGS0us8dXKkGmfBPrwmdmiYwq0T1iL9z8llIJv88=; b=GCkJfqFLcgThzF7r8/2t8PBv7f L87cEhb1GDExoavgD2TLIUdANoz3lqtduNAbXNqjUJUlg005GOAkoMbXH9gr4nu6C8qxM8hyoYlVp UuoIrMdBy5sepY2zBtoRLVPT86Pp75qZZm6compLSNFTPE+Hzeb+J3Ckmk/Cl46a2t14=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wbgMV-0007Hv-Rk; Mon, 22 Jun 2026 15:15:00 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wbgMU-0007Hn-91 for linux-f2fs-devel@lists.sourceforge.net; Mon, 22 Jun 2026 15:14:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XS2jT7hVM4XCWKhj2hYkN4S7SwrftLDakyjg4kfk5Kc=; b=mv9LI23N3g3ZHbelNLPp+vwAyy WcDNZYMeVX1XCQDUysnRGQdv0U+gIvatBlJYaaesiC7+snD6Of+39Q8n9s8DNFvbpnK5z7Vrti9iZ KPjFWvzpaR5JXUDUm8nyrG14TdTpl0XYkG2HjD0QtiphUOyR0kKf0JIj4U+6odvV06lM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XS2jT7hVM4XCWKhj2hYkN4S7SwrftLDakyjg4kfk5Kc=; b=TlspoRVilRuPemQjYPUH8WFUGP Ci+WVv3pqDlipU8UuUSxtKNaKvbrAzQHalX29e5YRC1OcWj3DTbLzM80Q5NscqjrSPdd0nxqoQUFI 9rPSgkfbCTi7iVrHttbLbspcRQ6rn2R0Yolx0bsIvvSw0ubXlombC1cT58b5LfNdAx5U=; Received: from mail-pf1-f175.google.com ([209.85.210.175]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1wbgMU-0006sI-2T for linux-f2fs-devel@lists.sourceforge.net; Mon, 22 Jun 2026 15:14:58 +0000 Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-845537740ddso1564718b3a.0 for ; Mon, 22 Jun 2026 08:14:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782141293; x=1782746093; darn=lists.sourceforge.net; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XS2jT7hVM4XCWKhj2hYkN4S7SwrftLDakyjg4kfk5Kc=; b=Vd3BnEIurHzFSH3kx948ooUK+h1bljEKqvaR7zkKiO8rrV2Rj2FLS2fKF9dJyJBWCF r0ZAbjwdmt82RgHL5kXrLhLI4/FsO2VCU2Ivwx/uBOK4CxCDvwq3P5EgBOscimlIjvh/ vd2WEsWRm5r29NRpeKIwTQvdOt8iyGsXlBgqHTZowS3Vom/ZCr+HOtGZhFGTj+AxVmz3 lQU6pIjQS/KAP7Gh8dUFOxwvXYK68hFBUZu9QZ/XBNDYJUNUcJWJ6k9RVe7Z4U97/2vQ sLoeRPMm/xKfnnwsVIMlf99fCVRCmvmgqFBoOEFY5TO4J37qCc/G7Hln4V3vPu38rvJl 0HWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782141293; x=1782746093; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XS2jT7hVM4XCWKhj2hYkN4S7SwrftLDakyjg4kfk5Kc=; b=sZ6FZBlCIJnqBAdOekvMKWBC7MIkgSGRNoHWYH7Wz593rAO4bhWx+iXxQv91m4sbSl g+7ExBTUtTKjLCjbtrxH7DwD7PON2XRcOTDv3XPVAvSSSrDIS6e4ohdMO/0Ccp6lDfk4 eD9v/gFxNWU8rMPKi5g2U8BoMRmeQj40urzKAsQeiCCTJ1gNNGeIKccuCcK7zGIoBGKu AIDsDHoGU7ZiASNDWNL/uCccqQ1y6bRxeK67kRbO7yKJe14NmJvT7p4UYWHqCyoZVRNa p6L5+XdVwFtQgqF3EQdCpTlF/WnM5n7UFemvaPIzuuyXiqf/QhkWtexDJ3Umr2/lCj8C riNw== X-Forwarded-Encrypted: i=1; AFNElJ//dtMQBl4oOhhMHQOxr/M4wux4tyCLtW5ZL5iLzYma5FJ9LHKu2AjxBuen0e5gVUEAUrdV/LtYDX1143YuMcWH@lists.sourceforge.net X-Gm-Message-State: AOJu0YzeSxKjuQeStPa0S/fsrVYzJrz5pa+UmhTCxSoXfLwQpnUMFpAg 13kRZrYMQh37WRSagNsr6Z7sZtXGEPYMP5kkUP83FJq8gca9ysVWWgYN X-Gm-Gg: AfdE7ckOqnfR2Rv1q6e5z1Ed+oF4rLEqvhIxZ0xbNnxvQhqzOAisUec7+ONbStNBmwq mOlNwJf9ARLBxt+kIaK8N0CYPcBt8kg1vPn1cETu8Y30zXyIX8FUyl6D6WYlJOgj+9mDb+2u/2g eGar5X1bVs8/mbmuLnSys4Feitq4Qdf6xNJd1s5H8oC75rgQ3sSSqSMATfeYE/kwF0GTtgo+342 QxChWcb3Xg3S10c+m3zMAHNThagAbtHvGfXpdH5Q0oOjfM0Gh5PsrkJOL10YeFqtO88Gvf6q8If D0C25HFJrxATNbZCBkyoiHDrGRjvJ4bY4jOLqibR04TBhZzQuMVpdCzDghYyJRfTmEQ8ttSjWcm hMrRrMQ8CCxOYvgb+ijnj+U8133NHOSUW1KwxTItoEYLi2EPtm81cyM4Ts6IEShbbddIaJOfUl5 QyRq4PxG4VMmH9n8CnJXjS+im9D/7I4hMe9WBzPbZ1mclW X-Received: by 2002:a05:6a00:a21a:b0:845:2f67:a0e6 with SMTP id d2e1a72fcca58-84550b1a5c8mr15972110b3a.46.1782141292825; Mon, 22 Jun 2026 08:14:52 -0700 (PDT) Received: from LAPTOP-TMVMP5FD.localdomain ([106.222.250.238]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84564d68edasm7514146b3a.1.2026.06.22.08.14.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2026 08:14:52 -0700 (PDT) From: Keshav Verma To: Jaegeuk Kim , Chao Yu Date: Mon, 22 Jun 2026 20:44:21 +0530 Message-Id: <20260622151421.806-1-iganschel@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260618200105.3551-1-iganschel@gmail.com> References: <20260618200105.3551-1-iganschel@gmail.com> MIME-Version: 1.0 X-Headers-End: 1wbgMU-0006sI-2T Subject: [f2fs-dev] [PATCH v2] f2fs: fix listxattr handling of corrupted xattr entries X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@kernel.org, linux-kernel@vger.kernel.org, Keshav Verma , linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Validate the xattr entry before reading its fields in f2fs_listxattr(). Return -EFSCORRUPTED when the entry is outside the valid xattr storage area instead of returning a successful partial result. Fixes: 688078e7f36c ("f2fs: fix to avoid memory leakage in f2fs_listxattr") Cc: stable@kernel.org Reviewed-by: Chao Yu Signed-off-by: Keshav Verma --- Changes in v2: - Add Fixes tag. - Add Reviewed-by tag. - Add Cc: stable@kernel.org tag. fs/f2fs/xattr.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c index 610d5810074d..18f495db20d2 100644 --- a/fs/f2fs/xattr.c +++ b/fs/f2fs/xattr.c @@ -581,8 +581,6 @@ ssize_t f2fs_listxattr(struct dentry *dentry, char *buffer, size_t buffer_size) size_t prefix_len; size_t size; - prefix = f2fs_xattr_prefix(entry->e_name_index, dentry); - if ((void *)(entry) + sizeof(__u32) > last_base_addr || (void *)XATTR_NEXT_ENTRY(entry) > last_base_addr) { f2fs_err(F2FS_I_SB(inode), "list inode (%llu) has corrupted xattr", @@ -590,9 +588,12 @@ ssize_t f2fs_listxattr(struct dentry *dentry, char *buffer, size_t buffer_size) set_sbi_flag(F2FS_I_SB(inode), SBI_NEED_FSCK); f2fs_handle_error(F2FS_I_SB(inode), ERROR_CORRUPTED_XATTR); - break; + error = -EFSCORRUPTED; + goto cleanup; } + prefix = f2fs_xattr_prefix(entry->e_name_index, dentry); + if (!prefix) continue; -- 2.39.5 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel