From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95C22CDB475 for ; Mon, 22 Jun 2026 19:45:42 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wbkZy-0005b6-I0; Mon, 22 Jun 2026 15:45:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbkZu-0005ZO-S0 for qemu-trivial@nongnu.org; Mon, 22 Jun 2026 15:45:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbkZs-0004Ul-Vp for qemu-trivial@nongnu.org; Mon, 22 Jun 2026 15:45:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782157502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/r0zybNsLAP35GUJj9NU9qaV2oxViFxnkPWdhaAlQcU=; b=PLjjzhi5vceq15jiAbUrvs8HosoVJE/Hlgrt3s2x8A0yaHB2H+3YZo3ts/Cj6geMm37cwk CfQWJ9odSBNUpLS6DOcqiS+h7oKnVFyk5ekKXQ0L4qJErz0tpSXQ7R7VvFTaCybQDuslKZ ORmKMpCuAdBVOEdzGySLShd9scj08O0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-329-ZfnZqVTmNYmCaV64IWvZPA-1; Mon, 22 Jun 2026 15:45:00 -0400 X-MC-Unique: ZfnZqVTmNYmCaV64IWvZPA-1 X-Mimecast-MFC-AGG-ID: ZfnZqVTmNYmCaV64IWvZPA_1782157499 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-492488f8583so24626095e9.2 for ; Mon, 22 Jun 2026 12:45:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782157499; x=1782762299; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/r0zybNsLAP35GUJj9NU9qaV2oxViFxnkPWdhaAlQcU=; b=MO/lJE8V2pugCYLKPRnUBbHxqFczWsIC+eTg1gtQ4HkoduLI63gIbyKQSNBQ7GkLCz m3lKFSbWJTTcwFcrGQWZ/guAf8NqeLe64Jd3uSIeOJpHwpa/KONFCO35BztsVG87v94p oWWhHRdtcWXVnDsm1yl5DMVpD1tY98hzW1qnA50AmTZltngA4BfIg7SCfar3+IYYbiTD 1hDxnyBJKZfIOux8/s6wkdvTObsnyqGvX8LloRnOsfWQ4Md8Gq3aKVk14uWJ5qCak6qA 0d6d5JbUrt+E7lkjx/ZsA0rnHhRP2ygwg1VxUOhm14UzN0UUCe0LJEy4sXvbc501A/kc vz0g== X-Forwarded-Encrypted: i=1; AFNElJ+5dLx3sd02o1OAS46vaG0iPtpGW/vHQ8Wsg5tZoyP4arNliD9kM+pPV9TNx0tRflgcBS/ImL/qq909ka4=@nongnu.org X-Gm-Message-State: AOJu0Yw67y1gUu22x6ysxJv/tqJX/i8UG+raocKLhiPj8zmcGJh7dZpC wwmYrtMxxrLWPlsT1txiy0jif7hYnqQbJUlILMzvgtvfE13zdQd4eH1rrHQbBQckoJk1Ls1Rdku 8VXRFqdkRMl2JAHC4CxYZUfphiMKKMx2zB4z5Tg4zb8oesw/xFCeM8E4W6SA= X-Gm-Gg: AfdE7cmE5+Vo8LK8RgcmlFinwuDYZ7oyeRbVlvV6uMWXttzquAC/s8SUbmUs/2112nT HoiPG2cJtqHYwG36GgMA0nPQxYRKPPJKCpF7eM8K5Mac3uSJUDZPecCVYOs7+ww4HK7zYsJfvnf CyEZ0G6vnKOS+pAR+z392w4m0Orw2Dag2fZTKaCDEPXHmEC3Xg4rr2Y8n+CTCwsw8eyAudXNNOF b2AL3Of5zoi4MMtQfHNcpA/sQxa+Oj/nKpZz3vbGYdRcvI6xDorflZzTsBHzlsxe8yWRW1IiFZV 5yJXqo9TCNsPOiUJJ5kZX2g7v+KHCL7bpt9HpCdaOGezfYus+WxhDkfCTfEg0+GO3EoNADXYu0B vFvtX3UFvLxuhGG2I0hh+H4eJjJt55sFT X-Received: by 2002:a05:600c:a40f:b0:492:432b:d78b with SMTP id 5b1f17b1804b1-492432bdad3mr193558445e9.15.1782157499293; Mon, 22 Jun 2026 12:44:59 -0700 (PDT) X-Received: by 2002:a05:600c:a40f:b0:492:432b:d78b with SMTP id 5b1f17b1804b1-492432bdad3mr193558315e9.15.1782157498788; Mon, 22 Jun 2026 12:44:58 -0700 (PDT) Received: from redhat.com (IGLD-80-230-85-71.inter.net.il. [80.230.85.71]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4666678828dsm28453274f8f.19.2026.06.22.12.44.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2026 12:44:58 -0700 (PDT) Date: Mon, 22 Jun 2026 15:44:55 -0400 From: "Michael S. Tsirkin" To: =?iso-8859-1?Q?Cl=E9ment?= MATHIEU--DRIF Cc: no92 , "qemu-devel@nongnu.org" , "qemu-trivial@nongnu.org" , "qemu-stable@nongnu.org" , Jason Wang , Yi Liu , Paolo Bonzini , Richard Henderson Subject: Re: [PATCH] hw/i386/x86-iommu: Correctly set pt bit in extended capability register Message-ID: <20260622154210-mutt-send-email-mst@kernel.org> References: <20260622162138.1045170-1-leo@managarm.org> <0b93c0b06c39f7dc6faa7ab21f57034081df83dd.camel@bull.com> MIME-Version: 1.0 In-Reply-To: <0b93c0b06c39f7dc6faa7ab21f57034081df83dd.camel@bull.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 9PTMlbljEedV0hkIYKaY6yNbw7DrDLj15pqHf0yz2-I_1782157499 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-trivial-bounces+qemu-trivial=archiver.kernel.org@nongnu.org Sender: qemu-trivial-bounces+qemu-trivial=archiver.kernel.org@nongnu.org On Mon, Jun 22, 2026 at 05:31:01PM +0000, Clément MATHIEU--DRIF wrote: > Hi, > > I think I have seen this patch at least twice in the list o.O > > It seems it has not been merged into master yet (@Michael, do you want me to send a rebased version?). rebased or not, I was not CC'd. > https://patchew.org/QEMU/CAFFE2avrHDKZd5m7j3E3x5=F=pzn-3c9vzGWP3+9-AVPwQng7w@mail.gmail.com/ > > Thanks for the effort though ;) > > cmd i can pick this one or wait for your patch. > > On Mon, 2026-06-22 at 18:21 +0200, no92 wrote: > > Caution: External email. Do not open attachments or click links, unless this email comes from a known sender and you know the content is safe. > > > > > > With the changes in c7b2e22bd957, the `pt` bit was set in the (wrong) > > capability register, instead of the (correct) extended capability > > register. > > > > Fixes: c7b2e22bd95710e404c393e9f563cfe7404220c1 ("hw/i386/x86-iommu: Remove X86IOMMUState::pt_supported field") > > Signed-off-by: no92 <[leo@managarm.org](mailto:leo@managarm.org)> > > --- > >  hw/i386/intel_iommu.c | 4 ++-- > >  1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > > index 744cdfd2e6..d1af7a3135 100644 > > --- a/hw/i386/intel_iommu.c > > +++ b/hw/i386/intel_iommu.c > > @@ -4988,7 +4988,7 @@ static void vtd_cap_init(IntelIOMMUState *s) > >  { > >      X86IOMMUState *x86_iommu = X86_IOMMU_DEVICE(s); > > > > -    s->cap = VTD_CAP_FRO | VTD_CAP_NFR | VTD_CAP_ND | VTD_ECAP_PT | > > +    s->cap = VTD_CAP_FRO | VTD_CAP_NFR | VTD_CAP_ND | > >               VTD_CAP_MAMV | VTD_CAP_PSI | VTD_CAP_SSLPS | VTD_CAP_DRAIN | > >               VTD_CAP_ESRTPS | VTD_CAP_MGAW(s->aw_bits); > >      if (x86_iommu->dma_translation) { > > @@ -4999,7 +4999,7 @@ static void vtd_cap_init(IntelIOMMUState *s) > >                      s->cap |= VTD_CAP_SAGAW_48bit; > >              } > >      } > > -    s->ecap = VTD_ECAP_QI | VTD_ECAP_IRO; > > +    s->ecap = VTD_ECAP_QI | VTD_ECAP_IRO | VTD_ECAP_PT; > > > >      if (x86_iommu_ir_supported(x86_iommu)) { > >          s->ecap |= VTD_ECAP_IR | VTD_ECAP_MHMV; > > -- > > 2.54.0 > >