From: Jakub Kicinski <kuba@kernel.org>
To: Shay Drori <shayd@nvidia.com>
Cc: Simon Horman <horms@kernel.org>, <tariqt@nvidia.com>,
<edumazet@google.com>, <pabeni@redhat.com>,
<andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<saeedm@nvidia.com>, <mbloch@nvidia.com>, <leon@kernel.org>,
<ohartoov@nvidia.com>, <edwards@nvidia.com>,
<msanalla@nvidia.com>, <phaddad@nvidia.com>, <parav@nvidia.com>,
<gbayer@linux.ibm.com>, <kees@kernel.org>, <moshe@nvidia.com>,
<rongweil@nvidia.com>, <jacob.e.keller@intel.com>,
<netdev@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <gal@nvidia.com>
Subject: Re: [PATCH net 3/3] net/mlx5e: TC, skip peer flow cleanup when LAG seq is unavailable
Date: Mon, 22 Jun 2026 17:03:54 -0700 [thread overview]
Message-ID: <20260622170354.5f87d24b@kernel.org> (raw)
In-Reply-To: <e18662ac-413e-43f6-ac65-a4e15fd47bb7@nvidia.com>
On Mon, 22 Jun 2026 09:40:44 +0300 Shay Drori wrote:
> > [Severity: Critical]
> > Does skipping the remainder of this loop prevent the flow from being
> > unlinked from the doubly-linked list?
> >
> > By using continue here in mlx5e_tc_del_fdb_peers_flow(), we skip calling
> > mlx5e_tc_del_fdb_peer_flow(), which means flow->peer[i] is never
> > unlinked from the esw->offloads.peer_flows[original_i] list.
>
> only in case a LAG member is removed from ldev, mlx5_lag_get_dev_seq()
> will return error.
> before LAG member is removed, esw->devcom is cleanup, which invoke
> mlx5e_tc_clean_fdb_peer_flows(), which remove all peer flows.
> Hence, no flow remains.
Thanks for responding. That said, the series no longer applies.
--
pw-bot: cr
prev parent reply other threads:[~2026-06-23 0:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 6:32 [PATCH net 0/3] net/mlx5: LAG bug fixes Tariq Toukan
2026-06-17 6:32 ` [PATCH net 1/3] net/mlx5: LAG, Fix off-by-one in single-FDB error rollback Tariq Toukan
2026-06-17 6:32 ` [PATCH net 2/3] net/mlx5: LAG, MPESW, Fix missing complete() on devcom error Tariq Toukan
2026-06-17 6:32 ` [PATCH net 3/3] net/mlx5e: TC, skip peer flow cleanup when LAG seq is unavailable Tariq Toukan
2026-06-18 12:48 ` Simon Horman
2026-06-22 6:40 ` Shay Drori
2026-06-23 0:03 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260622170354.5f87d24b@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=edwards@nvidia.com \
--cc=gal@nvidia.com \
--cc=gbayer@linux.ibm.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kees@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=msanalla@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=ohartoov@nvidia.com \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
--cc=phaddad@nvidia.com \
--cc=rongweil@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=shayd@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.