All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <dev@lankhorst.se>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	"John B. Wyatt IV" <jwyatt@redhat.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Maarten Lankhorst <dev@lankhorst.se>
Subject: [PATCH v9 17/30] drm/i915/guc: Consider also RCU depth in busy loop.
Date: Mon, 22 Jun 2026 20:10:30 +0200	[thread overview]
Message-ID: <20260622181044.39335-18-dev@lankhorst.se> (raw)
In-Reply-To: <20260622181044.39335-1-dev@lankhorst.se>

From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

intel_guc_send_busy_loop() looks at in_atomic() and irqs_disabled() to
decide if it should busy-spin while waiting or if it may sleep.
Both checks will report false on PREEMPT_RT if sleeping spinlocks are
acquired leading to RCU splats while the function sleeps.

Check also if RCU has been disabled.

Reported-by: "John B. Wyatt IV" <jwyatt@redhat.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
---
 drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
index 053780f562c1a..b25fa8f4dc4bd 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
@@ -362,7 +362,7 @@ static inline int intel_guc_send_busy_loop(struct intel_guc *guc,
 {
 	int err;
 	unsigned int sleep_period_ms = 1;
-	bool not_atomic = !in_atomic() && !irqs_disabled();
+	bool not_atomic = !in_atomic() && !irqs_disabled() && !rcu_preempt_depth();
 
 	/*
 	 * FIXME: Have caller pass in if we are in an atomic context to avoid
-- 
2.53.0


  parent reply	other threads:[~2026-06-22 18:11 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-22 18:10 [PATCH v9 00/30] drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 01/30] drm/vblank_work: Add methods to schedule vblank_work in 2 stages Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 02/30] drm/vblank: Add a 2-stage version of drm_crtc_arm_vblank_event Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 03/30] drm/intel/display: Make intel_crtc_arm_vblank_event static Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 04/30] drm/intel/display: Convert vblank event handling to 2-stage arming Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 05/30] drm/i915/display: Move vblank put until after critical section Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 06/30] drm/i915/display: Remove locking from intel_vblank_evade " Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 07/30] drm/i915/display: Handle vlv dsi workaround in scanline_in_safe_range too Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 08/30] drm/i915: Use preempt_disable/enable_rt() where recommended Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 09/30] drm/i915/display: Make get_vblank_counter use intel_de_read_fw() Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 10/30] drm/i915/display: Do not take uncore lock in i915_get_vblank_counter Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 11/30] drm/i915/display: Make icl_dsi_frame_update use _fw too Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 12/30] drm/i915/display: Use intel_de_read/write_fw in colorops Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 13/30] drm/i915/display: Use intel_de_write_fw in intel_pipe_fastset Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 14/30] drm/i915/display: Make set_pipeconf use the fw variants Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 15/30] drm/i915/gt: Use spin_lock_irq() instead of local_irq_disable() + spin_lock() Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 16/30] drm/i915: Drop the irqs_disabled() check Maarten Lankhorst
2026-06-22 18:10 ` Maarten Lankhorst [this message]
2026-06-22 18:10 ` [PATCH v9 18/30] drm/i915/gt: Fix selftests on PREEMPT_RT Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 19/30] drm/i915/gt: Set stop_timeout() correctly on PREEMPT-RT Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 20/30] drm/i915/display: Remove uncore lock from vlv_atomic_update_fifo Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 21/30] drm/i915: Use sleeping selftests for igt_atomic on PREEMPT_RT Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 22/30] Revert "drm/i915: Depend on !PREEMPT_RT." Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 23/30] PREEMPT_RT injection Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 24/30] FOR-CI: bump MAX_STACK_TRACE_ENTRIES Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 25/30] drm/i915/gt: Add a spinlock to prevent starvation of irq_work Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 26/30] drm/xe: Avoid using stolen memory for DPT Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 27/30] drm/xe/display: Avoid using stolen memory for framebuffer when media gt exists Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 28/30] drm/xe/display: Do not allocate into stolen for new framebuffers Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 29/30] drm/i915/pmu: Convert to raw spinlock Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 30/30] drm/i915/guc: Make timestamp.lock a " Maarten Lankhorst
2026-06-23 12:57   ` [PATCH v9.5] drm/i915: Disable "busy" pmu event on CONFIG_PREEMPT_RT Maarten Lankhorst
2026-06-23 15:06     ` sashiko-bot
2026-06-23 13:27   ` [PATCH v9.6] " Maarten Lankhorst
2026-06-23 13:39     ` sashiko-bot
2026-06-22 18:31 ` ✗ CI.checkpatch: warning for drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe. (rev17) Patchwork
2026-06-22 18:32 ` ✓ CI.KUnit: success " Patchwork
2026-06-22 18:47 ` ✗ CI.checksparse: warning " Patchwork
2026-06-22 19:09 ` ✗ i915.CI.BAT: failure " Patchwork
2026-06-22 19:33 ` ✓ Xe.CI.BAT: success " Patchwork
2026-06-23  0:05 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260622181044.39335-18-dev@lankhorst.se \
    --to=dev@lankhorst.se \
    --cc=bigeasy@linutronix.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jwyatt@redhat.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.