Re: [PATCH] GPU: drm: meson: inline call to drm_simple_encoder_init()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch introduces a duplicate definition of the `drm_simple_encoder_funcs_cleanup` structure, causing a build failure.
--

commit 2bbec9d596493f3ca9a28c3ddb628d5753d83aa2
Author: Liam Zuiderhoek <zuiderhoekl@gmail.com>

GPU: drm: meson: inline call to drm_simple_encoder_init()

This commit inlines the function drm_simple_encoder_init for the meson
driver. It replaces the simple encoder init call with drm_encoder_init
and a custom cleanup struct.

> diff --git a/drivers/gpu/drm/meson/meson_encoder_hdmi.c b/drivers/gpu/drm/meson/meson_encoder_hdmi.c
> index 55c0601df3c62..f4100e23dd270 100644
> --- a/drivers/gpu/drm/meson/meson_encoder_hdmi.c
> +++ b/drivers/gpu/drm/meson/meson_encoder_hdmi.c
> @@ -44,9 +44,17 @@ struct meson_encoder_hdmi {
>  	struct cec_notifier *cec_notifier;
>  };
>  
> +static const struct drm_encoder_funcs drm_simple_encoder_funcs_cleanup = {
> +	.destroy = drm_encoder_cleanup,
> +};
> +
>  #define bridge_to_meson_encoder_hdmi(x) \
>  	container_of(x, struct meson_encoder_hdmi, bridge)
>  
> +static const struct drm_encoder_funcs drm_simple_encoder_funcs_cleanup = {
> +	.destroy = drm_encoder_cleanup,
> +};

[Severity: Low]
Does this code cause a compiler error? It appears that the static structure
drm_simple_encoder_funcs_cleanup is defined twice in the same file.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260622193250.211429-1-zuiderhoekl@gmail.com?part=1