From: Tristan Madani <tristmd@gmail.com>
To: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>
Cc: Eduard Zingerman <eddyz87@gmail.com>,
Xu Kuohai <xukuohai@huawei.com>, Jiri Olsa <jolsa@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Martin KaFai Lau <martin.lau@linux.dev>,
bpf@vger.kernel.org, stable@vger.kernel.org,
tristan@talencesecurity.com
Subject: [PATCH bpf v3 0/2] Fix stale register bounds on LSM retval context load
Date: Mon, 22 Jun 2026 23:01:21 +0000 [thread overview]
Message-ID: <20260622230123.3695446-1-tristmd@gmail.com> (raw)
From: Tristan Madani <tristan@talencesecurity.com>
check_mem_access() calls __mark_reg_s32_range() to narrow a register to
the LSM hook retval range, but the intersection preserves stale bounds
from prior instructions. Add mark_reg_unknown() before narrowing (same
pattern as the else branch) and a selftest that catches the mismatch.
Changes in v3:
- Add selftest demonstrating the issue (Eduard Zingerman)
- No code change in patch 1 from v2
Tristan Madani (2):
bpf: Reset register bounds before narrowing retval range in
check_mem_access()
selftests/bpf: Add test for stale bounds on LSM retval context load
kernel/bpf/verifier.c | 1 +
tools/testing/selftests/bpf/progs/verifier_lsm.c | 15 +++++++++++++++
2 files changed, 16 insertions(+)
--
2.47.3
next reply other threads:[~2026-06-22 23:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 23:01 Tristan Madani [this message]
2026-06-22 23:01 ` [PATCH bpf v3 1/2] bpf: Reset register bounds before narrowing retval range in check_mem_access() Tristan Madani
2026-06-22 23:48 ` bot+bpf-ci
2026-06-23 0:07 ` Eduard Zingerman
2026-06-22 23:01 ` [PATCH bpf v3 2/2] selftests/bpf: Add test for stale bounds on LSM retval context load Tristan Madani
2026-06-23 0:08 ` Eduard Zingerman
2026-06-23 0:30 ` [PATCH bpf v3 0/2] Fix stale register " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260622230123.3695446-1-tristmd@gmail.com \
--to=tristmd@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=martin.lau@linux.dev \
--cc=stable@vger.kernel.org \
--cc=tristan@talencesecurity.com \
--cc=xukuohai@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.