All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huiwen He <huiwen.he@linux.dev>
To: smfrench@gmail.com, linkinjeon@kernel.org, pc@manguebit.org,
	ronniesahlberg@gmail.com, sprasad@microsoft.com, tom@talpey.com,
	bharathsm@microsoft.com, senozhatsky@chromium.org,
	dhowells@redhat.com, metze@samba.org, chenxiaosong@kylinos.cn
Cc: linux-cifs@vger.kernel.org
Subject: [PATCH 0/7] smb/client: fix fallocate allocation handling
Date: Tue, 23 Jun 2026 10:46:12 +0800	[thread overview]
Message-ID: <20260623024619.1360127-1-huiwen.he@linux.dev> (raw)

From: Huiwen He <hehuiwen@kylinos.cn>

CIFS fallocate can return success without allocating the requested space.
It can also derive i_blocks from EOF, making sparse files appear fully
allocated.

This series propagates sparse conversion failures, corrects i_blocks
accounting, and verifies server allocation after EOF-extending mode 0
fallocate. It also reduces the memory used by zero-write emulation and
supports small ranges starting at EOF.

General arbitrary-range preallocation remains unsupported because SMB2
provides no equivalent operation. Small ranges can be emulated by writing
zeroes.

Tested against Samba with xfstests. With `strict allocate=yes`,
generic/496, generic/568 and generic/701 pass with server allocation
verified. generic/495 was used to verify that EOF extension no longer
inflates i_blocks.

With `strict allocate=no`, requests whose allocation cannot be verified
fail instead of reporting false preallocation success.

Huiwen He (7):
  smb/client: name the default fallocate mode
  smb/client: handle smb2_set_sparse() failure in EOF-extending
    fallocate
  smb/client: handle smb2_set_sparse() failure in non-extending
    fallocate
  smb/client: do not account EOF extension as allocation
  smb/client: verify allocation after EOF-extending fallocate
  smb/client: reduce fallocate zero buffer allocation
  smb/client: emulate small fallocate ranges at EOF

 fs/smb/client/inode.c     |  13 +++-
 fs/smb/client/smb2ops.c   | 128 +++++++++++++++++++++++++++++++++-----
 fs/smb/client/smb2pdu.c   |  19 ++++++
 fs/smb/client/smb2proto.h |   3 +
 fs/smb/common/fscc.h      |   5 ++
 5 files changed, 151 insertions(+), 17 deletions(-)

-- 
2.43.0


             reply	other threads:[~2026-06-23  2:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-23  2:46 Huiwen He [this message]
2026-06-23  2:46 ` [PATCH 1/7] smb/client: name the default fallocate mode Huiwen He
2026-06-23  3:50   ` Steve French
2026-06-23  2:46 ` [PATCH 2/7] smb/client: handle smb2_set_sparse() failure in EOF-extending fallocate Huiwen He
2026-06-23  2:46 ` [PATCH 3/7] smb/client: handle smb2_set_sparse() failure in non-extending fallocate Huiwen He
2026-06-23  2:46 ` [PATCH 4/7] smb/client: do not account EOF extension as allocation Huiwen He
2026-06-23  2:46 ` [PATCH 5/7] smb/client: verify allocation after EOF-extending fallocate Huiwen He
2026-06-23  2:46 ` [PATCH 6/7] smb/client: reduce fallocate zero buffer allocation Huiwen He
2026-06-23  2:46 ` [PATCH 7/7] smb/client: emulate small fallocate ranges at EOF Huiwen He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260623024619.1360127-1-huiwen.he@linux.dev \
    --to=huiwen.he@linux.dev \
    --cc=bharathsm@microsoft.com \
    --cc=chenxiaosong@kylinos.cn \
    --cc=dhowells@redhat.com \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=metze@samba.org \
    --cc=pc@manguebit.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=senozhatsky@chromium.org \
    --cc=smfrench@gmail.com \
    --cc=sprasad@microsoft.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.