Re: [PATCH] drm/i915/psr: Skip PSR exit for legacy cursor updates on LNL

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Unconditionally skipping PSR flush/exit for legacy cursor updates reintroduces cursor trailing artifacts on pre-LNL platforms with PSR2 selective fetch.
--

commit 2fb445d4d3ce6ed075913638e7c06b17876c62bb
Author: Aaron Ma <aaron.ma@canonical.com>
drm/i915/psr: Skip PSR exit for legacy cursor updates on LNL

This commit modifies the PSR flush handler to unconditionally skip the
PSR exit path for legacy cursor updates. It removes the selective fetch
check to resolve visual artifacts during exit/re-enable transitions on LNL.

> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index e138982dc91f6..32bee6c03b754 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -3771,8 +3771,7 @@ void intel_psr_flush(struct intel_display *display,
>  			goto unlock;
>  
>  		if (origin == ORIGIN_FLIP ||
> -		    (origin == ORIGIN_CURSOR_UPDATE &&
> -		     !intel_dp->psr.psr2_sel_fetch_enabled)) {
> +		    origin == ORIGIN_CURSOR_UPDATE) {

[Severity: Medium]
Will unconditionally removing the !intel_dp->psr.psr2_sel_fetch_enabled
guard reintroduce cursor trailing artifacts on pre-LNL platforms?

The commit message mentions skipping PSR exit for LNL, but the change applies
to all platforms.

Any legacy cursor update on pre-LNL platforms with PSR2 selective fetch
enabled will now trigger intel_legacy_cursor_update(), which issues
ORIGIN_CURSOR_UPDATE and bypasses the full-frame fallback update in
_psr_flush_handle().

Could this revert the behavior introduced in commit ef39826c12b4 for older
platforms?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260623084137.3421894-1-aaron.ma@canonical.com?part=1