All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Dr. David Alan Gilbert" <dave@treblig.org>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Christian Brauner" <brauner@kernel.org>,
	devel@lists.libvirt.org, "Markus Armbruster" <armbru@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@mailo.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH v4 08/35] monitor: add 'pretty' property to QMP Monitor class
Date: Tue, 23 Jun 2026 10:55:24 +0100	[thread overview]
Message-ID: <20260623095551.2106712-9-berrange@redhat.com> (raw)
In-Reply-To: <20260623095551.2106712-1-berrange@redhat.com>

This determines whether the QMP JSON responses are pretty printed
with newlines and indentation, or compact with no extra whitespace.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 monitor/qmp.c | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/monitor/qmp.c b/monitor/qmp.c
index 0abf2677f9..2a8532ef96 100644
--- a/monitor/qmp.c
+++ b/monitor/qmp.c
@@ -77,8 +77,25 @@ static void monitor_qmp_finalize(Object *obj)
 {
 }
 
+static bool monitor_qmp_get_pretty(Object *obj, Error **errp)
+{
+    MonitorQMP *mon = MONITOR_QMP(obj);
+
+    return mon->pretty;
+}
+
+static void monitor_qmp_set_pretty(Object *obj, bool val, Error **errp)
+{
+    MonitorQMP *mon = MONITOR_QMP(obj);
+
+    mon->pretty = val;
+}
+
 static void monitor_qmp_class_init(ObjectClass *cls, const void *data)
 {
+    object_class_property_add_bool(cls, "pretty",
+                                   monitor_qmp_get_pretty,
+                                   monitor_qmp_set_pretty);
 }
 
 static void monitor_qmp_init(Object *obj)
@@ -538,6 +555,7 @@ void monitor_new_qmp(const char *chardev_id, bool pretty, Error **errp)
                                         id,
                                         errp,
                                         "chardev", chardev_id,
+                                        "pretty", pretty ? "yes" : "no",
                                         NULL);
 
     if (!obj) {
@@ -558,8 +576,6 @@ void monitor_new_qmp(const char *chardev_id, bool pretty, Error **errp)
                       qemu_chr_has_feature(mon->parent_obj.chr.chr,
                                            QEMU_CHAR_FEATURE_GCONTEXT));
 
-    mon->pretty = pretty;
-
     qemu_mutex_init(&mon->qmp_queue_lock);
     mon->qmp_requests = g_queue_new();
 
-- 
2.54.0



  parent reply	other threads:[~2026-06-23  9:57 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-23  9:55 [PATCH v4 00/35] monitor: turn QMP and HMP into QOM objects Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 01/35] qom: replace 'can_be_deleted' with 'prepare_delete' Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 02/35] monitor: replace 'common' with 'parent_obj' in MonitorHMP Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 03/35] monitor: replace 'common' with 'parent_obj' in MonitorQMP Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 04/35] monitor: rename monitor_init* to monitor_new* Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 05/35] monitor: minimal conversion of monitors to QOM Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 06/35] monitor: add 'chardev' property to Monitor base class Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 07/35] monitor: add 'readline' property to HMP Monitor class Daniel P. Berrangé
2026-06-23  9:55 ` Daniel P. Berrangé [this message]
2026-06-23  9:55 ` [PATCH v4 09/35] monitor: remove 'skip_flush' field Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 10/35] monitor: move monitor_data_(init|destroy) into QOM init/finalize Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 11/35] monitor: use class methods for monitor_vprintf Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 12/35] monitor: use class methods for monitor_qapi_event_emit Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 13/35] monitor: use class methods for monitor_accept_input Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 14/35] monitor: use class method for I/O thread request Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 15/35] monitor: use dynamic cast in monitor_qmp_requests_pop_any_with_lock Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 16/35] util: use dynamic cast in error vreport Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 17/35] monitor: drop unused monitor_cur_is_qmp Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 18/35] monitor: use dynamic cast in QMP commands Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 19/35] monitor: use dynamic cast in monitor_is_hmp_non_interactive Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 20/35] monitor: drop unused monitor_is_qmp method Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 21/35] monitor: eliminate monitor_is_hmp_non_interactive method Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 22/35] monitor: implement "user creatable" interface for adding monitors Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 23/35] monitor: convert from oneshot BH to persistent BH Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 24/35] monitor: reject attempts to delete the current monitor Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 25/35] monitor: protect qemu_chr_fe_accept_input with monitor lock Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 26/35] monitor: implement support for deleting QMP objects Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 27/35] tests/qtest: add tests for dynamic monitor add/remove Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 28/35] tests/functional: add e2e test for dynamic QMP monitor hotplug Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 29/35] tests/functional: add a stress test for monitor hot unplug Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 30/35] qom: add method for getting the "id" of a QOM object Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 31/35] qom: add trace events for user creatable create/delete APIs Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 32/35] monitor: add support for auto-deleting monitors upon close Daniel P. Berrangé
2026-06-23 11:53   ` marcandre.lureau
2026-06-23 11:55     ` Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 33/35] tests: switch from -mon to -object monitor-qmp Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 34/35] qemu-options: document new monitor-hmp and monitor-qmp objects Daniel P. Berrangé
2026-06-23  9:55 ` [PATCH v4 35/35] docs: mark '-mon' as deprecated in favour of -object Daniel P. Berrangé
2026-06-23 11:03 ` [PATCH v4 00/35] monitor: turn QMP and HMP into QOM objects Peter Krempa
2026-06-23 11:07   ` Peter Krempa
2026-06-23 11:38   ` Daniel P. Berrangé
2026-06-23 11:52     ` Daniel P. Berrangé
2026-06-23 11:54       ` Marc-André Lureau
2026-06-23 12:01         ` Daniel P. Berrangé
2026-06-23 12:18       ` Peter Krempa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260623095551.2106712-9-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=brauner@kernel.org \
    --cc=dave@treblig.org \
    --cc=devel@lists.libvirt.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@mailo.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.