Re: [PATCH] usb: dwc3: imx8mp: make dwc3_imx_glue_ops static and rename to imx8mp

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The keyword `static` is misspelled as `statc`, causing a compilation syntax error.
- [Low] The struct is initialized with the undeclared function `dwc3_imx8mp_pre_set_role`.
--

commit 7c7aefb84ba9dd8d7379b9aae197107a91b20ee1
Author: Ben Dooks <ben.dooks@codethink.co.uk>

usb: dwc3: imx8mp: make dwc3_imx_glue_ops static and rename to imx8mp

This commit makes the dwc3_imx_glue_ops structure static to resolve a missing
declaration warning. It also renames the structure to dwc3_imx8mp_glue_ops to
distinguish it from other drivers.

> diff --git a/drivers/usb/dwc3/dwc3-imx8mp.c b/drivers/usb/dwc3/dwc3-imx8mp.c
> --- a/drivers/usb/dwc3/dwc3-imx8mp.c
> +++ b/drivers/usb/dwc3/dwc3-imx8mp.c
> @@ -173,8 +173,8 @@ static void dwc3_imx_pre_set_role(struct dwc3 *dwc, enum usb_role role)
>  		pm_runtime_use_autosuspend(dwc->dev);
>  }
>  
> -struct dwc3_glue_ops dwc3_imx_glue_ops = {
> -	.pre_set_role   = dwc3_imx_pre_set_role,
> +statc struct dwc3_glue_ops dwc3_imx8mp_glue_ops = {

[Severity: Low]
Does this cause a compilation error? It looks like the static keyword is
misspelled as statc here.

> +	.pre_set_role   = dwc3_imx8mp_pre_set_role,

[Severity: Low]
Will this initialization also fail to compile? The structure is pointing to
dwc3_imx8mp_pre_set_role, but earlier in the file the function remains named
dwc3_imx_pre_set_role:

static void dwc3_imx_pre_set_role(struct dwc3 *dwc, enum usb_role role)
{
        ...

It seems the function renaming might have been left out of this patch.

>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260623100554.735080-1-ben.dooks@codethink.co.uk?part=1